From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25B5C43219 for ; Fri, 26 Apr 2019 10:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C45C2067C for ; Fri, 26 Apr 2019 10:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="J1u2eDCG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbfDZKGC (ORCPT ); Fri, 26 Apr 2019 06:06:02 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:37307 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbfDZKGB (ORCPT ); Fri, 26 Apr 2019 06:06:01 -0400 Received: by mail-lf1-f67.google.com with SMTP id h126so2053160lfh.4 for ; Fri, 26 Apr 2019 03:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V6YfoSDGzpRc5jf/Ret2tebWXfDQiQOnbiio0o2ZU6E=; b=J1u2eDCGJ2gEioZTB921qsXqhJT6wj/kGUqepebtFVKjTSdJggMoCosui9RSYJo6Jy VzsD/zhtV+95zn57iya3oiKD0AoMsu7h6C9mh8KhSttxweUag0JmZFPXmZJna/iouiiu lNBqkaCqEeQPxhrZDX/w1tWKj3vBVlQVMS5IM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V6YfoSDGzpRc5jf/Ret2tebWXfDQiQOnbiio0o2ZU6E=; b=Z43ByYlPb6DCErI6qee9s9spfSmUsI/rYlM6bYHoBCo20HHcUAbFyw7Lec8rkkkC2t U+s6mlc5TF4PvWgkVUvwPl/Sa2J2Lqu7W6Xa6Oy/4w/wwICZc4qq6Rcx1lJT+T9SMxNl Iajpqg0efl4lAeQOQXQvLpJeTGbq/uMmu9zhLCNrhnugmhBbjlYknGHG09nofbsaQa2/ pT26+B5+jTiChJzyp91xn7UmHb9CeONrKXryq/lFn+wgD7moZ9bj16kbLeyKQHyApmQc 1kN+vAnlQbJAGgyNb4HnW5P4qUg8Lc6mZsb9s50Tx1KD0nvnmVvKm+/yQV+wWakipVMV m98g== X-Gm-Message-State: APjAAAVlRfoaGCj4BAACLY8nSoQPCx4VdmJ0mzcq4OCheU8IpN4N9Eq/ 50UrniluP+WQk9lzZE3iiC+mZg== X-Google-Smtp-Source: APXvYqyQ/3Ze+NoK18P3XhfyG2CTLYM7V7o3VpK8T6b+OrXiZ7EaMMNLhQA69cVTra4J966OKvyOOw== X-Received: by 2002:ac2:482e:: with SMTP id 14mr21642162lft.1.1556273159457; Fri, 26 Apr 2019 03:05:59 -0700 (PDT) Received: from [172.16.11.26] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id y19sm5484183lfb.24.2019.04.26.03.05.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 03:05:58 -0700 (PDT) Subject: Re: [PATCH 09/10] arm64: select DYNAMIC_DEBUG_RELATIVE_POINTERS To: Arnd Bergmann , Rasmus Villemoes Cc: Andrew Morton , Linux ARM , Will Deacon , Jason Baron , Linux Kernel Mailing List , clang-built-linux@googlegroups.com, Nathan Chancellor , Nick Desaulniers References: <20190409212517.7321-1-linux@rasmusvillemoes.dk> <20190409212517.7321-10-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <94b816aa-ad36-75e6-8782-d141dec2e803@rasmusvillemoes.dk> Date: Fri, 26 Apr 2019 12:05:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/2019 11.39, Arnd Bergmann wrote: > On Tue, Apr 9, 2019 at 11:26 PM Rasmus Villemoes > wrote: >> >> Similar to GENERIC_BUG_RELATIVE_POINTERS, one can now relativize the >> four const char* members of struct _ddebug, thus saving 16 bytes per >> instance (one for each pr_debug(), dev_debug() etc. in a >> CONFIG_DYNAMIC_DEBUG kernel). The asm-generic implementation seems to >> work out-of-the-box, though this is only compile-tested. >> >> Signed-off-by: Rasmus Villemoes > > This causes a build regression when compiling with clang, > see http://staging-storage.kernelci.org/next-clang/master/next-20190424/arm64/allmodconfig/clang-8/build.log Yes, see also https://github.com/ClangBuiltLinux/linux/issues/456 . The quickest short-term fix is to append "if CC_IS_GCC" to the select statements. Then when a fix lands in clang one can change that to "if CC_IS_GCC || CLANG_VERSION >= something". It's probably best if we fix -next builds ASAP instead of waiting for knowing the proper value of "something". Nathan, Nick, WDYT? I had 0day verify my patches before sending them out officially, and thought it also did clang builds. But apparently not, or not with enough arch/.config combinations? Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390BCC43219 for ; Fri, 26 Apr 2019 10:06:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A8182067C for ; Fri, 26 Apr 2019 10:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MIJqY2Fa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="J1u2eDCG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A8182067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ASNliapAJpo72/xA2KIpqgoQVyC/IKzFniqn9wu9ULw=; b=MIJqY2Faqhj7eO fq4uRZSKpUyiRcDTYX2zQKWBS2Croo4pNTq0v+04D9P4orux7MYOq2HPpP8dWjCZ0MNEFYmZfVaeK UhaCKCgYx/zfCVls3WQJIuN4nmphQ0bLVXUnVA4U2ZVhniZovhIXFm7slRs1hnkrhmYNQS0Z2FvlD 8nmAt0pips9liQBdu/EcJ5epL/IDBlpumaeXLqjIAjevlC61ERQJ85uTfIgdPF3zayMb6F6Y92biN 9/fF/TMDM4FHvv735vGO+4KLiPG8RTN3zj9/X8C5/9mrq4RcsZQlgZ6RLK8/NOIokaOwl+iB2ZkFn EVCMJEl33sPJQUpeGnIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJxk6-0006Y8-91; Fri, 26 Apr 2019 10:06:06 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJxk2-0006XN-0e for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2019 10:06:04 +0000 Received: by mail-lf1-x142.google.com with SMTP id d12so2042767lfk.6 for ; Fri, 26 Apr 2019 03:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V6YfoSDGzpRc5jf/Ret2tebWXfDQiQOnbiio0o2ZU6E=; b=J1u2eDCGJ2gEioZTB921qsXqhJT6wj/kGUqepebtFVKjTSdJggMoCosui9RSYJo6Jy VzsD/zhtV+95zn57iya3oiKD0AoMsu7h6C9mh8KhSttxweUag0JmZFPXmZJna/iouiiu lNBqkaCqEeQPxhrZDX/w1tWKj3vBVlQVMS5IM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V6YfoSDGzpRc5jf/Ret2tebWXfDQiQOnbiio0o2ZU6E=; b=qLSkNmgJjcDIDqKUyao+g8sredl3pU1slnzJHWkhidsEpHHUE1CpvvE7qPYTP9hdKe m/4WzQFgfgPhSLtVL6AOhvTc9kzfIxr8BIyWFMxB1LaQNiHkrqEouU+MzTbsX79JJ+Zu dwSMWX2XA3nMbnrgxJkXshqEdVuNh2szH7LWhKpWsftZxYWzhQ69cz/avIKZRxqtWvSo inkmTC2UEU8C1U9c0vy6gNeg5OOYl103k3rovKu6FKxgKVsyWHua3heS8bLGL+E65E1k Lc/1OdxTVbJtTJ09u56JzybW9o51ClpaKJmNxRx4wed/jP1AT81w02nRZYiX5iZpGwIG jsQg== X-Gm-Message-State: APjAAAWyrwSDi8vy8AVrPlS3Ey/b0Ur6zvbB/xWtk1pQ96kaPTO7WXE6 td9xppBCvKlHSo2yhexhKL1bdg== X-Google-Smtp-Source: APXvYqyQ/3Ze+NoK18P3XhfyG2CTLYM7V7o3VpK8T6b+OrXiZ7EaMMNLhQA69cVTra4J966OKvyOOw== X-Received: by 2002:ac2:482e:: with SMTP id 14mr21642162lft.1.1556273159457; Fri, 26 Apr 2019 03:05:59 -0700 (PDT) Received: from [172.16.11.26] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id y19sm5484183lfb.24.2019.04.26.03.05.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 03:05:58 -0700 (PDT) Subject: Re: [PATCH 09/10] arm64: select DYNAMIC_DEBUG_RELATIVE_POINTERS To: Arnd Bergmann , Rasmus Villemoes References: <20190409212517.7321-1-linux@rasmusvillemoes.dk> <20190409212517.7321-10-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <94b816aa-ad36-75e6-8782-d141dec2e803@rasmusvillemoes.dk> Date: Fri, 26 Apr 2019 12:05:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_030602_210647_97C7028C X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nick Desaulniers , Will Deacon , Linux Kernel Mailing List , clang-built-linux@googlegroups.com, Jason Baron , Andrew Morton , Nathan Chancellor , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/04/2019 11.39, Arnd Bergmann wrote: > On Tue, Apr 9, 2019 at 11:26 PM Rasmus Villemoes > wrote: >> >> Similar to GENERIC_BUG_RELATIVE_POINTERS, one can now relativize the >> four const char* members of struct _ddebug, thus saving 16 bytes per >> instance (one for each pr_debug(), dev_debug() etc. in a >> CONFIG_DYNAMIC_DEBUG kernel). The asm-generic implementation seems to >> work out-of-the-box, though this is only compile-tested. >> >> Signed-off-by: Rasmus Villemoes > > This causes a build regression when compiling with clang, > see http://staging-storage.kernelci.org/next-clang/master/next-20190424/arm64/allmodconfig/clang-8/build.log Yes, see also https://github.com/ClangBuiltLinux/linux/issues/456 . The quickest short-term fix is to append "if CC_IS_GCC" to the select statements. Then when a fix lands in clang one can change that to "if CC_IS_GCC || CLANG_VERSION >= something". It's probably best if we fix -next builds ASAP instead of waiting for knowing the proper value of "something". Nathan, Nick, WDYT? I had 0day verify my patches before sending them out officially, and thought it also did clang builds. But apparently not, or not with enough arch/.config combinations? Rasmus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel