From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D40C4338F for ; Wed, 11 Aug 2021 11:57:55 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 7C41160F56 for ; Wed, 11 Aug 2021 11:57:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7C41160F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69DE740C35; Wed, 11 Aug 2021 13:57:54 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 6BA3840042 for ; Wed, 11 Aug 2021 13:57:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="202293464" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="202293464" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 04:57:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="571114604" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 11 Aug 2021 04:57:52 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 04:57:51 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 04:57:51 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 11 Aug 2021 04:57:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 11 Aug 2021 04:57:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQtH/C+oOPGTYu/PAFTEfQbgYW6exV7FLcriLnvBughgJIIrCrykE5OjX8HUwdC16tBJ99pHX2hDR/f3vjrTRmYPJTzENIHv+wiIb5w8NQ0emwovG9m9a0AvG8/Z3bkUUm4bDt2EDPRwDFXPXj+1K3pzeW2b+87fhV9A+HmR3gpop4A7zyKNp5FPFMJCoQauMFmUF6NrTX6skY9Cv+PJ9yzgkQaB7SdCDYOUmqIoaTQ6Og5+dUkXClZDDpqy6oMaEUua1maMhot0rlE+LtpdeinVmOIpTU/DoWmawC3L/qV8P7Z8U41EJDOntdUX6dyJ0JZp9yPK/mSh7mMs4MlNLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtD9rJSLN7/6yTvYFKiqVV3BtD97S72oCPypQTI9kOE=; b=Q9h4nM9YpvMhZ2g+V2ENi/0hFLniscISa4lh6bdI1/5QU1c5LgBi4/I/FBkiTyqLLLvP9pl2BYBt7Ged9Df9RSYbe5E1wPE57HqVuXj5srg8Ua0EClolBxKcgOK+5UpCw01fZn03VXuaVY+g1gKuh8qdvbnIHxVl6L2cZg7iGa1T1gDppM3LmAAYsqPuO5Q/8S8oduZU4vlPP3RTnMzidLtcU64oBXiPpNOWQTxVTdTZVLQ4xlANKtf/WM+bHk8WLay3S//e1/zwi685fi05xh6PMHWTa3KU+GSgOuZps7PjwBboowA+JyMIaPLSbSttvP58LtacUcMlQXqTQ3168g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtD9rJSLN7/6yTvYFKiqVV3BtD97S72oCPypQTI9kOE=; b=EyDIOia8XwvjDEFuYUyDAS48lMKVdnVUma7CUnzjQOzkcUtt6zWmDbzvgKd/iTWxHFDQlfhGoUXq/LmfS5n6fhS/KsrOLIKcCd71DHUWiof4rdKRshEOVHLHOTUD78AVb7ajbCgDTTYVQM79Uaio2t4Tj6b9AkcE8LC6QqfqL9M= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4808.namprd11.prod.outlook.com (2603:10b6:510:39::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Wed, 11 Aug 2021 11:57:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.016; Wed, 11 Aug 2021 11:57:49 +0000 To: "Xueming(Steven) Li" , "Singh, Aman Deep" , Andrew Rybchenko CC: "dev@dpdk.org" , Slava Ovsiienko , NBU-Contact-Thomas Monjalon , "jerinj@marvell.com" References: <20210727034134.20556-1-xuemingl@nvidia.com> <24309185-57e8-9a21-6b3a-939c4d74f1e7@oktetlabs.ru> <3032fdb1-58a5-5470-9903-09b992c059d4@intel.com> <8f8178d5-65e5-43f4-fc17-f753183e8042@intel.com> <534241c3-4423-bfa9-b7ee-56f0f5e59f5f@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <94c1dc7a-cf48-7f35-59c8-20795cef3070@intel.com> Date: Wed, 11 Aug 2021 12:57:43 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR0P264CA0240.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::36) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by PR0P264CA0240.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Wed, 11 Aug 2021 11:57:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 620edf11-e9c1-460a-479c-08d95cbf3d81 X-MS-TrafficTypeDiagnostic: PH0PR11MB4808: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z7l1JNcEVpffnMl1btqW3LeSFidiBWscXo49sxAitKNfuT4H+ZaFqz3Mudop3peaDRRCQhj5jWOAbzs4lD2M/Ett8MTOb8nYS57WDF33QkZc0mgHuvqRlD6Ty55D6g6Yd4KJfuymYYnHANqs2Er2EHHuwcQf4hFQy/9UcdycVC9wroi4r9tRPbT4Ugo0yfDC+tF50SAkBRtbsw5wN8rUddjkdRD9WhZoWSEFXwngTWvUmNDTVgESbtWR8yzXn3/FgBm5ngYsW213QXC1P9cN9zi6PyBH6Ky2ynqLVwDGYfWbHmTfwCrPYD1aL34Cbt9BdrY2ShzpWRcXxf/MFRiiOZNps9bWUZWuFncU7Ei+1zL4wkBjYj1TZlyadOZ+IPV+soY7u4PJ9TfCMFHmfOEyHZmzgrJdh9fuslaGqTEbKI49Ea4636XfLgA4J9jfmV8aYmvGVRLXMMUqivKVvnEwIo/ujYfpcFXtTQrOnzSQduVVmRESRCOFiX1PnjhAY5dmZsiiaX0EqjCtfI1j2JpU/RphKA089PSPE+3K+Hy1xhu5kmF6ehg6IYwhHaOZFkjARsHVT5glh3oPSuYKisI+Dvnvjf7Ju5kHU0pwTXPTPTM5R7bRlQ8nFKvPHyd2I2IIHw0gvIHJoZhqwmP2+5+JTGvleLg4kL9X9uVt+e7vhkzc1dDxQI1EnN7DNJ/asu28K6nud7b4Rai+z5NocUeocQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(5660300002)(83380400001)(66556008)(66946007)(66476007)(36756003)(86362001)(31696002)(2906002)(956004)(2616005)(4326008)(44832011)(8676002)(54906003)(6486002)(6666004)(316002)(110136005)(16576012)(31686004)(38100700002)(478600001)(53546011)(186003)(8936002)(26005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjZHd3k4ZkFYYjVnVjlyMTQ4dWdjMHN5bVFvKy9tOTRDM3FFaVFqUTVNZXlj?= =?utf-8?B?WVdISUU2b0E3ekVrNDNKYzFualZDWE1Bbk1MNTIya1JFV3pwQXk4NXlHdG5i?= =?utf-8?B?SFZwTTdBREhTeS9HL0psMk9idGExK1pydlRPMWNXaytZMitJMHByMDlqeEZ5?= =?utf-8?B?MWRWb3hDZWY5RWdzWUZ2elpMVERKVlF2UDg5cEpIaGtMT2p5RjN4aWlrdFNY?= =?utf-8?B?d2lLNTR6a201NG52SU5rSytIMklxcmZ3Z0Q5UmFBbUtpWEVlb3ZTb0ZHL21G?= =?utf-8?B?WkZFZXlWZVN4a0JsaldoNkJHTE9pL01KV2NuU3VpbTdMNUt1dzlnNHY3ako1?= =?utf-8?B?ZzJ2MEw4dmFXSGp0RHZVUDk0TURZVVd1MTVnZWFoSzNidVlDZXNuTUltNUpk?= =?utf-8?B?VXp6aXZ3M3QyeWcxWC9MVDNBcjRlVFZsMGxzcWQzb3NSZjQ3TThPTDhvdDVR?= =?utf-8?B?Ujg2ZGJLQkVRWFo5T3NnMWpQVUdzaDhCV2hlbU5qZkNjcEdEVGt5N1dLWEd3?= =?utf-8?B?bjc3ekxISHUvR1VZbDZHSGJGeE04cnlmYU5pUkNmeDM1eE5jVVQvNXpRTHUr?= =?utf-8?B?UU1QMkFpbVMyaGFrNkdKY1R0bTIxSFYzT2pFVHhlSTNsaFBjcERGQ3hDTExs?= =?utf-8?B?R0VPRUVCVVRUQkkrZExlVVJwSit0TFVZN1hNWm9jTEdJZ2ZwQ3hqdkk2dlRl?= =?utf-8?B?NG9tRzlncmkreWcwOHlyT3Myd3Q5bldDWnZCaUhNZGxVZmxnSHdvSnkrR3pp?= =?utf-8?B?L3dSbytKN0RnbjNwUUVuSDdwYVFoTEVVYTlVV1hucTI2UHpWZ2pXVVhydTNs?= =?utf-8?B?RkVjNVhwSkhFUkxiVm9zVmhjY2F1UFErYmNhYWcxTTdxcGIrTzhCR0ZaS296?= =?utf-8?B?dFhKTEN3RmhlT3o3NExEQXJlNjgwZU93SDZnZlB6b0RlS1BUQko0MU9iUjFP?= =?utf-8?B?d3Fwb2l5YUdqb1oyOVBhQ3BVZG9uL0ZuK2ppZW9BVFNpN08rNGFqZUFCM2p2?= =?utf-8?B?S3IzT3JzLzJIM0Y3OFNrelFtVWk5bzFpWGdvOGdDR0h3VWF5QXEwK1BxNVJ4?= =?utf-8?B?SzhlSE15NVAySnNONGhYdW5oQkJpMTNDL2xhY3EwdDJNYmt1SU91cnFlbEpN?= =?utf-8?B?eFFWTFZxNWI1N001K0czeEdDL2c2aDkxc3FxOWJDaDAvaGRCOG1Lamo3UzJp?= =?utf-8?B?ZVFwMG9DL3pjcCtqVzRHSU1wS3RrcUYxdkRUOGNZclZSMkFSQVZpNVZ0OWVq?= =?utf-8?B?WEpURkhQTTZSKzFZaUM2QUZHRkY4dFRhUGhMMldrUmxnQUdVZ21ERjVVY05U?= =?utf-8?B?RDVZZVMzSlowSHFNcnhGMmErRE5YS3NzNlhvL083QkFRenRVcHlsTEJUTllr?= =?utf-8?B?M3FvRHVhOERXVEtzS205Vkp5eDVCSTBPSDVaVlo2ZUJTa3lqSFpsSkFWRG5F?= =?utf-8?B?U3hVZGtDeVdkenVmWDBxditNcjRNa3VzZWdsNnZZT3d6OWZxVnhXUlpId3RG?= =?utf-8?B?dUtsRmNaa3pTbHErcUxydWc3MDR4bE50bkw0RGpxZm5PQVk5QzZlMHYwU1VE?= =?utf-8?B?TTVFeVIrblpEaXNqL1pteHRGMFN1N3NNTitZZEcyMzBrUkhwQzMyWk5rTDlz?= =?utf-8?B?a2dEMjlyRlI5TUF3TEpFN25lQzYxNkZTQmh1ODh4SGM0ZU5kNFZJRndLaUYw?= =?utf-8?B?WlJiMWl0eTNtblhqd0pGaDVtNG9rRWdrT09PaEhxQ2VHMFMzWnIwMGk4WWUw?= =?utf-8?Q?AQ5dyav55f6z5avMlY14VJxQQf3bqMcByAz5D1p?= X-MS-Exchange-CrossTenant-Network-Message-Id: 620edf11-e9c1-460a-479c-08d95cbf3d81 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2021 11:57:49.1650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zYQ68Dez1mgaNDRfZeTUueUXERNJNTB/qloQpI5lU7FzjlwbRs1Votod9ztOlxva8WsSE73MvmW9BZj4nKz7jA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4808 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/10/2021 10:07 AM, Xueming(Steven) Li wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, August 10, 2021 4:54 PM >> To: Xueming(Steven) Li ; Singh, Aman Deep ; Andrew Rybchenko >> >> Cc: dev@dpdk.org; Slava Ovsiienko ; NBU-Contact-Thomas Monjalon >> Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback >> >> On 8/10/2021 9:03 AM, Xueming(Steven) Li wrote: >>> Hi Singh and Ferruh, >>> >>>> -----Original Message----- >>>> From: Ferruh Yigit >>>> Sent: Monday, August 9, 2021 11:31 PM >>>> To: Singh, Aman Deep ; Andrew Rybchenko >>>> ; Xueming(Steven) Li >>>> >>>> Cc: dev@dpdk.org; Slava Ovsiienko ; >>>> NBU-Contact-Thomas Monjalon >>>> Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback >>>> >>>> On 8/9/2021 3:39 PM, Singh, Aman Deep wrote: >>>>> Hi Xueming, >>>>> >>>>> On 7/28/2021 1:10 PM, Andrew Rybchenko wrote: >>>>>> On 7/27/21 6:41 AM, Xueming Li wrote: >>>>>>> To align with other eth device queue configuration callbacks, >>>>>>> change RX and TX queue release callback API parameter from queue >>>>>>> object to device and queue index. >>>>>>> >>>>>>> Signed-off-by: Xueming Li >>>>>> >>>>>> In fact, there is no strong reasons to do it, but I think it is a >>>>>> nice cleanup to use (dev + queue index) on control path. >>>>>> >>>>>> Hopefully it will not result in any regressions. >>>>> >>>>> Combined there are 100+ API's for Rx/Tx queue_release that need to >>>>> be modified for it. >>>>> >>>>> I believe all regression possibilities here will be caught, in >>>>> compilation phase itself. >>>>> >>>> >>>> Same here, it is a good cleanup but there is no strong reason for it. >>>> >>>> Since it is all internal, there is no ABI restriction on the patch, >>>> and v21.11 will be full ABI break patches, to not cause conflicts with this change, what would you think to have it on v22.02? >>> >>> This patch is required by shared-rxq feature which ABI broken, target to 21.11. >> >> Why it is required? > > In rx burst function, rxq object is used in data path. For best data performance, it's shared-rxq object in case of shared rxq enabled. > I think eth api defined rxq object for performance as well, specific on data plane. > Hardware saves port info received packet descriptor for my case. > Can't tell which device's queue with this shared rxq object, control path can't use this shared rxq anymore, have to be specific on dev and queue id. > I have seen shared Rx queue patch, but that just introduces the offload and doesn't have the PMD implementation, so hard to see the dependency, can you please put the pseudocode for PMDs for shared-rxq? How a queue will know if it is shared or not, during release? Btw, shared Rx doesn't mention from this dependency in the patch. >> >>> I'll do it carefully, fortunately, the change is straightforward. >>> >