From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33CE1C433E6 for ; Tue, 1 Sep 2020 04:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0163D2083B for ; Tue, 1 Sep 2020 04:32:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="O6oqnZOl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726144AbgIAEc4 (ORCPT ); Tue, 1 Sep 2020 00:32:56 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:62517 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbgIAEcx (ORCPT ); Tue, 1 Sep 2020 00:32:53 -0400 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20200901043249epoutp01f8ca59c57b4c33778574d601aa76a0e2~wjrOE0_Me2654426544epoutp01R for ; Tue, 1 Sep 2020 04:32:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20200901043249epoutp01f8ca59c57b4c33778574d601aa76a0e2~wjrOE0_Me2654426544epoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1598934769; bh=WWEnX/WU8nabFgB1ALb/K0Y8k8pzzwAuMe9CZeMsv4Y=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=O6oqnZOlGhlywQ8vbSkDsV5LVyubs1IpP0GesWNXxMRPuIZB42DMhx1VJfVNCUBxY qeQxetxKc+cJj3BLGPDoHaE4qLXiBm0ev+C0xloj9FypIJXGdq9eicJbDuFsDELVyT UeRxom8dtov8VaGcVRy+GQMSjt8Nz74pSwpv11es= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20200901043248epcas1p172dee8c8d4b5010df850acd841a745c4~wjrNn-T2w3152731527epcas1p1K; Tue, 1 Sep 2020 04:32:48 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.40.158]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4BgZ1T1x15zMqYkw; Tue, 1 Sep 2020 04:32:45 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id D0.D6.28578.7EECD4F5; Tue, 1 Sep 2020 13:32:39 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20200901043239epcas1p45492888686a41403019bf6487705af31~wjrEfQsgh2108421084epcas1p4P; Tue, 1 Sep 2020 04:32:39 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200901043239epsmtrp20f77135dd77d51a3e5ef8e3f95359e31~wjrEebijR3147731477epsmtrp2c; Tue, 1 Sep 2020 04:32:39 +0000 (GMT) X-AuditID: b6c32a39-8c9ff70000006fa2-5b-5f4dcee79ffe Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 49.D5.08382.6EECD4F5; Tue, 1 Sep 2020 13:32:38 +0900 (KST) Received: from [10.113.221.102] (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200901043238epsmtip24209c50ae0545e0895c388cf852a620f~wjrEKDz952786627866epsmtip2P; Tue, 1 Sep 2020 04:32:38 +0000 (GMT) Subject: Re: [PATCH v4 75/78] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings To: Maxime Ripard , Nicolas Saenz Julienne , Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tim Gover , Phil Elwell , Rob Herring From: Chanwoo Choi Organization: Samsung Electronics Message-ID: <94c5b8e4-a168-690d-2d60-93462585bef9@samsung.com> Date: Tue, 1 Sep 2020 13:45:07 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCJsWRmVeSWpSXmKPExsWy7bCmge7zc77xBhveKVqs7T3KYvF27mIW iytf37NZHGi8zGix6fE1VovLu+awWUy8vYHdYsaPf4wW22YtZ7NYd+s1m8X/PTvYLR5Nvc/o wOPR9P4Ym8es+2fZPO6cO8/msWlVJ5vH/e7jTB6bl9R7tB79xeKx+XS1x+dNcgGcUdk2GamJ KalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUAXKymUJeaUAoUC EouLlfTtbIryS0tSFTLyi0tslVILUnIKLAv0ihNzi0vz0vWS83OtDA0MjEyBChOyM45dOslS 0KRS8WtpL1sD42vJLkZODgkBE4lfc54ydzFycQgJ7GCUmHL4JBuE84lRYsOD+1CZb4wSZ8+1 sMC0tC/byQiR2Mso8f7pRKiW94wSy+89YQapEhZIkzj16ycriC0iUC7R3rkfbBSzwHUmiebZ XxlBEmwCWhL7X9xgA7H5BRQlrv54DBbnFbCTWHX3LVicRUBF4tDdM2BxUYEwiZPbWqBqBCVO znwCdBIHB6dAvMSGpdUgYWYBcYlbT+YzQdjyEtvfzgHbKyFwh0Ni0c3HzBAvuEhsmruMEcIW lnh1fAs7hC0l8fndXjYIu1pi5ckjbBDNHYwSW/ZfYIVIGEvsXzqZCWQxs4CmxPpd+hBhRYmd v+cyQizmk3j3tYcVpERCgFeio00IokRZ4vKDu0wQtqTE4vZOtgmMSrOQfDMLyQuzkLwwC2HZ AkaWVYxiqQXFuempxYYFpsjRvYkRnJy1LHcwTn/7Qe8QIxMH4yFGCQ5mJRHeA7u844V4UxIr q1KL8uOLSnNSiw8xmgLDdyKzlGhyPjA/5JXEG5oaGRsbW5gYmpkaGiqJ8z68pRAvJJCeWJKa nZpakFoE08fEwSnVwGQbe23Wr/KGJSF7eezncDEvCqy4wR2eYn9t93SWv0vKHDx2Vn3LtfwS frzhm1TTEzm9C1v1p5dOWc8gX7XFZn5ZwteZP9tf6ezJiCxSP62455jZ7B9Bvhc880+EXH+/ v3iVVYJSEePni0XX174/4PtayZBn/a7rVkbcbJOKApR+6eWULTrneJnjW7B90+d/s6Z/DCs8 f8XzcYyw3uflH1KKKlpWHFrI9a5A9JKh3Ry/lQ8apq6NaHXc5K/ebOPEvLqup4q9oD3h43em ff3Rfc53v93x/LUpInnGm/MnrPtm6PZOlq7p0TBvf5ZwVPuyzj/hRlbNZ8sVD4jov+41XJO/ 60GgMcsM61vef1udLJVYijMSDbWYi4oTAawaIHhXBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsWy7bCSvO6zc77xBv1PLC3W9h5lsXg7dzGL xZWv79ksDjReZrTY9Pgaq8XlXXPYLCbe3sBuMePHP0aLbbOWs1msu/WazeL/nh3sFo+m3md0 4PFoen+MzWPW/bNsHnfOnWfz2LSqk83jfvdxJo/NS+o9Wo/+YvHYfLra4/MmuQDOKC6blNSc zLLUIn27BK6MY5dOshQ0qVT8WtrL1sD4WrKLkZNDQsBEon3ZTsYuRi4OIYHdjBI3/u5mg0hI Sky7eJS5i5EDyBaWOHy4GCQsJPCWUWLmGnkQW1ggTeLUr5+sILaIQKXE5zm7mEFsZoHrTBIz ttVBzOxlkji7eStYgk1AS2L/ixtg8/kFFCWu/njMCGLzCthJrLr7FizOIqAicejuGbC4qECY xM4lj5kgagQlTs58wgJyD6dAvMSGpdUQu9Ql/sy7BLVXXOLWk/lMELa8xPa3c5gnMArPQtI9 C0nLLCQts5C0LGBkWcUomVpQnJueW2xYYJiXWq5XnJhbXJqXrpecn7uJERyhWpo7GLev+qB3 iJGJg/EQowQHs5II74Fd3vFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeW8ULowTEkhPLEnNTk0t SC2CyTJxcEo1MJXM6f5qIbT9/0FTV7GTN1+/XnegzvzDpv97L7rNTv0efULY9J4K75aTUbrH 3hp0c/MFrLmxPunZ9a2qKZdO2YVMWsKh5Mn6LKGiOEPgXUGLZsizlnMFugpzjqTv0fduiL/g zZYxY5kQx9+wX+vvXH3+87uekuC974mOEsyb5szaaCm3+9H7yjNOa293hal5/DqnLriCOy3b nOeN/aywdwUrVxo+yJ55pOikfZbulfnpFw8dv3bFZsFbJebPU/jT7a/KbPV5f2kPe/3hX5aS Zicuv51W78TEcPLkp7KLjNOlWP3ua9QHZsYX/Nvo4STJfX+LWMUe3e/7ubY/ctD7aCLE+vS9 n3n6kzPPT7xb23tLiaU4I9FQi7moOBEA+/SlDD8DAAA= X-CMS-MailID: 20200901043239epcas1p45492888686a41403019bf6487705af31 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200708174447epcas1p3c9582567617196b61495ee281b443b91 References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On 7/9/20 2:42 AM, Maxime Ripard wrote: > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > bindings, especially since the registers have been shuffled around in more > register ranges. > > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > new file mode 100644 > index 000000000000..6091fe3d315b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: https://protect2.fireeye.com/url?k=556aeb05-08b8fda0-556b604a-0cc47a31bee8-c3a0ebd1d22c3183&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fbrcm%2Cbcm2711-hdmi.yaml%23 > +$schema: https://protect2.fireeye.com/url?k=24fa660c-792870a9-24fbed43-0cc47a31bee8-0bf16f4fd60f0ab4&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > + > +title: Broadcom BCM2711 HDMI Controller Device Tree Bindings > + > +maintainers: > + - Eric Anholt > + > +properties: > + compatible: > + enum: > + - brcm,bcm2711-hdmi0 > + - brcm,bcm2711-hdmi1 > + > + reg: > + items: > + - description: HDMI controller register range > + - description: DVP register range > + - description: HDMI PHY register range > + - description: Rate Manager register range > + - description: Packet RAM register range > + - description: Metadata RAM register range > + - description: CSC register range > + - description: CEC register range > + - description: HD register range > + > + reg-names: > + items: > + - const: hdmi > + - const: dvp > + - const: phy > + - const: rm > + - const: packet > + - const: metadata > + - const: csc > + - const: cec > + - const: hd > + > + clocks: > + description: The HDMI state machine clock I'm not sure the following description is correct. But, this description doesn't contain the information of audio clock. description: The HDMI state machine and audio clock > + > + clock-names: > + const: hdmi This patch is missing the following clock information for audio clock. const: clk-108M > + > + ddc: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/phandle > + description: > > + Phandle of the I2C controller used for DDC EDID probing > + > + hpd-gpios: > + description: > > + The GPIO pin for the HDMI hotplug detect (if it doesn't appear > + as an interrupt/status bit in the HDMI controller itself) > + > + dmas: > + maxItems: 1 > + description: > > + Should contain one entry pointing to the DMA channel used to > + transfer audio data. > + > + dma-names: > + const: audio-rx > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - resets > + - ddc > + > +additionalProperties: false > + > +examples: > + - | > + hdmi0: hdmi@7ef00700 { > + compatible = "brcm,bcm2711-hdmi0"; > + reg = <0x7ef00700 0x300>, > + <0x7ef00300 0x200>, > + <0x7ef00f00 0x80>, > + <0x7ef00f80 0x80>, > + <0x7ef01b00 0x200>, > + <0x7ef01f00 0x400>, > + <0x7ef00200 0x80>, > + <0x7ef04300 0x100>, > + <0x7ef20000 0x100>; > + reg-names = "hdmi", > + "dvp", > + "phy", > + "rm", > + "packet", > + "metadata", > + "csc", > + "cec", > + "hd"; > + clocks = <&firmware_clocks 13>; > + clock-names = "hdmi"; Also, this example doesn't include the instance of audio clock. Need to edit them as following: clock-names = "hdmi", "clk-108M"; clocks = <&firmware_clocks 13>, <&dvp 0>; > + resets = <&dvp 0>; > + ddc = <&ddc0>; > + }; > + > +... > -- Best Regards, Chanwoo Choi Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32CE3C433E2 for ; Tue, 1 Sep 2020 04:34:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E47E62083B for ; Tue, 1 Sep 2020 04:34:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2uzgSbXF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="O6oqnZOl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E47E62083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:MIME-Version:Date:Message-ID: From:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pBzZoObLYk1MAiaUSS9pcpH0ZpxtDx9rnqwrbvAzzow=; b=2uzgSbXFmSu++xyPzbQ86FfPY hErTmm+QWKS90tXoJong6A10FgrPcuQmJrJ19iT/CKcb5wG2+PWMP1ZnCK2WSGe/Ih11RpekcQbhW /3wTlgDKRB6Tp/LmMr/bXUJaBBUjRJ3ckA2RLXbuL9vsaOqNhWAIT+H9qUodU5VZxOYYTUB3lthXG DuU3zA0ONPKs0jk1TEyxF58yFuNSgTkMwAWYMoHTbxEE4d6i7z+r3/loLDquTJh42fWqttz//xgd5 tn41Q+bhTFysRf7hNnWkCLuHHcdO7B1UfbEooupDxemgLRJ3jw0HIrpvB+s73EYGmyLHUHuQ/Dlk8 TmQ5Y92Mg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCxyb-0000dC-5s; Tue, 01 Sep 2020 04:32:57 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCxyW-0000cA-Ph for linux-arm-kernel@lists.infradead.org; Tue, 01 Sep 2020 04:32:54 +0000 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20200901043249epoutp03911c49703b7511ca94d4e5bb78f4ee35~wjrOEkZsV2697426974epoutp03f for ; Tue, 1 Sep 2020 04:32:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20200901043249epoutp03911c49703b7511ca94d4e5bb78f4ee35~wjrOEkZsV2697426974epoutp03f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1598934769; bh=WWEnX/WU8nabFgB1ALb/K0Y8k8pzzwAuMe9CZeMsv4Y=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=O6oqnZOlGhlywQ8vbSkDsV5LVyubs1IpP0GesWNXxMRPuIZB42DMhx1VJfVNCUBxY qeQxetxKc+cJj3BLGPDoHaE4qLXiBm0ev+C0xloj9FypIJXGdq9eicJbDuFsDELVyT UeRxom8dtov8VaGcVRy+GQMSjt8Nz74pSwpv11es= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20200901043248epcas1p172dee8c8d4b5010df850acd841a745c4~wjrNn-T2w3152731527epcas1p1K; Tue, 1 Sep 2020 04:32:48 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.40.158]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4BgZ1T1x15zMqYkw; Tue, 1 Sep 2020 04:32:45 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id D0.D6.28578.7EECD4F5; Tue, 1 Sep 2020 13:32:39 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20200901043239epcas1p45492888686a41403019bf6487705af31~wjrEfQsgh2108421084epcas1p4P; Tue, 1 Sep 2020 04:32:39 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200901043239epsmtrp20f77135dd77d51a3e5ef8e3f95359e31~wjrEebijR3147731477epsmtrp2c; Tue, 1 Sep 2020 04:32:39 +0000 (GMT) X-AuditID: b6c32a39-8c9ff70000006fa2-5b-5f4dcee79ffe Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 49.D5.08382.6EECD4F5; Tue, 1 Sep 2020 13:32:38 +0900 (KST) Received: from [10.113.221.102] (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200901043238epsmtip24209c50ae0545e0895c388cf852a620f~wjrEKDz952786627866epsmtip2P; Tue, 1 Sep 2020 04:32:38 +0000 (GMT) Subject: Re: [PATCH v4 75/78] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings To: Maxime Ripard , Nicolas Saenz Julienne , Eric Anholt From: Chanwoo Choi Organization: Samsung Electronics Message-ID: <94c5b8e4-a168-690d-2d60-93462585bef9@samsung.com> Date: Tue, 1 Sep 2020 13:45:07 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCJsWRmVeSWpSXmKPExsWy7bCmge7zc77xBhveKVqs7T3KYvF27mIW iytf37NZHGi8zGix6fE1VovLu+awWUy8vYHdYsaPf4wW22YtZ7NYd+s1m8X/PTvYLR5Nvc/o wOPR9P4Ym8es+2fZPO6cO8/msWlVJ5vH/e7jTB6bl9R7tB79xeKx+XS1x+dNcgGcUdk2GamJ KalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUAXKymUJeaUAoUC EouLlfTtbIryS0tSFTLyi0tslVILUnIKLAv0ihNzi0vz0vWS83OtDA0MjEyBChOyM45dOslS 0KRS8WtpL1sD42vJLkZODgkBE4lfc54ydzFycQgJ7GCUmHL4JBuE84lRYsOD+1CZb4wSZ8+1 sMC0tC/byQiR2Mso8f7pRKiW94wSy+89YQapEhZIkzj16ycriC0iUC7R3rkfbBSzwHUmiebZ XxlBEmwCWhL7X9xgA7H5BRQlrv54DBbnFbCTWHX3LVicRUBF4tDdM2BxUYEwiZPbWqBqBCVO znwCdBIHB6dAvMSGpdUgYWYBcYlbT+YzQdjyEtvfzgHbKyFwh0Ni0c3HzBAvuEhsmruMEcIW lnh1fAs7hC0l8fndXjYIu1pi5ckjbBDNHYwSW/ZfYIVIGEvsXzqZCWQxs4CmxPpd+hBhRYmd v+cyQizmk3j3tYcVpERCgFeio00IokRZ4vKDu0wQtqTE4vZOtgmMSrOQfDMLyQuzkLwwC2HZ AkaWVYxiqQXFuempxYYFpsjRvYkRnJy1LHcwTn/7Qe8QIxMH4yFGCQ5mJRHeA7u844V4UxIr q1KL8uOLSnNSiw8xmgLDdyKzlGhyPjA/5JXEG5oaGRsbW5gYmpkaGiqJ8z68pRAvJJCeWJKa nZpakFoE08fEwSnVwGQbe23Wr/KGJSF7eezncDEvCqy4wR2eYn9t93SWv0vKHDx2Vn3LtfwS frzhm1TTEzm9C1v1p5dOWc8gX7XFZn5ZwteZP9tf6ezJiCxSP62455jZ7B9Bvhc880+EXH+/ v3iVVYJSEePni0XX174/4PtayZBn/a7rVkbcbJOKApR+6eWULTrneJnjW7B90+d/s6Z/DCs8 f8XzcYyw3uflH1KKKlpWHFrI9a5A9JKh3Ry/lQ8apq6NaHXc5K/ebOPEvLqup4q9oD3h43em ff3Rfc53v93x/LUpInnGm/MnrPtm6PZOlq7p0TBvf5ZwVPuyzj/hRlbNZ8sVD4jov+41XJO/ 60GgMcsM61vef1udLJVYijMSDbWYi4oTAawaIHhXBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsWy7bCSvO6zc77xBv1PLC3W9h5lsXg7dzGL xZWv79ksDjReZrTY9Pgaq8XlXXPYLCbe3sBuMePHP0aLbbOWs1msu/WazeL/nh3sFo+m3md0 4PFoen+MzWPW/bNsHnfOnWfz2LSqk83jfvdxJo/NS+o9Wo/+YvHYfLra4/MmuQDOKC6blNSc zLLUIn27BK6MY5dOshQ0qVT8WtrL1sD4WrKLkZNDQsBEon3ZTsYuRi4OIYHdjBI3/u5mg0hI Sky7eJS5i5EDyBaWOHy4GCQsJPCWUWLmGnkQW1ggTeLUr5+sILaIQKXE5zm7mEFsZoHrTBIz ttVBzOxlkji7eStYgk1AS2L/ixtg8/kFFCWu/njMCGLzCthJrLr7FizOIqAicejuGbC4qECY xM4lj5kgagQlTs58wgJyD6dAvMSGpdUQu9Ql/sy7BLVXXOLWk/lMELa8xPa3c5gnMArPQtI9 C0nLLCQts5C0LGBkWcUomVpQnJueW2xYYJiXWq5XnJhbXJqXrpecn7uJERyhWpo7GLev+qB3 iJGJg/EQowQHs5II74Fd3vFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeW8ULowTEkhPLEnNTk0t SC2CyTJxcEo1MJXM6f5qIbT9/0FTV7GTN1+/XnegzvzDpv97L7rNTv0efULY9J4K75aTUbrH 3hp0c/MFrLmxPunZ9a2qKZdO2YVMWsKh5Mn6LKGiOEPgXUGLZsizlnMFugpzjqTv0fduiL/g zZYxY5kQx9+wX+vvXH3+87uekuC974mOEsyb5szaaCm3+9H7yjNOa293hal5/DqnLriCOy3b nOeN/aywdwUrVxo+yJ55pOikfZbulfnpFw8dv3bFZsFbJebPU/jT7a/KbPV5f2kPe/3hX5aS Zicuv51W78TEcPLkp7KLjNOlWP3ua9QHZsYX/Nvo4STJfX+LWMUe3e/7ubY/ctD7aCLE+vS9 n3n6kzPPT7xb23tLiaU4I9FQi7moOBEA+/SlDD8DAAA= X-CMS-MailID: 20200901043239epcas1p45492888686a41403019bf6487705af31 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200708174447epcas1p3c9582567617196b61495ee281b443b91 References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_003253_204954_0BB59E90 X-CRM114-Status: GOOD ( 26.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On 7/9/20 2:42 AM, Maxime Ripard wrote: > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > bindings, especially since the registers have been shuffled around in more > register ranges. > > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > new file mode 100644 > index 000000000000..6091fe3d315b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: https://protect2.fireeye.com/url?k=556aeb05-08b8fda0-556b604a-0cc47a31bee8-c3a0ebd1d22c3183&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fbrcm%2Cbcm2711-hdmi.yaml%23 > +$schema: https://protect2.fireeye.com/url?k=24fa660c-792870a9-24fbed43-0cc47a31bee8-0bf16f4fd60f0ab4&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > + > +title: Broadcom BCM2711 HDMI Controller Device Tree Bindings > + > +maintainers: > + - Eric Anholt > + > +properties: > + compatible: > + enum: > + - brcm,bcm2711-hdmi0 > + - brcm,bcm2711-hdmi1 > + > + reg: > + items: > + - description: HDMI controller register range > + - description: DVP register range > + - description: HDMI PHY register range > + - description: Rate Manager register range > + - description: Packet RAM register range > + - description: Metadata RAM register range > + - description: CSC register range > + - description: CEC register range > + - description: HD register range > + > + reg-names: > + items: > + - const: hdmi > + - const: dvp > + - const: phy > + - const: rm > + - const: packet > + - const: metadata > + - const: csc > + - const: cec > + - const: hd > + > + clocks: > + description: The HDMI state machine clock I'm not sure the following description is correct. But, this description doesn't contain the information of audio clock. description: The HDMI state machine and audio clock > + > + clock-names: > + const: hdmi This patch is missing the following clock information for audio clock. const: clk-108M > + > + ddc: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/phandle > + description: > > + Phandle of the I2C controller used for DDC EDID probing > + > + hpd-gpios: > + description: > > + The GPIO pin for the HDMI hotplug detect (if it doesn't appear > + as an interrupt/status bit in the HDMI controller itself) > + > + dmas: > + maxItems: 1 > + description: > > + Should contain one entry pointing to the DMA channel used to > + transfer audio data. > + > + dma-names: > + const: audio-rx > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - resets > + - ddc > + > +additionalProperties: false > + > +examples: > + - | > + hdmi0: hdmi@7ef00700 { > + compatible = "brcm,bcm2711-hdmi0"; > + reg = <0x7ef00700 0x300>, > + <0x7ef00300 0x200>, > + <0x7ef00f00 0x80>, > + <0x7ef00f80 0x80>, > + <0x7ef01b00 0x200>, > + <0x7ef01f00 0x400>, > + <0x7ef00200 0x80>, > + <0x7ef04300 0x100>, > + <0x7ef20000 0x100>; > + reg-names = "hdmi", > + "dvp", > + "phy", > + "rm", > + "packet", > + "metadata", > + "csc", > + "cec", > + "hd"; > + clocks = <&firmware_clocks 13>; > + clock-names = "hdmi"; Also, this example doesn't include the instance of audio clock. Need to edit them as following: clock-names = "hdmi", "clk-108M"; clocks = <&firmware_clocks 13>, <&dvp 0>; > + resets = <&dvp 0>; > + ddc = <&ddc0>; > + }; > + > +... > -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966C2C433E7 for ; Tue, 1 Sep 2020 07:32:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E7E8206CD for ; Tue, 1 Sep 2020 07:32:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="O6oqnZOl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E7E8206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EB3C6E5C0; Tue, 1 Sep 2020 07:32:21 +0000 (UTC) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8990C6E598 for ; Tue, 1 Sep 2020 04:32:51 +0000 (UTC) Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20200901043249epoutp02d8565e717b35d3d882b4fad0b0279faf~wjrN6w-ej1125911259epoutp02d for ; Tue, 1 Sep 2020 04:32:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20200901043249epoutp02d8565e717b35d3d882b4fad0b0279faf~wjrN6w-ej1125911259epoutp02d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1598934769; bh=WWEnX/WU8nabFgB1ALb/K0Y8k8pzzwAuMe9CZeMsv4Y=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=O6oqnZOlGhlywQ8vbSkDsV5LVyubs1IpP0GesWNXxMRPuIZB42DMhx1VJfVNCUBxY qeQxetxKc+cJj3BLGPDoHaE4qLXiBm0ev+C0xloj9FypIJXGdq9eicJbDuFsDELVyT UeRxom8dtov8VaGcVRy+GQMSjt8Nz74pSwpv11es= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20200901043248epcas1p172dee8c8d4b5010df850acd841a745c4~wjrNn-T2w3152731527epcas1p1K; Tue, 1 Sep 2020 04:32:48 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.40.158]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4BgZ1T1x15zMqYkw; Tue, 1 Sep 2020 04:32:45 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id D0.D6.28578.7EECD4F5; Tue, 1 Sep 2020 13:32:39 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20200901043239epcas1p45492888686a41403019bf6487705af31~wjrEfQsgh2108421084epcas1p4P; Tue, 1 Sep 2020 04:32:39 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200901043239epsmtrp20f77135dd77d51a3e5ef8e3f95359e31~wjrEebijR3147731477epsmtrp2c; Tue, 1 Sep 2020 04:32:39 +0000 (GMT) X-AuditID: b6c32a39-8c9ff70000006fa2-5b-5f4dcee79ffe Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 49.D5.08382.6EECD4F5; Tue, 1 Sep 2020 13:32:38 +0900 (KST) Received: from [10.113.221.102] (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200901043238epsmtip24209c50ae0545e0895c388cf852a620f~wjrEKDz952786627866epsmtip2P; Tue, 1 Sep 2020 04:32:38 +0000 (GMT) Subject: Re: [PATCH v4 75/78] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings To: Maxime Ripard , Nicolas Saenz Julienne , Eric Anholt From: Chanwoo Choi Organization: Samsung Electronics Message-ID: <94c5b8e4-a168-690d-2d60-93462585bef9@samsung.com> Date: Tue, 1 Sep 2020 13:45:07 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCJsWRmVeSWpSXmKPExsWy7bCmge7zc77xBhveKVqs7T3KYvF27mIW iytf37NZHGi8zGix6fE1VovLu+awWUy8vYHdYsaPf4wW22YtZ7NYd+s1m8X/PTvYLR5Nvc/o wOPR9P4Ym8es+2fZPO6cO8/msWlVJ5vH/e7jTB6bl9R7tB79xeKx+XS1x+dNcgGcUdk2GamJ KalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUAXKymUJeaUAoUC EouLlfTtbIryS0tSFTLyi0tslVILUnIKLAv0ihNzi0vz0vWS83OtDA0MjEyBChOyM45dOslS 0KRS8WtpL1sD42vJLkZODgkBE4lfc54ydzFycQgJ7GCUmHL4JBuE84lRYsOD+1CZb4wSZ8+1 sMC0tC/byQiR2Mso8f7pRKiW94wSy+89YQapEhZIkzj16ycriC0iUC7R3rkfbBSzwHUmiebZ XxlBEmwCWhL7X9xgA7H5BRQlrv54DBbnFbCTWHX3LVicRUBF4tDdM2BxUYEwiZPbWqBqBCVO znwCdBIHB6dAvMSGpdUgYWYBcYlbT+YzQdjyEtvfzgHbKyFwh0Ni0c3HzBAvuEhsmruMEcIW lnh1fAs7hC0l8fndXjYIu1pi5ckjbBDNHYwSW/ZfYIVIGEvsXzqZCWQxs4CmxPpd+hBhRYmd v+cyQizmk3j3tYcVpERCgFeio00IokRZ4vKDu0wQtqTE4vZOtgmMSrOQfDMLyQuzkLwwC2HZ AkaWVYxiqQXFuempxYYFpsjRvYkRnJy1LHcwTn/7Qe8QIxMH4yFGCQ5mJRHeA7u844V4UxIr q1KL8uOLSnNSiw8xmgLDdyKzlGhyPjA/5JXEG5oaGRsbW5gYmpkaGiqJ8z68pRAvJJCeWJKa nZpakFoE08fEwSnVwGQbe23Wr/KGJSF7eezncDEvCqy4wR2eYn9t93SWv0vKHDx2Vn3LtfwS frzhm1TTEzm9C1v1p5dOWc8gX7XFZn5ZwteZP9tf6ezJiCxSP62455jZ7B9Bvhc880+EXH+/ v3iVVYJSEePni0XX174/4PtayZBn/a7rVkbcbJOKApR+6eWULTrneJnjW7B90+d/s6Z/DCs8 f8XzcYyw3uflH1KKKlpWHFrI9a5A9JKh3Ry/lQ8apq6NaHXc5K/ebOPEvLqup4q9oD3h43em ff3Rfc53v93x/LUpInnGm/MnrPtm6PZOlq7p0TBvf5ZwVPuyzj/hRlbNZ8sVD4jov+41XJO/ 60GgMcsM61vef1udLJVYijMSDbWYi4oTAawaIHhXBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsWy7bCSvO6zc77xBv1PLC3W9h5lsXg7dzGL xZWv79ksDjReZrTY9Pgaq8XlXXPYLCbe3sBuMePHP0aLbbOWs1msu/WazeL/nh3sFo+m3md0 4PFoen+MzWPW/bNsHnfOnWfz2LSqk83jfvdxJo/NS+o9Wo/+YvHYfLra4/MmuQDOKC6blNSc zLLUIn27BK6MY5dOshQ0qVT8WtrL1sD4WrKLkZNDQsBEon3ZTsYuRi4OIYHdjBI3/u5mg0hI Sky7eJS5i5EDyBaWOHy4GCQsJPCWUWLmGnkQW1ggTeLUr5+sILaIQKXE5zm7mEFsZoHrTBIz ttVBzOxlkji7eStYgk1AS2L/ixtg8/kFFCWu/njMCGLzCthJrLr7FizOIqAicejuGbC4qECY xM4lj5kgagQlTs58wgJyD6dAvMSGpdUQu9Ql/sy7BLVXXOLWk/lMELa8xPa3c5gnMArPQtI9 C0nLLCQts5C0LGBkWcUomVpQnJueW2xYYJiXWq5XnJhbXJqXrpecn7uJERyhWpo7GLev+qB3 iJGJg/EQowQHs5II74Fd3vFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeW8ULowTEkhPLEnNTk0t SC2CyTJxcEo1MJXM6f5qIbT9/0FTV7GTN1+/XnegzvzDpv97L7rNTv0efULY9J4K75aTUbrH 3hp0c/MFrLmxPunZ9a2qKZdO2YVMWsKh5Mn6LKGiOEPgXUGLZsizlnMFugpzjqTv0fduiL/g zZYxY5kQx9+wX+vvXH3+87uekuC974mOEsyb5szaaCm3+9H7yjNOa293hal5/DqnLriCOy3b nOeN/aywdwUrVxo+yJ55pOikfZbulfnpFw8dv3bFZsFbJebPU/jT7a/KbPV5f2kPe/3hX5aS Zicuv51W78TEcPLkp7KLjNOlWP3ua9QHZsYX/Nvo4STJfX+LWMUe3e/7ubY/ctD7aCLE+vS9 n3n6kzPPT7xb23tLiaU4I9FQi7moOBEA+/SlDD8DAAA= X-CMS-MailID: 20200901043239epcas1p45492888686a41403019bf6487705af31 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200708174447epcas1p3c9582567617196b61495ee281b443b91 References: X-Mailman-Approved-At: Tue, 01 Sep 2020 07:31:54 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, On 7/9/20 2:42 AM, Maxime Ripard wrote: > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > bindings, especially since the registers have been shuffled around in more > register ranges. > > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > new file mode 100644 > index 000000000000..6091fe3d315b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: https://protect2.fireeye.com/url?k=556aeb05-08b8fda0-556b604a-0cc47a31bee8-c3a0ebd1d22c3183&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fbrcm%2Cbcm2711-hdmi.yaml%23 > +$schema: https://protect2.fireeye.com/url?k=24fa660c-792870a9-24fbed43-0cc47a31bee8-0bf16f4fd60f0ab4&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > + > +title: Broadcom BCM2711 HDMI Controller Device Tree Bindings > + > +maintainers: > + - Eric Anholt > + > +properties: > + compatible: > + enum: > + - brcm,bcm2711-hdmi0 > + - brcm,bcm2711-hdmi1 > + > + reg: > + items: > + - description: HDMI controller register range > + - description: DVP register range > + - description: HDMI PHY register range > + - description: Rate Manager register range > + - description: Packet RAM register range > + - description: Metadata RAM register range > + - description: CSC register range > + - description: CEC register range > + - description: HD register range > + > + reg-names: > + items: > + - const: hdmi > + - const: dvp > + - const: phy > + - const: rm > + - const: packet > + - const: metadata > + - const: csc > + - const: cec > + - const: hd > + > + clocks: > + description: The HDMI state machine clock I'm not sure the following description is correct. But, this description doesn't contain the information of audio clock. description: The HDMI state machine and audio clock > + > + clock-names: > + const: hdmi This patch is missing the following clock information for audio clock. const: clk-108M > + > + ddc: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/phandle > + description: > > + Phandle of the I2C controller used for DDC EDID probing > + > + hpd-gpios: > + description: > > + The GPIO pin for the HDMI hotplug detect (if it doesn't appear > + as an interrupt/status bit in the HDMI controller itself) > + > + dmas: > + maxItems: 1 > + description: > > + Should contain one entry pointing to the DMA channel used to > + transfer audio data. > + > + dma-names: > + const: audio-rx > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - resets > + - ddc > + > +additionalProperties: false > + > +examples: > + - | > + hdmi0: hdmi@7ef00700 { > + compatible = "brcm,bcm2711-hdmi0"; > + reg = <0x7ef00700 0x300>, > + <0x7ef00300 0x200>, > + <0x7ef00f00 0x80>, > + <0x7ef00f80 0x80>, > + <0x7ef01b00 0x200>, > + <0x7ef01f00 0x400>, > + <0x7ef00200 0x80>, > + <0x7ef04300 0x100>, > + <0x7ef20000 0x100>; > + reg-names = "hdmi", > + "dvp", > + "phy", > + "rm", > + "packet", > + "metadata", > + "csc", > + "cec", > + "hd"; > + clocks = <&firmware_clocks 13>; > + clock-names = "hdmi"; Also, this example doesn't include the instance of audio clock. Need to edit them as following: clock-names = "hdmi", "clk-108M"; clocks = <&firmware_clocks 13>, <&dvp 0>; > + resets = <&dvp 0>; > + ddc = <&ddc0>; > + }; > + > +... > -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel