From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EBBC2BCA1 for ; Fri, 7 Jun 2019 16:24:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44D9120840 for ; Fri, 7 Jun 2019 16:24:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pDKEQrcR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44D9120840 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49352 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZHfH-0002RU-PF for qemu-devel@archiver.kernel.org; Fri, 07 Jun 2019 12:24:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39723) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZGC2-0002ME-Dq for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:50:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZGC1-0000iS-3k for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:50:10 -0400 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:44733) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZGC0-0000Kl-VB for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:50:09 -0400 Received: by mail-ot1-x343.google.com with SMTP id b7so2056643otl.11 for ; Fri, 07 Jun 2019 07:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oHzHXPzXYlWN69DqEELeV6l5D1ewq4CPbBpdr086xKQ=; b=pDKEQrcRtCeBpPN2En7vgEXeLf8WNQS6mBmsrD2/yoMT869VF5HXzLcYqypICrDKtP Vnqh//8/ejxh1iZ3ErH6vLHlmjlgaNfcmvmYd+sH/iF7Xog4NrTMeAvXdru5Ggnoi78J 7RFzmLfsOBDX46SzSAZXFmnPvwJPWOnkUIiIfgKWwtBs5rAlrburQ3hJ3DFGO2ou5zNN w4FdBdUr8wSRSGdkNbJYgbJBQUOX2KKidqt6WCrveP1huKmWdcZFXBiJFdFz0b6AiAm7 FefJE8671jCQ8IXN69I/o32CYKxgEMC89j4NgAOyDp8Dpu71Hf3zkQ/XCYAgDLj0CpNr DLSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oHzHXPzXYlWN69DqEELeV6l5D1ewq4CPbBpdr086xKQ=; b=ta67rqw8cmb3a7QYnJ3AuzQEtKuLnHwFgwgZfZM3sHfhmlBQpX7JNLgZgvQWGms+VJ zZg22qLl+AyFHBklGBYNEWS2KQ4FSehXudewxEBWPqax9YG0/6eX/ac87W1iFTI62VNN oIC06H8b29af69z1hPA4/dvtL/CXz0rOdreYzT5Z9bm67L3M0n0hjUAIzr+jab2zTQ9o jpuFc4COmXbBuFmCMSdIxerAoYaYH1U1vfQQWW0jp49UGBsK1dN1ePOuh5kZsFhYH6BK TmtxCJgMMqnocS4nHRIHUOl9yEK3Mzq9LSBZLdz4XXzfhWUfJ8tuiEycEEDwW+cRTV8R xdvA== X-Gm-Message-State: APjAAAW6F2InLwHpBmy9LhXB/Fco672ra4XZktkSHqdXtkYM4/PmBU2V ke+i7kqos2T73JzJdc5CXINxedN0MBTh5w== X-Google-Smtp-Source: APXvYqys3hgg2+nHupNsO4O+j2QLKAGCRT+WAoUFiVQgtvYjeRJehiu5Z2fVQJS6ObG7lrM5QUcCGQ== X-Received: by 2002:a9d:a0d:: with SMTP id 13mr20031406otg.238.1559918997692; Fri, 07 Jun 2019 07:49:57 -0700 (PDT) Received: from [192.168.3.43] (200-56-192-86-cable.cybercable.net.mx. [200.56.192.86]) by smtp.gmail.com with ESMTPSA id x21sm805430otk.4.2019.06.07.07.49.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 07:49:56 -0700 (PDT) To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20190606174609.20487-1-peter.maydell@linaro.org> <20190606174609.20487-4-peter.maydell@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <94c6b711-7944-e2cc-a8a7-9a653409a6b0@linaro.org> Date: Fri, 7 Jun 2019 09:49:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190606174609.20487-4-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::343 Subject: Re: [Qemu-devel] [PATCH 03/42] target/arm: Factor out VFP access checking code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/6/19 12:45 PM, Peter Maydell wrote: > Factor out the VFP access checking code so that we can use it in the > leaf functions of the decodetree decoder. > > We call the function full_vfp_access_check() so we can keep > the more natural vfp_access_check() for a version which doesn't > have the 'ignore_vfp_enabled' flag -- that way almost all VFP > insns will be able to use vfp_access_check(s) and only the > special-register access function will have to use > full_vfp_access_check(s, ignore_vfp_enabled). > > Signed-off-by: Peter Maydell > --- > target/arm/translate-vfp.inc.c | 100 ++++++++++++++++++++++++++++++++ > target/arm/translate.c | 101 +++++---------------------------- > 2 files changed, 113 insertions(+), 88 deletions(-) Reviewed-by: Richard Henderson r~