From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA358C433EF for ; Mon, 24 Jan 2022 07:18:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CCB510EB81; Mon, 24 Jan 2022 07:18:30 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E8D810EB81 for ; Mon, 24 Jan 2022 07:18:28 +0000 (UTC) X-UUID: 14d94c71583f415284343dc639647128-20220124 X-UUID: 14d94c71583f415284343dc639647128-20220124 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1884755155; Mon, 24 Jan 2022 15:18:21 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 24 Jan 2022 15:18:20 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 Jan 2022 15:18:20 +0800 Message-ID: <94cf3379aa648d7366143e2f84bf4e21ad3576c1.camel@mediatek.com> Subject: Re: [PATCH v11 21/22] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195 From: CK Hu To: Nancy.Lin Date: Mon, 24 Jan 2022 15:18:20 +0800 In-Reply-To: <20220110084645.31191-22-nancy.lin@mediatek.com> References: <20220110084645.31191-1-nancy.lin@mediatek.com> <20220110084645.31191-22-nancy.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, David Airlie , "jason-jh . lin" , singo.chang@mediatek.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Yongqiang Niu , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Nancy: On Mon, 2022-01-10 at 16:46 +0800, Nancy.Lin wrote: > Add driver data of mt8195 vdosys1 to mediatek-drm. > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 36430f956b4f..e851c56f00b1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -190,6 +190,14 @@ static const enum mtk_ddp_comp_id > mt8195_mtk_ddp_main[] = { > DDP_COMPONENT_DP_INTF0, > }; > > +static const enum mtk_ddp_comp_id mt8195_mtk_ddp_ext[] = { > + DDP_COMPONENT_OVL_ADAPTOR, > + DDP_COMPONENT_MERGE5, > + DDP_COMPONENT_DP_INTF1, > +}; > + > +static const int mt8195_vdosys1_mtk_cmdq_mbox[] = {-1, 0, -1}; What does this array mean? These number looks so magic. Regards, CK > + > static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = > { > .main_path = mt2701_mtk_ddp_main, > .main_len = ARRAY_SIZE(mt2701_mtk_ddp_main), > @@ -254,6 +262,14 @@ static const struct mtk_mmsys_driver_data > mt8195_vdosys0_driver_data = { > .mmsys_dev_num = 2, > }; > > +static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data > = { > + .ext_path = mt8195_mtk_ddp_ext, > + .ext_len = ARRAY_SIZE(mt8195_mtk_ddp_ext), > + .mmsys_id = 1, > + .mmsys_dev_num = 2, > + .mbox_index = mt8195_vdosys1_mtk_cmdq_mbox, > +}; > + > static const struct of_device_id mtk_drm_of_ids[] = { > { .compatible = "mediatek,mt2701-mmsys", > .data = &mt2701_mmsys_driver_data}, > @@ -271,6 +287,8 @@ static const struct of_device_id mtk_drm_of_ids[] > = { > .data = &mt8192_mmsys_driver_data}, > { .compatible = "mediatek,mt8195-vdosys0", > .data = &mt8195_vdosys0_driver_data}, > + { .compatible = "mediatek,mt8195-vdosys1", > + .data = &mt8195_vdosys1_driver_data}, > { } > }; > MODULE_DEVICE_TABLE(of, mtk_drm_of_ids); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 859C6C433EF for ; Mon, 24 Jan 2022 07:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i3HpPckcgniVH9RHhGbuin6U5KfP/yeOpZWq5bqZxSs=; b=MXeIXfXeuxFDkp z9dTTKU0wV3V0hsE+AZ8Glz/coKiO4raHaJYx5jUPDDSE92+Wt5uK/iswyt73KJu2qCCdRChDun9h /TednNXMW1a/v8iVwGS6uVsBEvaP7rHglb1BGA8SwA0kqXrNGv8SR5gnyKiIp243PkzwDNow+ojiH 4hN+1SwJOkkjyjiip+3mpx9UXH/hV+DXTxTEp4cLDopLzh0h2lWlZCG2ZhHTrDhwyDCNmCxXFQksC XNz1orrjMBQ0SwelER6gl632TUrg5s5b+ALv0EzEtLfhAxXoxJ+IXFk4SNJXOZBAywX1y9Qiyjj/D 3GwTBUg0WsRAGPqF0tDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBtln-002U7w-6e; Mon, 24 Jan 2022 07:28:07 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBtlj-002U6R-Sg; Mon, 24 Jan 2022 07:28:05 +0000 X-UUID: c3cf6f7cc97a41599c8adc1c331c9a8f-20220124 X-UUID: c3cf6f7cc97a41599c8adc1c331c9a8f-20220124 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1850136264; Mon, 24 Jan 2022 00:27:57 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 23 Jan 2022 23:18:21 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 24 Jan 2022 15:18:20 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 Jan 2022 15:18:20 +0800 Message-ID: <94cf3379aa648d7366143e2f84bf4e21ad3576c1.camel@mediatek.com> Subject: Re: [PATCH v11 21/22] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195 From: CK Hu To: Nancy.Lin CC: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Matthias Brugger , "jason-jh . lin" , Yongqiang Niu , , , , , , , Date: Mon, 24 Jan 2022 15:18:20 +0800 In-Reply-To: <20220110084645.31191-22-nancy.lin@mediatek.com> References: <20220110084645.31191-1-nancy.lin@mediatek.com> <20220110084645.31191-22-nancy.lin@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220123_232803_943306_68F68817 X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Nancy: On Mon, 2022-01-10 at 16:46 +0800, Nancy.Lin wrote: > Add driver data of mt8195 vdosys1 to mediatek-drm. > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 36430f956b4f..e851c56f00b1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -190,6 +190,14 @@ static const enum mtk_ddp_comp_id > mt8195_mtk_ddp_main[] = { > DDP_COMPONENT_DP_INTF0, > }; > > +static const enum mtk_ddp_comp_id mt8195_mtk_ddp_ext[] = { > + DDP_COMPONENT_OVL_ADAPTOR, > + DDP_COMPONENT_MERGE5, > + DDP_COMPONENT_DP_INTF1, > +}; > + > +static const int mt8195_vdosys1_mtk_cmdq_mbox[] = {-1, 0, -1}; What does this array mean? These number looks so magic. Regards, CK > + > static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = > { > .main_path = mt2701_mtk_ddp_main, > .main_len = ARRAY_SIZE(mt2701_mtk_ddp_main), > @@ -254,6 +262,14 @@ static const struct mtk_mmsys_driver_data > mt8195_vdosys0_driver_data = { > .mmsys_dev_num = 2, > }; > > +static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data > = { > + .ext_path = mt8195_mtk_ddp_ext, > + .ext_len = ARRAY_SIZE(mt8195_mtk_ddp_ext), > + .mmsys_id = 1, > + .mmsys_dev_num = 2, > + .mbox_index = mt8195_vdosys1_mtk_cmdq_mbox, > +}; > + > static const struct of_device_id mtk_drm_of_ids[] = { > { .compatible = "mediatek,mt2701-mmsys", > .data = &mt2701_mmsys_driver_data}, > @@ -271,6 +287,8 @@ static const struct of_device_id mtk_drm_of_ids[] > = { > .data = &mt8192_mmsys_driver_data}, > { .compatible = "mediatek,mt8195-vdosys0", > .data = &mt8195_vdosys0_driver_data}, > + { .compatible = "mediatek,mt8195-vdosys1", > + .data = &mt8195_vdosys1_driver_data}, > { } > }; > MODULE_DEVICE_TABLE(of, mtk_drm_of_ids); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5519DC433F5 for ; Mon, 24 Jan 2022 07:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zYd71A6OQIBahmHhlzNlAFNT3GzYCwlTY5GoRNmJcYI=; b=FLt4UvxSTZFxAY eKTplYxidI6a4AFP9PKWeikgq7s7hDLHm4PP0aM3eR06emyTD7PQ3EbDslPzMgFioQprwm7AkMtw1 P7+rMdCn1BSHoJYkHWfR5pW4dfQhQMKk+jDRjaviwcvP9eWZrhhsmWXAdN/ojHLk1ZeBcdbidFkUt rJHwLSjfOkhVJb7+LRQv3MT4njwt2clmRjOhmvBCcLYbckLXPJG0+3gjTzzjhaPiJZHmAjSjQooZy 7SOKqKaauN1shMvE3Qag5DKrC95W4H/w0WLePzhi3SYvXhRVG1vC66iD4/ByOhAYyf2TXigaiPSDN aeJpO8TK8nzlNIQ64/0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBtlo-002U84-Mw; Mon, 24 Jan 2022 07:28:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBtlj-002U6R-Sg; Mon, 24 Jan 2022 07:28:05 +0000 X-UUID: c3cf6f7cc97a41599c8adc1c331c9a8f-20220124 X-UUID: c3cf6f7cc97a41599c8adc1c331c9a8f-20220124 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1850136264; Mon, 24 Jan 2022 00:27:57 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 23 Jan 2022 23:18:21 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 24 Jan 2022 15:18:20 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 Jan 2022 15:18:20 +0800 Message-ID: <94cf3379aa648d7366143e2f84bf4e21ad3576c1.camel@mediatek.com> Subject: Re: [PATCH v11 21/22] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195 From: CK Hu To: Nancy.Lin CC: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Matthias Brugger , "jason-jh . lin" , Yongqiang Niu , , , , , , , Date: Mon, 24 Jan 2022 15:18:20 +0800 In-Reply-To: <20220110084645.31191-22-nancy.lin@mediatek.com> References: <20220110084645.31191-1-nancy.lin@mediatek.com> <20220110084645.31191-22-nancy.lin@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220123_232803_943306_68F68817 X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Nancy: On Mon, 2022-01-10 at 16:46 +0800, Nancy.Lin wrote: > Add driver data of mt8195 vdosys1 to mediatek-drm. > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 36430f956b4f..e851c56f00b1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -190,6 +190,14 @@ static const enum mtk_ddp_comp_id > mt8195_mtk_ddp_main[] = { > DDP_COMPONENT_DP_INTF0, > }; > > +static const enum mtk_ddp_comp_id mt8195_mtk_ddp_ext[] = { > + DDP_COMPONENT_OVL_ADAPTOR, > + DDP_COMPONENT_MERGE5, > + DDP_COMPONENT_DP_INTF1, > +}; > + > +static const int mt8195_vdosys1_mtk_cmdq_mbox[] = {-1, 0, -1}; What does this array mean? These number looks so magic. Regards, CK > + > static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = > { > .main_path = mt2701_mtk_ddp_main, > .main_len = ARRAY_SIZE(mt2701_mtk_ddp_main), > @@ -254,6 +262,14 @@ static const struct mtk_mmsys_driver_data > mt8195_vdosys0_driver_data = { > .mmsys_dev_num = 2, > }; > > +static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data > = { > + .ext_path = mt8195_mtk_ddp_ext, > + .ext_len = ARRAY_SIZE(mt8195_mtk_ddp_ext), > + .mmsys_id = 1, > + .mmsys_dev_num = 2, > + .mbox_index = mt8195_vdosys1_mtk_cmdq_mbox, > +}; > + > static const struct of_device_id mtk_drm_of_ids[] = { > { .compatible = "mediatek,mt2701-mmsys", > .data = &mt2701_mmsys_driver_data}, > @@ -271,6 +287,8 @@ static const struct of_device_id mtk_drm_of_ids[] > = { > .data = &mt8192_mmsys_driver_data}, > { .compatible = "mediatek,mt8195-vdosys0", > .data = &mt8195_vdosys0_driver_data}, > + { .compatible = "mediatek,mt8195-vdosys1", > + .data = &mt8195_vdosys1_driver_data}, > { } > }; > MODULE_DEVICE_TABLE(of, mtk_drm_of_ids); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel