All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@lists.linux-m68k.org
Subject: Re: m68k allmodconfig build errors
Date: Mon, 23 Jul 2018 18:52:27 -0700	[thread overview]
Message-ID: <94dc0357-10d4-c3dc-ef2a-9643f08d2a09@infradead.org> (raw)
In-Reply-To: <878t66idai.fsf@igel.home>

On 07/20/2018 12:20 AM, Andreas Schwab wrote:
> On Jul 19 2018, Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> block/partitions/ldm.o: In function `ldm_partition':
>> ldm.c:(.text+0x1900): undefined reference to `strcmp'
>> ldm.c:(.text+0x1964): undefined reference to `strcmp'
>> drivers/rtc/rtc-proc.o: In function `is_rtc_hctosys':
>> rtc-proc.c:(.text+0x290): undefined reference to `strcmp'
>> drivers/watchdog/watchdog_pretimeout.o: In function `watchdog_register_governor':
>> (.text+0x142): undefined reference to `strcmp'
> 
> GCC has optimized strncmp to strcmp, but at a stage where macros are no
> longer available.  I think the right fix is to use strcmp directly,
> since strncmp doesn't make sense here.

Hi Andreas,

I don't see that all of these string compare fields are null-terminated.

How does one convert strncmp() users to strcmp()?

thanks,
-- 
~Randy

  reply	other threads:[~2018-07-24  1:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 22:39 m68k allmodconfig build errors Randy Dunlap
2018-07-20  5:17 ` Finn Thain
2018-07-24  1:49   ` Randy Dunlap
2018-07-20  7:20 ` Andreas Schwab
2018-07-24  1:52   ` Randy Dunlap [this message]
2018-07-24  4:49     ` Finn Thain
2018-07-26 19:29       ` Randy Dunlap
2018-07-27  4:44         ` Finn Thain
2018-07-27  8:40           ` Andreas Schwab
2018-07-27 12:51             ` Finn Thain
2018-07-24 17:35     ` Andreas Schwab
2018-09-26  7:44       ` Geert Uytterhoeven
2018-09-26 16:09         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94dc0357-10d4-c3dc-ef2a-9643f08d2a09@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.