From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44AD9C4338F for ; Mon, 9 Aug 2021 15:44:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FF5660F93 for ; Mon, 9 Aug 2021 15:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235551AbhHIPoc (ORCPT ); Mon, 9 Aug 2021 11:44:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230095AbhHIPoa (ORCPT ); Mon, 9 Aug 2021 11:44:30 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D51CCC0613D3; Mon, 9 Aug 2021 08:44:09 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id s13so14833446oie.10; Mon, 09 Aug 2021 08:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xfIEzWUDBcftZDUDyQ73IjKOk2KGqvXNnD8dGpW+rlo=; b=fGM1iJJHVlpNxWI4E4jrECgCUC9fj1LJN4tQd5aMWM8drsHKYuobXpvs7PM+20/uLW htmXBNzpuOX22Oka1iMVxhSLqs8kjJatkceELw9IA6JU4BNTzzMbzGY8vxiQhk3ZABZD w7Mo0juFgCqnLeNpLTLHxqDQjfTomEt19BrxQwYAdkBjrlungN6WAL2yngyna25ZIolj TZBMaACd8pNArZQ69dTDvNk5YY0UMTCtwwJlAb8zb3sJqdKs7AtDexgejWJapk9rVl6G bMHitrVWa5eWDuMGLg6R3x3SCdaBUCcH12Cq4P47tmiJ6u77rRcxkIeso1PIUnbkplmJ Z9jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xfIEzWUDBcftZDUDyQ73IjKOk2KGqvXNnD8dGpW+rlo=; b=fGMj4f17m/wDLvwU2pB4ZukkDi0cC0Zmjd/KNjBqUA+cdwO6mM3yfTYEn52g+g3T0J aoa/60speo3yPhtj3sMizrBCOqox263EJVUO7MbASdk1Fntsmef/eBKZp67tZIJHPt13 yRqEiP5V/7Y5nrCUb3XF3KroHwmN2k05W6+7uyVFhscerQN+v3XZ6zZvEcHofBtS7Q9l yGLbHqsbMI6PesXXUVNDeLohlfJszxhNE/avGpMzNT2IugyiekYolv/2p6tDbWBd6O4V Lny5BkNzKgHNH6pj+6Bg8g5kIMfWxT3GkHtVQ9gZ+gVNRXtNHtTfCKVbDKBK25cT3XFZ Ku2Q== X-Gm-Message-State: AOAM530tHyNyOYZKsEMTUQj0KzpB6GHPdL0xgeWyxu86F+lL5eh7MuWx G9K+FOfSlJjSYPutpPlvN259nm8wk+tSOBZr X-Google-Smtp-Source: ABdhPJxgLkeRKmS9D3bTDsoGfiCtg7u1A9LPfKTKFBxGvYxn21y3lO+KcKfy3DFFHST+BwHQFjM89A== X-Received: by 2002:aca:59c6:: with SMTP id n189mr11814143oib.44.1628523849234; Mon, 09 Aug 2021 08:44:09 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id o11sm1342681otp.8.2021.08.09.08.44.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 08:44:08 -0700 (PDT) Subject: Re: [RFC PATCH v2 05/10] block: Add block device sysfs attribute to set/clear/show LED To: Jackie Liu , linux-block@vger.kernel.org, linux-leds@vger.kernel.org Cc: axboe@kernel.dk, pavel@ucw.cz, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809033217.1113444-6-arequipeno@gmail.com> From: Ian Pilcher Message-ID: <94f034a0-4c65-48d3-3eaa-a57ceb6a8ce3@gmail.com> Date: Mon, 9 Aug 2021 10:44:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 8/8/21 11:21 PM, Jackie Liu wrote: >> +// Returns a pointer to the first whitespace character in s (or a pointer to >> +// the terminating null), which is effectively a pointer to the position *after* >> +// the last character in the non-whitespace token at the beginning of s. (s is >> +// expected to be the result of a previous call to blk_ledtrig_skip_whitespace.) > > These are not linux kernel style comments. Do you mean kernel-doc comments? If so, they're not supposed to be, as the functions are not exported. >> +static const char *blk_ledtrig_find_whitespace(const char *s) ^^^^^^ -- ======================================================================== In Soviet Russia, Google searches you! ======================================================================== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC8EEC4338F for ; Mon, 9 Aug 2021 15:44:43 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67B9D60F93 for ; Mon, 9 Aug 2021 15:44:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 67B9D60F93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mD7Rl-0008Ub-Sv; Mon, 09 Aug 2021 11:44:13 -0400 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mD7Rj-0008UJ-Qa for kernelnewbies@kernelnewbies.org; Mon, 09 Aug 2021 11:44:11 -0400 Received: by mail-oi1-x229.google.com with SMTP id be20so5245730oib.8 for ; Mon, 09 Aug 2021 08:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xfIEzWUDBcftZDUDyQ73IjKOk2KGqvXNnD8dGpW+rlo=; b=fGM1iJJHVlpNxWI4E4jrECgCUC9fj1LJN4tQd5aMWM8drsHKYuobXpvs7PM+20/uLW htmXBNzpuOX22Oka1iMVxhSLqs8kjJatkceELw9IA6JU4BNTzzMbzGY8vxiQhk3ZABZD w7Mo0juFgCqnLeNpLTLHxqDQjfTomEt19BrxQwYAdkBjrlungN6WAL2yngyna25ZIolj TZBMaACd8pNArZQ69dTDvNk5YY0UMTCtwwJlAb8zb3sJqdKs7AtDexgejWJapk9rVl6G bMHitrVWa5eWDuMGLg6R3x3SCdaBUCcH12Cq4P47tmiJ6u77rRcxkIeso1PIUnbkplmJ Z9jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xfIEzWUDBcftZDUDyQ73IjKOk2KGqvXNnD8dGpW+rlo=; b=Ln2L8RtPPhJLEwgL/v9uid1lMztR24zmJXjhaqiSmnfT6TX/cGQtZui/MnNHqp8/RU m9Clj0MuOaL8v9F2rAUWL1lWqAEHKMu+ToAmYm2EuJuAml+UGo/iyyKF/iRy/lX7q4yr rpg90WE2VYyWwc4PDn0YCprfix44tbdgKns/4M/BqJiPXuLeC6NyA+EGx56+12Jf5CfS R4+v5r8xVeDZB0pRMecjX4I+/AA6ZUxXJPDTANl9Zu6PTXtoqbE/oPTHyefoKrVVcO8J h3tqTKw+PAKPbbxpCoR9kURbvLH++Wszx5Wj+ltB2zyAsAh3WrU+SRoCbVnLRRtIdG5x Pdsg== X-Gm-Message-State: AOAM533jzwtf1qKt34qALzWDNS3We4fHp9j/upt4RxTMPRteDwyszNnq my5pQviv23jijcmnyoliq3sZOksVelobh6FY X-Google-Smtp-Source: ABdhPJxgLkeRKmS9D3bTDsoGfiCtg7u1A9LPfKTKFBxGvYxn21y3lO+KcKfy3DFFHST+BwHQFjM89A== X-Received: by 2002:aca:59c6:: with SMTP id n189mr11814143oib.44.1628523849234; Mon, 09 Aug 2021 08:44:09 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id o11sm1342681otp.8.2021.08.09.08.44.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 08:44:08 -0700 (PDT) Subject: Re: [RFC PATCH v2 05/10] block: Add block device sysfs attribute to set/clear/show LED To: Jackie Liu , linux-block@vger.kernel.org, linux-leds@vger.kernel.org References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809033217.1113444-6-arequipeno@gmail.com> From: Ian Pilcher Message-ID: <94f034a0-4c65-48d3-3eaa-a57ceb6a8ce3@gmail.com> Date: Mon, 9 Aug 2021 10:44:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, pavel@ucw.cz, kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kernelnewbies-bounces@kernelnewbies.org On 8/8/21 11:21 PM, Jackie Liu wrote: >> +// Returns a pointer to the first whitespace character in s (or a pointer to >> +// the terminating null), which is effectively a pointer to the position *after* >> +// the last character in the non-whitespace token at the beginning of s. (s is >> +// expected to be the result of a previous call to blk_ledtrig_skip_whitespace.) > > These are not linux kernel style comments. Do you mean kernel-doc comments? If so, they're not supposed to be, as the functions are not exported. >> +static const char *blk_ledtrig_find_whitespace(const char *s) ^^^^^^ -- ======================================================================== In Soviet Russia, Google searches you! ======================================================================== _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies