All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Oh <peter.oh@bowerswilkins.com>
To: Anilkumar Kolli <akolli@codeaurora.org>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
	Sathishkumar Muruganandam <murugana@codeaurora.org>
Subject: Re: [PATCH 1/2] ath10k: Add WMI FWTEST command support
Date: Mon, 5 Mar 2018 10:48:07 -0800	[thread overview]
Message-ID: <94f133b3-ee5d-6ed8-d7e8-20dff9aaede2@bowerswilkins.com> (raw)
In-Reply-To: <1520233148-26050-2-git-send-email-akolli@codeaurora.org>

From: Sathishkumar Muruganandam <murugana@codeaurora.org>
> This patch adds support for WMI_FWTEST_CMD.
> This command is used for setting the wifi parameters.

It's too lack of information in commit message.
You should add such what values are acceptable for which purpose by each 
param_id and param_value to make this changes meaningful to community.

Thanks,
Peter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Oh <peter.oh@bowerswilkins.com>
To: Anilkumar Kolli <akolli@codeaurora.org>, ath10k@lists.infradead.org
Cc: Sathishkumar Muruganandam <murugana@codeaurora.org>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] ath10k: Add WMI FWTEST command support
Date: Mon, 5 Mar 2018 10:48:07 -0800	[thread overview]
Message-ID: <94f133b3-ee5d-6ed8-d7e8-20dff9aaede2@bowerswilkins.com> (raw)
In-Reply-To: <1520233148-26050-2-git-send-email-akolli@codeaurora.org>

From: Sathishkumar Muruganandam <murugana@codeaurora.org>
> This patch adds support for WMI_FWTEST_CMD.
> This command is used for setting the wifi parameters.

It's too lack of information in commit message.
You should add such what values are acceptable for which purpose by each 
param_id and param_value to make this changes meaningful to community.

Thanks,
Peter

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-03-05 18:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05  6:59 [PATCH 0/2] FWTEST command support in debugfs Anilkumar Kolli
2018-03-05  6:59 ` Anilkumar Kolli
2018-03-05  6:59 ` [PATCH 1/2] ath10k: Add WMI FWTEST command support Anilkumar Kolli
2018-03-05  6:59   ` Anilkumar Kolli
2018-03-05 18:48   ` Peter Oh [this message]
2018-03-05 18:48     ` Peter Oh
2018-03-05 19:31     ` Sebastian Gottschall
2018-03-05 19:31       ` Sebastian Gottschall
2018-03-05  6:59 ` [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters Anilkumar Kolli
2018-03-05  6:59   ` Anilkumar Kolli
2018-03-05  7:42   ` Sven Eckelmann
2018-03-05  7:42     ` Sven Eckelmann
2018-03-05 10:46     ` akolli
2018-03-05 10:46       ` akolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94f133b3-ee5d-6ed8-d7e8-20dff9aaede2@bowerswilkins.com \
    --to=peter.oh@bowerswilkins.com \
    --cc=akolli@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=murugana@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.