From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbcD2NUc (ORCPT ); Fri, 29 Apr 2016 09:20:32 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:34477 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbcD2NUb (ORCPT ); Fri, 29 Apr 2016 09:20:31 -0400 Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx To: "J.D. Schroeder" , , , , , , , References: <1461600490-19504-1-git-send-email-Linux.HWI@garmin.com> CC: Jim Lodes , "J.D. Schroeder" From: Peter Ujfalusi Message-ID: <94fc59a7-7f27-bc97-328e-33f1e7c1cb65@ti.com> Date: Fri, 29 Apr 2016 16:19:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1461600490-19504-1-git-send-email-Linux.HWI@garmin.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/25/2016 07:08 PM, J.D. Schroeder wrote: > From: Jim Lodes > > The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx > input/output status that had already been set by the > davinci_mcasp_set_sysclk function. This commit removes clearing > of the ahclkx input/output status from davinci_mcasp_set_dai_fmt. Acked-by: Peter Ujfalusi > > Signed-off-by: Jim Lodes > Signed-off-by: J.D. Schroeder > --- > sound/soc/davinci/davinci-mcasp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c > index e132498..a1197ad 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai, > mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE); > > mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG, > - ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR); > + ACLKX | AFSX | ACLKR | AHCLKR | AFSR); > mcasp->bclk_master = 0; > break; > default: > -- Péter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx Date: Fri, 29 Apr 2016 16:19:31 +0300 Message-ID: <94fc59a7-7f27-bc97-328e-33f1e7c1cb65@ti.com> References: <1461600490-19504-1-git-send-email-Linux.HWI@garmin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by alsa0.perex.cz (Postfix) with ESMTP id A5BD2261483 for ; Fri, 29 Apr 2016 15:20:22 +0200 (CEST) In-Reply-To: <1461600490-19504-1-git-send-email-Linux.HWI@garmin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "J.D. Schroeder" , linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, jsarha@ti.com, alsa-devel@alsa-project.org Cc: Jim Lodes , "J.D. Schroeder" List-Id: alsa-devel@alsa-project.org On 04/25/2016 07:08 PM, J.D. Schroeder wrote: > From: Jim Lodes > = > The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx > input/output status that had already been set by the > davinci_mcasp_set_sysclk function. This commit removes clearing > of the ahclkx input/output status from davinci_mcasp_set_dai_fmt. Acked-by: Peter Ujfalusi > = > Signed-off-by: Jim Lodes > Signed-off-by: J.D. Schroeder > --- > sound/soc/davinci/davinci-mcasp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinc= i-mcasp.c > index e132498..a1197ad 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_d= ai *cpu_dai, > mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE); > = > mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG, > - ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR); > + ACLKX | AFSX | ACLKR | AHCLKR | AFSR); > mcasp->bclk_master =3D 0; > break; > default: > = -- = P=E9ter