From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC03C32793 for ; Wed, 18 Jan 2023 16:02:00 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38DBF40223; Wed, 18 Jan 2023 17:01:59 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 12596400D6 for ; Wed, 18 Jan 2023 17:01:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674057718; x=1705593718; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=wtdnZBlwrYgPslTh7zZgcmW0Oszpc2trVMea8cHXNiw=; b=k8dii6nGP6v5xGaTNSf3OQG9aYsEzVv4VSq2oFlgkfOroIKvhBh24KQm t5pAan8yxD7ELJIvan1j7fjusNylUpQXCu6fezsASRAwGfh6MVeaCgwIO bV8denFtMPP81XS72dOln4NGJPX3vqIIpIx9CpcBxbGmHL2t0o3UtdXlx +WvAl3piPH9+4ejw/fwbvhBLYOW7Y9qckSyEmbdHfP4B463f+JBuRBMw4 TyIUgJj9UsHZoyoitG+K4qp3le2tmVL8nJC/LLlKz6YJn1l/ZHe4EvfUh 3ws71DnNxnb/cjyRnG3pVlvDJy+C2qFHpPbQsc8Ev/cSNoPfs35uvf5qe Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="304698852" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="304698852" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 08:01:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="767796497" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="767796497" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 18 Jan 2023 08:01:53 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 08:01:53 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 08:01:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 08:01:52 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 08:01:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HBWl9qbpyyQ26G3ZhJyqZd+as9utsFnfR6Twik44Sf54+gl2dvPnBeEBLrBwfgmrCWNySRw7T2+noG0BT8g7uPLKTmu/ztEWdPVF7cDUF+ghBRrLIpW0yZsgB37b6vJAPSZVWdxwOvVc0rsd+tSFbw9GGVQiGh1peNrc7cadE+hk8P6apJk9NfL3sGpL++9365ap2DBobXbZhopErDJrUPLlw/WNcg6MTX8jENrkXW+7QG3N2ZOIGQanmZU1/9hCEWyskzdL8b2J7FLDV//n1Z3ze+/xUu79mJIEjgJYevcOCpCVMUZvDtHKOx00mReCHdzXj9Uh7PCuyChQnVQ+Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O/U/DfvEOVnr957K9MaZeaA98pik537fkaXxaKmJsug=; b=SvUkIu3h7u6S6j4Q+hjAfKms2lSBtXlaTKzZrXst906fkzRrirJI2WNuy+slspPpK8jxzpIgQhgfL7+5ZhBuyBO/vWvZFuXLg6A1wV38mTeIPYJOo+ipTSE6Jf5r9PjAatZ7r1QE0/m2eBUGJ/YFOACOwOdK5JXIzTHHiIweVWs3Uvqo/k1p329yN8zTZbCAHty613LdAaXOk92ibRgMIzkJrN0t/lq2eMVs+BCfZ0zRGzPmH1bJpofU7WReOrQ2dNLIBCgOoMzW645bKKRrtwsPToUeBxt4zy3f4sW4T8oaTVwx/u+4e5BphXx8dG+55ZzjVSTNEuGik2iKWpj6yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BL3PR11MB5681.namprd11.prod.outlook.com (2603:10b6:208:33c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 18 Jan 2023 16:01:50 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Wed, 18 Jan 2023 16:01:50 +0000 Message-ID: <95094ec0-497a-f0f8-174f-b362ea576336@intel.com> Date: Wed, 18 Jan 2023 16:01:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5 1/4] eal: add lcore info in telemetry Content-Language: en-US To: Robin Jarry , CC: Tyler Retzlaff , =?UTF-8?Q?Morten_Br=c3=b8rup?= References: <20221123102612.1688865-1-rjarry@redhat.com> <20221216102109.64142-1-rjarry@redhat.com> <20221216102109.64142-2-rjarry@redhat.com> <50d3c808-c227-2915-3d07-74e8c3c7fab8@intel.com> From: Kevin Laatz In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0087.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::18) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|BL3PR11MB5681:EE_ X-MS-Office365-Filtering-Correlation-Id: 32cd1711-7583-4d0d-3636-08daf96d4f09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q2HCrXIceet+vmlhQPB6sYDk1AXQSC8OxXETDbSfhAS1Z6WKM7K9OqRCEur6hLwvQUfF9U3Gp2uUjIHrlukX33ZIDcHsSH0GSMtQNGqz0gRi8e0SHgMNesnQmV5HasPgXoEdtBZngBN32fuCOeLLCcBiKTFysyHU6AQker7hjb+G1L9GwE9rHZ1ZdH8qovJX4p63uSTzu678X2ESBBmMl8BCSsKkcQdaM2VRvnA15m1nh2PAr8Bv5LUUc/jH/ILRhfeSpK8O24atdaUUIKm16MnbK6/39+4FLFwvP1IR1jTIgFjaR/atHh8s8SpLEBgh85J4/hpAT57h87yiSy5tXAtF6W8Hr5GY9gKu3LQ/m/LV3PTVreThk9yl3sdu9Oa+Hs09algaSiQvur2ZUqFHpjkd6ENhu3XJlxckFIm9G0CDRtw0nWCuj4GOd49D0/jdU38EG2z03VUDWGvit7kBsXTh5UJ7azNDYbVsj8jxhTDKbCKDwNRpCSAUwnkaQPFF6whFSz3eq+oMJ8OwH/7LuufwSSe6HlUD7wNftXzQDy4BhAkpZoUvkXVcUJRH9kVzOhegy0D2BQiWQ/J6UBMqoldcv+KO5lX/ZaQ0cHwnWUfUS/8R+T8D6cszxE0TpqfDfC2Pc+eEhTClwOzoMriWr7bnrSgjt0buctlfvYj6Ux6zM75J+Y6Uo5Ufk/98aM7USc9kAPzJKV578T1jGE4h9VMPN4qrTTkWqSYZNs+QmQY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(396003)(366004)(346002)(39860400002)(451199015)(8936002)(5660300002)(44832011)(41300700001)(4326008)(8676002)(66556008)(66476007)(86362001)(31696002)(2906002)(66946007)(36756003)(82960400001)(38100700002)(6486002)(2616005)(6666004)(6506007)(53546011)(478600001)(26005)(186003)(6512007)(31686004)(316002)(54906003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlZacnlSbWZhWEtBZnpPTGFEUWJ6a0pXSWpBL0ppMnJKYzc4UXFvNWNNSTgx?= =?utf-8?B?TXRHMnEyNzNlYU1YcER3S3JQUXNwSVVnQlhFQnRYQ002MURMOTJSVEtTWXdv?= =?utf-8?B?QTczVU9nU1laSWhLbTdIWXViZ21leHNjNThvdFRmWW1OcHhNLzU5TjFtRi9R?= =?utf-8?B?UVRrOGhjTHdvUVRSZ0JhaUNWQ2JFRnpOd0xTc2Q0d1hITVBicUdSRkNYTSty?= =?utf-8?B?OTk0WkJ1aVFTOXc0RGY3TlVNdC9RalJUUkx0U3EyekJnWS93Z1VMUUxrNjc0?= =?utf-8?B?NXRobnJhSHpDeThGbHBscjVKT1kvclF2NmJUOENxc3JYY1l0cUIwNHVCeG1q?= =?utf-8?B?dXJ6WkFWV0Vtdkt1ZEE2Uk9RdmczRk93U2h5T2lHSEFwSHZYNldjMzVEeW5H?= =?utf-8?B?V2UvaTdKZjFYa2JEaXlWQzZMM0RvaVhvVThmR0lsM2RuYS8wNWltcFZVQnNY?= =?utf-8?B?UHM5bTFtSHZ6aFZGdE9tKzN5bzRveHkrTXJubnNDc0lYdVA3WkltUDI2eXls?= =?utf-8?B?V2E4eEJyODdzK3Q1SzkyVzJKRGMxc3V3Yk5sejlvMUxQd2FUUjdycGVNc1NS?= =?utf-8?B?R0xXenRUUU9NaTlIbm1vNk1CYkJqL2lneTVLQ1VLRXBkVklLSlNBNGh2WVdZ?= =?utf-8?B?RkFWTEdlZHpURjJVTVF3SjJlUkZzbVpZWndBVDVyS3E1Q1BwSFIrQTZGR3VB?= =?utf-8?B?MVVXTHljVThmUEMyYW00bjQ5UElZeEN1R01kdy8yTXY1bVNjSmpTa3QrRTg4?= =?utf-8?B?d3ZrczB4blk3NkpTVVI2MDYwL2hHSDBsQWl5NThxT3BCV1RwUTVXc1QrY2Yw?= =?utf-8?B?cnQxYi9RWDgzbmtmQUdad241dnFGMG1pR05WN3FBd3pxZGIzSGpCcUtMWG1l?= =?utf-8?B?QWVBU1lsd2pJOUNSdU84KzNCRGRxUnNMa0JsUG1JSmR5M0hybEdxVUVqelJp?= =?utf-8?B?SGFrWnRXWE1ScXZJK25maVg2bnNQV2VHd0dQdW52Z3ZsTm5WMElHRkxxUks2?= =?utf-8?B?cHV2YVJnd2RCdFh2TVBRUlJNTVRyaTJnMTFYSEk0OUxhY0VYNWhyQTNqTXZR?= =?utf-8?B?UGhwUmhSellUN1MybG0zMHM0TE5FZTJtQk10ZjZEOWhlZGYzbXEzNUdvekxy?= =?utf-8?B?MmFsOXpNZEJxWVQzYnRRVml1eVpsY1AzU2lPYkpSSGlmeGFyYTV5N3JFV09H?= =?utf-8?B?elZqM1dLV3I0NlZFU3hDMWQ4Z0w5eW8yajRQTkJuRDdWQnpOU2JnSzdRdTJh?= =?utf-8?B?Wjd2MnNubE9tblJQZlJhZEpzYzVkT3lXZ0N1NEIxVktUaU5laDRMMDBXVzF3?= =?utf-8?B?cHpFOXdxejk2MzNSQ1RGT1JnQnVrN252cDJ6cDRkbVk1cDdZdDA3MXRGRU9Y?= =?utf-8?B?VjNiUTdaZ1Y4bkNlZWU5UUhKdmJrdnpLYnFpWERXMnN5aDJpVldENWplU21X?= =?utf-8?B?aHgvZzNwTFNvWGU4YkozbE5OUUcybkZLcUxzSnZLZmpnRjZzczFsYVprN3JR?= =?utf-8?B?SGIxSVZ2SVFzQWFEai9YMGJINlQ0YVBQQitZM0k5SGxNM3BnZFUyUlBIdXB3?= =?utf-8?B?M29OZXhQdTlrMlNMVGVici82c25GNnJTV0lhckZiNHVPdzVnTEJxNDJONVBa?= =?utf-8?B?Y20ra3FJS1I2YzJGTERTemkwWEx4SzhYWXpLQTZxbExIdEZnek9Gb2VvdDF4?= =?utf-8?B?dnZYNVlJS3Ztd09Ed1dkYVZjY2ZSSzZ2TlZ5MU5Keld0cWNIenBicHVmYjVq?= =?utf-8?B?b3c0dzQ5bHk1VzNBMDE3MDZYbDJHWkNYMnNlbWFIekVnblZjMkNEOTFpeTUx?= =?utf-8?B?Nlh4V0ViQWlLaE9BSkVDZXFsS1dxaStlU2RnK0JPc2h4UmJrNlViWFZLb1k0?= =?utf-8?B?TTV3dmNUc1NqM25LdFRJOE5MTzNqMGRoUGxLdUJxcVMvbWNhbTc4ZWpKc1E1?= =?utf-8?B?UmxUazdpNk9OSGVEcURkcEViZ2QzMHFNNEhVUUxFZTlqejM0MHpVU1J0d2xC?= =?utf-8?B?WjNEU1JGelFGb1Z3Z2hWSHNiWE9HczF1R2RjWjhVUGJXZU5mdUFFazNjbmcr?= =?utf-8?B?bDRhWnRiWWxwQ0EzSUNGYnp2KzZkY1dna1VZQ0ZHYmU3UVNndWx0dHQrcER3?= =?utf-8?B?V2t0RVlGZWtOdFdOZzdiNU5IZmZnN052QTVtd1FtcjJzZ2VSMnVXalhBOGZ1?= =?utf-8?B?Tmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 32cd1711-7583-4d0d-3636-08daf96d4f09 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 16:01:50.3007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iEP4MYH+SdQjoZLP1kvTG7lIAq8I21DOoLqYP2u+awRqgptRLjWY+X9W+GqFWH5vR/Yj9DqKQpNdq/NOhAUt4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5681 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18/01/2023 14:45, Robin Jarry wrote: > Kevin Laatz, Jan 18, 2023 at 10:42: >> Hi Robin, >> >> Thanks for taking the time to work on this. It is a good implementation >> for debug use-cases. >> >> I have 2 suggestions which would improve the usability of the data: >> 1. Could we make the lcore_id paramater on /eal/lcore/info optional? >> This would allow users to read info for all lcores in the application at >> once. > I don't think it would be a good thing since it would require returning > a different data format depending the parameter is specifier or not. > > Probably adding another endpoint /eal/lcore/info_all that returns a list > of /eal/lcore/info (one for every lcore) would be better. Either option seems ok, I don't have a strong preference, the main thing here is to get the info for all cores in our telemetry read. >> 2. Could we add 2 additional telemetry endpoints? One which returns an >> array of busy_cycles values and the other returns an array of >> total_cycles values. These arrays could be used in conjunction with the >> /eal/lcore/list endpoint to quickly read the usage related metrics. I've >> included an example diff below [1]. >> >> We have a use-case beyond debugging in which we read telemetry every few >> milliseconds. From a performance point of view, adding the 2 additional >> endpoints would be very beneficial. > If we add /eal/lcore/info_all you would have all this without two > additional endpoints. I don't think that calling it every few > milliseconds and extracting the {busy,total}_cycles values would be > a problem. > > I can add another patch in the series but I would prefer not changing > the format at the last minute. While all of the information would be available, there are performance benefits to reducing the size of data returned and by flattening the arrays, in addition to a reduction in the JSON parsing required to extract the needed metrics. The additional endpoint(s) (I like Morten's idea of a single additional endpoint where you can specify the metrics to include via parameters) shouldn't affect the format of other parts of this patchset, but we would gain the benefits of the additional metric format.