From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH] xen-block: stop leaking memory in xen_block_drive_create() Date: Tue, 19 Feb 2019 16:36:28 +0000 Message-ID: <9510cf48c9064c0fb1e6eb64b414a7ea__14295.3830001474$1550594476$gmane$org@AMSPEX02CL03.citrite.net> References: <20190219163440.15702-1-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gw8RN-0001FB-A6 for xen-devel@lists.xenproject.org; Tue, 19 Feb 2019 16:40:17 +0000 In-Reply-To: <20190219163440.15702-1-paul.durrant@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "qemu-block@nongnu.org" , "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" Cc: Anthony Perard , Peter Maydell , Stefano Stabellini , Kevin Wolf , Max Reitz List-Id: xen-devel@lists.xenproject.org QXBvbG9naWVzLi4uIHR5cG8tZWQgcWVtdS1kZXZlbC4uLgoKPiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQo+IEZyb206IFBhdWwgRHVycmFudCBbbWFpbHRvOnBhdWwuZHVycmFudEBjaXRyaXgu Y29tXQo+IFNlbnQ6IDE5IEZlYnJ1YXJ5IDIwMTkgMTY6MzUKPiBUbzogcWVtZS1kZXZlbEBub25n bnUub3JnOyBxZW11LWJsb2NrQG5vbmdudS5vcmc7IHhlbi0KPiBkZXZlbEBsaXN0cy54ZW5wcm9q ZWN0Lm9yZwo+IENjOiBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFudEBjaXRyaXguY29tPjsgUGV0 ZXIgTWF5ZGVsbAo+IDxwZXRlci5tYXlkZWxsQGxpbmFyby5vcmc+OyBTdGVmYW5vIFN0YWJlbGxp bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Owo+IEFudGhvbnkgUGVyYXJkIDxhbnRob255LnBl cmFyZEBjaXRyaXguY29tPjsgS2V2aW4gV29sZiA8a3dvbGZAcmVkaGF0LmNvbT47Cj4gTWF4IFJl aXR6IDxtcmVpdHpAcmVkaGF0LmNvbT4KPiBTdWJqZWN0OiBbUEFUQ0hdIHhlbi1ibG9jazogc3Rv cCBsZWFraW5nIG1lbW9yeSBpbgo+IHhlbl9ibG9ja19kcml2ZV9jcmVhdGUoKQo+IAo+IFRoZSBs b2NhbGx5IGFsbG9jYXRlZCBRRGljdC1zIG5lZWQgdG8gYmUgZnJlZWQuICgnZmlsZV9sYXllcicg d2lsbCBiZQo+IGZyZWVkIGltcGxpY2l0bHkgc2luY2UgaXQgaXMgYWRkZWQgYXMgYW4gb2JqZWN0 IHRvICdkcml2ZXJfbGF5ZXInKS4KPiAKPiBTcG90dGVkIGJ5IENvdmVyaXR5OiBDSUQgMTM5ODY0 OQo+IAo+IFdoaWxlIGluIHRoZSBuZWlnaGJvdXJob29kIGZyZWUgJ2RyaXZlcicgYW5kICdmaWxl bmFtZScgYXMgc29vbiBhcyB0aGV5Cj4gYXJlCj4gYWRkZWQgdG8gdGhlIFFEaWN0cy4gRnJlZWlu ZyBhZnRlciB0aGUgJ2RvbmUnIGxhYmVsIGRvZXNuJ3QgbWFrZSB0aGF0IG11Y2gKPiBzZW5zZSBh cywgaWYgdGhlIGVycm9yIHBhdGgganVtcHMgdG8gdGhhdCBsYWJlbCwgdGhlIHZhbHVlcyB3b3Vs ZCBiZSBOVUxMCj4gYW55d2F5Lgo+IAo+IFRoaXMgcGF0Y2ggYWxzbyBtYWtlcyB0aGF0IG1vcmUg b2J2aW91cyBieSB0YWtpbmcgdGhlIGVycm9yIHBhdGggaWYKPiAncGFyYW1zJyBpcyBOVUxMIGFu ZCB0aGVuIGFzc2VydGluZyB0aGF0IGJvdGggZHJpdmVyIGFuZCBmaWxlbmFtZSBhcmUKPiBub24t TlVMTCBpbiB0aGUgbm9ybWFsIHBhdGguCj4gCj4gUmVwb3J0ZWQtYnk6IFBldGVyIE1heWRlbGwg PHBldGVyLm1heWRlbGxAbGluYXJvLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIER1cnJhbnQg PHBhdWwuZHVycmFudEBjaXRyaXguY29tPgo+IC0tLQo+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkg PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4gQ2M6IEFudGhvbnkgUGVyYXJkIDxhbnRob255LnBl cmFyZEBjaXRyaXguY29tPgo+IENjOiBLZXZpbiBXb2xmIDxrd29sZkByZWRoYXQuY29tPgo+IENj OiBNYXggUmVpdHogPG1yZWl0ekByZWRoYXQuY29tPgo+IC0tLQo+ICBody9ibG9jay94ZW4tYmxv Y2suYyB8IDE2ICsrKysrKysrKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaHcvYmxvY2sveGVuLWJsb2Nr LmMgYi9ody9ibG9jay94ZW4tYmxvY2suYwo+IGluZGV4IDM3YTQ1NmMyMDcuLjcwZmMyNDU1ZTgg MTAwNjQ0Cj4gLS0tIGEvaHcvYmxvY2sveGVuLWJsb2NrLmMKPiArKysgYi9ody9ibG9jay94ZW4t YmxvY2suYwo+IEBAIC03NDMsMTIgKzc0MywxMiBAQCBzdGF0aWMgWGVuQmxvY2tEcml2ZSAqeGVu X2Jsb2NrX2RyaXZlX2NyZWF0ZShjb25zdAo+IGNoYXIgKmlkLAo+ICAgICAgICAgIH0KPiAKPiAg ICAgICAgICBnX3N0cmZyZWV2KHYpOwo+IC0gICAgfQo+IC0KPiAtICAgIGlmICghZmlsZW5hbWUp IHsKPiAtICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJubyBmaWxlbmFtZSIpOwo+ICsgICAgfSBl bHNlIHsKPiArICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJubyBwYXJhbXMiKTsKPiAgICAgICAg ICBnb3RvIGRvbmU7Cj4gICAgICB9Cj4gKwo+ICsgICAgYXNzZXJ0KGZpbGVuYW1lKTsKPiAgICAg IGFzc2VydChkcml2ZXIpOwo+IAo+ICAgICAgZHJpdmUgPSBnX25ldzAoWGVuQmxvY2tEcml2ZSwg MSk7Cj4gQEAgLTc1OCw2ICs3NTgsNyBAQCBzdGF0aWMgWGVuQmxvY2tEcml2ZSAqeGVuX2Jsb2Nr X2RyaXZlX2NyZWF0ZShjb25zdAo+IGNoYXIgKmlkLAo+IAo+ICAgICAgcWRpY3RfcHV0X3N0cihm aWxlX2xheWVyLCAiZHJpdmVyIiwgImZpbGUiKTsKPiAgICAgIHFkaWN0X3B1dF9zdHIoZmlsZV9s YXllciwgImZpbGVuYW1lIiwgZmlsZW5hbWUpOwo+ICsgICAgZ19mcmVlKGZpbGVuYW1lKTsKPiAK PiAgICAgIGlmIChtb2RlICYmICptb2RlICE9ICd3Jykgewo+ICAgICAgICAgIHFkaWN0X3B1dF9i b29sKGZpbGVfbGF5ZXIsICJyZWFkLW9ubHkiLCB0cnVlKTsKPiBAQCAtNzkzLDE2ICs3OTQsMTcg QEAgc3RhdGljIFhlbkJsb2NrRHJpdmUgKnhlbl9ibG9ja19kcml2ZV9jcmVhdGUoY29uc3QKPiBj aGFyICppZCwKPiAgICAgIGRyaXZlcl9sYXllciA9IHFkaWN0X25ldygpOwo+IAo+ICAgICAgcWRp Y3RfcHV0X3N0cihkcml2ZXJfbGF5ZXIsICJkcml2ZXIiLCBkcml2ZXIpOwo+ICsgICAgZ19mcmVl KGRyaXZlcik7Cj4gKwo+ICAgICAgcWRpY3RfcHV0X29iaihkcml2ZXJfbGF5ZXIsICJmaWxlIiwg UU9CSkVDVChmaWxlX2xheWVyKSk7Cj4gCj4gICAgICBnX2Fzc2VydCghZHJpdmUtPm5vZGVfbmFt ZSk7Cj4gICAgICBkcml2ZS0+bm9kZV9uYW1lID0geGVuX2Jsb2NrX2Jsb2NrZGV2X2FkZChkcml2 ZS0+aWQsIGRyaXZlcl9sYXllciwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICZsb2NhbF9lcnIpOwo+IAo+IC1kb25lOgo+IC0gICAgZ19mcmVlKGRyaXZl cik7Cj4gLSAgICBnX2ZyZWUoZmlsZW5hbWUpOwo+ICsgICAgcW9iamVjdF91bnJlZihkcml2ZXJf bGF5ZXIpOwo+IAo+ICtkb25lOgo+ICAgICAgaWYgKGxvY2FsX2Vycikgewo+ICAgICAgICAgIGVy cm9yX3Byb3BhZ2F0ZShlcnJwLCBsb2NhbF9lcnIpOwo+ICAgICAgICAgIHhlbl9ibG9ja19kcml2 ZV9kZXN0cm95KGRyaXZlLCBOVUxMKTsKPiAtLQo+IDIuMjAuMS4yLmdiMjFlYmI2CgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==