From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDB7C433E0 for ; Mon, 25 May 2020 10:20:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C453D20723 for ; Mon, 25 May 2020 10:20:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="ea1g/amu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389779AbgEYKUj (ORCPT ); Mon, 25 May 2020 06:20:39 -0400 Received: from ssl.serverraum.org ([176.9.125.105]:55171 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389356AbgEYKUj (ORCPT ); Mon, 25 May 2020 06:20:39 -0400 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id B2E8E224C1; Mon, 25 May 2020 12:20:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1590402035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaBHew0vxxdSiEHFxN0/9/jK/7HdYOSYbRfKY5g0cf4=; b=ea1g/amuAFXkMGyk8b01UJ7SrnTfSaaC0mLpqaKs3JWGpnTuJMhPFxCjrOrj5hGTBW8g1t mYu/alo7xbuCw9vBpCPuDGeqDHA+jdYpRLceu125oZwEWGtTah1zfrAEd2LfXjKMyULS3n 5CBwJkAWm0vxbZD5i+M/5MsdB4Z8DEI= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 25 May 2020 12:20:25 +0200 From: Michael Walle To: Bartosz Golaszewski Cc: Andy Shevchenko , linux-gpio , linux-devicetree , LKML , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, LINUXWATCHDOG , arm-soc , Linus Walleij , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman Subject: Re: [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap In-Reply-To: References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-11-michael@walle.cc> <75bff2917be1badd36af9f980cf59d2c@walle.cc> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <951244aab2ff553a463f7431ba09bf27@walle.cc> X-Sender: michael@walle.cc Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Am 2020-05-25 11:05, schrieb Bartosz Golaszewski: > wt., 12 maj 2020 o 16:41 Michael Walle napisał(a): >> >> >> + >> >> +MODULE_AUTHOR("Michael Walle "); >> >> +MODULE_DESCRIPTION("GPIO generic regmap driver core"); >> >> +MODULE_LICENSE("GPL"); >> >> diff --git a/include/linux/gpio-regmap.h b/include/linux/gpio-regmap.h >> >> new file mode 100644 >> >> index 000000000000..a868cbcde6e9 >> >> --- /dev/null >> >> +++ b/include/linux/gpio-regmap.h >> >> @@ -0,0 +1,69 @@ >> >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> >> + >> >> +#ifndef _LINUX_GPIO_REGMAP_H >> >> +#define _LINUX_GPIO_REGMAP_H >> >> + >> >> +struct gpio_regmap; >> >> + >> >> +#define GPIO_REGMAP_ADDR_ZERO ((unsigned long)(-1)) >> >> +#define GPIO_REGMAP_ADDR(addr) ((addr) ? : GPIO_REGMAP_ADDR_ZERO) >> >> + >> > >> > What if the addr is actually 0? >> >> Then the driver has to set GPIO_REGMAP_ADDR_ZERO or use the >> convenience >> macro GPIO_REGMAP_ADDR. >> >> So you can have >> >> struct gpio_regmap_config config = { 0 }; >> config.reg_dat_base = 0x10; >> config.reg_dir_out_base = 0x20; >> >> or >> >> config.reg_dat_base = GPIO_REGMAP_ADDR_ZERO; >> >> or if you can't be sure if the RHS value might be zero: >> >> config.reg_dat_base = GPIO_REGMAP_ADDR(reg); >> >> >> > Maybe drop GPIO_REGMAP_ADDR and require users to set unused registers >> > to GPIO_REGMAP_ADDR_ZERO? >> >> Thats bad because: >> * you'd have to set plenty of unused base registers for a simple >> driver >> * if there will be additional properties in the future, you have to >> touch >> all other drivers, because they are initialized as 0 (ie. valid >> reg >> 0). >> >> >> +/** >> >> + * struct gpio_regmap_config - Description of a generic regmap >> >> gpio_chip. >> >> + * >> >> + * @parent: The parent device >> >> + * @regmap: The regmap used to access the registers >> >> + * given, the name of the device is used >> >> + * @label: (Optional) Descriptive name for GPIO >> >> controller. >> >> + * If not given, the name of the device is used. >> >> + * @ngpio: Number of GPIOs >> >> + * @reg_dat_base: (Optional) (in) register base address >> >> + * @reg_set_base: (Optional) set register base address >> >> + * @reg_clr_base: (Optional) clear register base address >> >> + * @reg_dir_in_base: (Optional) out setting register base address >> >> + * @reg_dir_out_base: (Optional) in setting register base address >> > >> > The two above are inverted I think? >> good catch. >> >> > Also: why the limitation of only supporting one at a time? >> >> they should be exclusive, either you have a register where you set the >> output bits to one, or the input bits. Maybe this need a bit more >> context >> above. in gpio-mmio.c you can set both and both are used in >> set_direction(), but only one is read in get_direction(). >> >> That being said, I have no strong opinion wether they should be >> exclusive >> or not, besides the symmetry of set_/get_direction(). >> >> -michael >> > > Sorry for the late response, your comments make sense to me. Are you > going to submit a v4 before the v5.8 merge window? I'm currently stuck with how to handle the MFD part. Ie. Rob doesn't seem to like the logicial device numbering - or at least there wasn't an answer to that one anymore, see patch 5/16. If you like I could submit this patch on its own. But then there wouldn't be a user for it. -michael From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Walle Subject: Re: [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap Date: Mon, 25 May 2020 12:20:25 +0200 Message-ID: <951244aab2ff553a463f7431ba09bf27@walle.cc> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-11-michael@walle.cc> <75bff2917be1badd36af9f980cf59d2c@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-hwmon-owner@vger.kernel.org To: Bartosz Golaszewski Cc: Andy Shevchenko , linux-gpio , linux-devicetree , LKML , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, LINUXWATCHDOG , arm-soc , Linus Walleij , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner List-Id: linux-pwm@vger.kernel.org Am 2020-05-25 11:05, schrieb Bartosz Golaszewski: > wt., 12 maj 2020 o 16:41 Michael Walle napisał(a): >> >> >> + >> >> +MODULE_AUTHOR("Michael Walle "); >> >> +MODULE_DESCRIPTION("GPIO generic regmap driver core"); >> >> +MODULE_LICENSE("GPL"); >> >> diff --git a/include/linux/gpio-regmap.h b/include/linux/gpio-regmap.h >> >> new file mode 100644 >> >> index 000000000000..a868cbcde6e9 >> >> --- /dev/null >> >> +++ b/include/linux/gpio-regmap.h >> >> @@ -0,0 +1,69 @@ >> >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> >> + >> >> +#ifndef _LINUX_GPIO_REGMAP_H >> >> +#define _LINUX_GPIO_REGMAP_H >> >> + >> >> +struct gpio_regmap; >> >> + >> >> +#define GPIO_REGMAP_ADDR_ZERO ((unsigned long)(-1)) >> >> +#define GPIO_REGMAP_ADDR(addr) ((addr) ? : GPIO_REGMAP_ADDR_ZERO) >> >> + >> > >> > What if the addr is actually 0? >> >> Then the driver has to set GPIO_REGMAP_ADDR_ZERO or use the >> convenience >> macro GPIO_REGMAP_ADDR. >> >> So you can have >> >> struct gpio_regmap_config config = { 0 }; >> config.reg_dat_base = 0x10; >> config.reg_dir_out_base = 0x20; >> >> or >> >> config.reg_dat_base = GPIO_REGMAP_ADDR_ZERO; >> >> or if you can't be sure if the RHS value might be zero: >> >> config.reg_dat_base = GPIO_REGMAP_ADDR(reg); >> >> >> > Maybe drop GPIO_REGMAP_ADDR and require users to set unused registers >> > to GPIO_REGMAP_ADDR_ZERO? >> >> Thats bad because: >> * you'd have to set plenty of unused base registers for a simple >> driver >> * if there will be additional properties in the future, you have to >> touch >> all other drivers, because they are initialized as 0 (ie. valid >> reg >> 0). >> >> >> +/** >> >> + * struct gpio_regmap_config - Description of a generic regmap >> >> gpio_chip. >> >> + * >> >> + * @parent: The parent device >> >> + * @regmap: The regmap used to access the registers >> >> + * given, the name of the device is used >> >> + * @label: (Optional) Descriptive name for GPIO >> >> controller. >> >> + * If not given, the name of the device is used. >> >> + * @ngpio: Number of GPIOs >> >> + * @reg_dat_base: (Optional) (in) register base address >> >> + * @reg_set_base: (Optional) set register base address >> >> + * @reg_clr_base: (Optional) clear register base address >> >> + * @reg_dir_in_base: (Optional) out setting register base address >> >> + * @reg_dir_out_base: (Optional) in setting register base address >> > >> > The two above are inverted I think? >> good catch. >> >> > Also: why the limitation of only supporting one at a time? >> >> they should be exclusive, either you have a register where you set the >> output bits to one, or the input bits. Maybe this need a bit more >> context >> above. in gpio-mmio.c you can set both and both are used in >> set_direction(), but only one is read in get_direction(). >> >> That being said, I have no strong opinion wether they should be >> exclusive >> or not, besides the symmetry of set_/get_direction(). >> >> -michael >> > > Sorry for the late response, your comments make sense to me. Are you > going to submit a v4 before the v5.8 merge window? I'm currently stuck with how to handle the MFD part. Ie. Rob doesn't seem to like the logicial device numbering - or at least there wasn't an answer to that one anymore, see patch 5/16. If you like I could submit this patch on its own. But then there wouldn't be a user for it. -michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F641C433DF for ; Mon, 25 May 2020 10:21:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36D582073B for ; Mon, 25 May 2020 10:21:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b2Loj8R0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="ea1g/amu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36D582073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZJA+Nx7BpvljfhjtxZ0byfZ5EZLykdR3ZgHLDzeAmHk=; b=b2Loj8R0+zowxIlqZB0NXlG/s YtqaxO27VPoVNdCJ4VseVCSxUAhk6kSML8MfLcIbZaIldNmPMIkjwnon6VGK9TtW8pbhs2x1XOV62 05Hxbtzwf6aSH3fM31eXKgo8YQgngGZu0BkokPUgLRWGChn11pf90gbEWnImMNoetjD+Vq7ihHOk3 1UGdfIMFQglNdtR7/lOMayLFksWibeL4GU5xuu71ehCdPwNvvrnaam9Qono1QfRi0zwMlAH8GqOOB MDZ09h/nL+bdfrp1v/fpUEy304YNrwqGWfd8Pq0NvauOu6y/dWYxHOdpU8lBSBbwluQhsOMkVSGjL sx/9aGdlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdAET-0003QE-OX; Mon, 25 May 2020 10:21:21 +0000 Received: from ssl.serverraum.org ([176.9.125.105]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdADs-0002tu-7v for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 10:20:48 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id B2E8E224C1; Mon, 25 May 2020 12:20:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1590402035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaBHew0vxxdSiEHFxN0/9/jK/7HdYOSYbRfKY5g0cf4=; b=ea1g/amuAFXkMGyk8b01UJ7SrnTfSaaC0mLpqaKs3JWGpnTuJMhPFxCjrOrj5hGTBW8g1t mYu/alo7xbuCw9vBpCPuDGeqDHA+jdYpRLceu125oZwEWGtTah1zfrAEd2LfXjKMyULS3n 5CBwJkAWm0vxbZD5i+M/5MsdB4Z8DEI= MIME-Version: 1.0 Date: Mon, 25 May 2020 12:20:25 +0200 From: Michael Walle To: Bartosz Golaszewski Subject: Re: [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap In-Reply-To: References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-11-michael@walle.cc> <75bff2917be1badd36af9f980cf59d2c@walle.cc> User-Agent: Roundcube Webmail/1.4.4 Message-ID: <951244aab2ff553a463f7431ba09bf27@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_032044_583277_5FA45EED X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-devicetree , Linus Walleij , Thierry Reding , Lee Jones , Jason Cooper , Andy Shevchenko , Marc Zyngier , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Guenter Roeck , linux-pwm@vger.kernel.org, Jean Delvare , LINUXWATCHDOG , linux-gpio , Mark Brown , Thomas Gleixner , Wim Van Sebroeck , arm-soc , linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , LKML , Li Yang , Rob Herring , Shawn Guo Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gMjAyMC0wNS0yNSAxMTowNSwgc2NocmllYiBCYXJ0b3N6IEdvbGFzemV3c2tpOgo+IHd0Liwg MTIgbWFqIDIwMjAgbyAxNjo0MSBNaWNoYWVsIFdhbGxlIDxtaWNoYWVsQHdhbGxlLmNjPiBuYXBp c2HFgihhKToKPj4gCj4+ID4+ICsKPj4gPj4gK01PRFVMRV9BVVRIT1IoIk1pY2hhZWwgV2FsbGUg PG1pY2hhZWxAd2FsbGUuY2M+Iik7Cj4+ID4+ICtNT0RVTEVfREVTQ1JJUFRJT04oIkdQSU8gZ2Vu ZXJpYyByZWdtYXAgZHJpdmVyIGNvcmUiKTsKPj4gPj4gK01PRFVMRV9MSUNFTlNFKCJHUEwiKTsK Pj4gPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvZ3Bpby1yZWdtYXAuaCBiL2luY2x1ZGUv bGludXgvZ3Bpby1yZWdtYXAuaAo+PiA+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+PiA+PiBpbmRl eCAwMDAwMDAwMDAwMDAuLmE4NjhjYmNkZTZlOQo+PiA+PiAtLS0gL2Rldi9udWxsCj4+ID4+ICsr KyBiL2luY2x1ZGUvbGludXgvZ3Bpby1yZWdtYXAuaAo+PiA+PiBAQCAtMCwwICsxLDY5IEBACj4+ ID4+ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1vbmx5ICovCj4+ID4+ICsK Pj4gPj4gKyNpZm5kZWYgX0xJTlVYX0dQSU9fUkVHTUFQX0gKPj4gPj4gKyNkZWZpbmUgX0xJTlVY X0dQSU9fUkVHTUFQX0gKPj4gPj4gKwo+PiA+PiArc3RydWN0IGdwaW9fcmVnbWFwOwo+PiA+PiAr Cj4+ID4+ICsjZGVmaW5lIEdQSU9fUkVHTUFQX0FERFJfWkVSTyAoKHVuc2lnbmVkIGxvbmcpKC0x KSkKPj4gPj4gKyNkZWZpbmUgR1BJT19SRUdNQVBfQUREUihhZGRyKSAoKGFkZHIpID8gOiBHUElP X1JFR01BUF9BRERSX1pFUk8pCj4+ID4+ICsKPj4gPgo+PiA+IFdoYXQgaWYgdGhlIGFkZHIgaXMg YWN0dWFsbHkgMD8KPj4gCj4+IFRoZW4gdGhlIGRyaXZlciBoYXMgdG8gc2V0IEdQSU9fUkVHTUFQ X0FERFJfWkVSTyBvciB1c2UgdGhlIAo+PiBjb252ZW5pZW5jZQo+PiBtYWNybyBHUElPX1JFR01B UF9BRERSLgo+PiAKPj4gU28geW91IGNhbiBoYXZlCj4+IAo+PiAgICBzdHJ1Y3QgZ3Bpb19yZWdt YXBfY29uZmlnIGNvbmZpZyA9IHsgMCB9Owo+PiAgICBjb25maWcucmVnX2RhdF9iYXNlID0gMHgx MDsKPj4gICAgY29uZmlnLnJlZ19kaXJfb3V0X2Jhc2UgPSAweDIwOwo+PiAKPj4gb3IKPj4gCj4+ ICAgIGNvbmZpZy5yZWdfZGF0X2Jhc2UgPSBHUElPX1JFR01BUF9BRERSX1pFUk87Cj4+IAo+PiBv ciBpZiB5b3UgY2FuJ3QgYmUgc3VyZSBpZiB0aGUgUkhTIHZhbHVlIG1pZ2h0IGJlIHplcm86Cj4+ IAo+PiAgICBjb25maWcucmVnX2RhdF9iYXNlID0gR1BJT19SRUdNQVBfQUREUihyZWcpOwo+PiAK Pj4gCj4+ID4gTWF5YmUgZHJvcCBHUElPX1JFR01BUF9BRERSIGFuZCByZXF1aXJlIHVzZXJzIHRv IHNldCB1bnVzZWQgcmVnaXN0ZXJzCj4+ID4gdG8gR1BJT19SRUdNQVBfQUREUl9aRVJPPwo+PiAK Pj4gVGhhdHMgYmFkIGJlY2F1c2U6Cj4+ICAgKiB5b3UnZCBoYXZlIHRvIHNldCBwbGVudHkgb2Yg dW51c2VkIGJhc2UgcmVnaXN0ZXJzIGZvciBhIHNpbXBsZSAKPj4gZHJpdmVyCj4+ICAgKiBpZiB0 aGVyZSB3aWxsIGJlIGFkZGl0aW9uYWwgcHJvcGVydGllcyBpbiB0aGUgZnV0dXJlLCB5b3UgaGF2 ZSB0bwo+PiB0b3VjaAo+PiAgICAgYWxsIG90aGVyIGRyaXZlcnMsIGJlY2F1c2UgdGhleSBhcmUg aW5pdGlhbGl6ZWQgYXMgMCAoaWUuIHZhbGlkIAo+PiByZWcKPj4gMCkuCj4+IAo+PiA+PiArLyoq Cj4+ID4+ICsgKiBzdHJ1Y3QgZ3Bpb19yZWdtYXBfY29uZmlnIC0gRGVzY3JpcHRpb24gb2YgYSBn ZW5lcmljIHJlZ21hcAo+PiA+PiBncGlvX2NoaXAuCj4+ID4+ICsgKgo+PiA+PiArICogQHBhcmVu dDogICAgICAgICAgICBUaGUgcGFyZW50IGRldmljZQo+PiA+PiArICogQHJlZ21hcDogICAgICAg ICAgICBUaGUgcmVnbWFwIHVzZWQgdG8gYWNjZXNzIHRoZSByZWdpc3RlcnMKPj4gPj4gKyAqICAg ICAgICAgICAgICAgICAgICAgZ2l2ZW4sIHRoZSBuYW1lIG9mIHRoZSBkZXZpY2UgaXMgdXNlZAo+ PiA+PiArICogQGxhYmVsOiAgICAgICAgICAgICAoT3B0aW9uYWwpIERlc2NyaXB0aXZlIG5hbWUg Zm9yIEdQSU8KPj4gPj4gY29udHJvbGxlci4KPj4gPj4gKyAqICAgICAgICAgICAgICAgICAgICAg SWYgbm90IGdpdmVuLCB0aGUgbmFtZSBvZiB0aGUgZGV2aWNlIGlzIHVzZWQuCj4+ID4+ICsgKiBA bmdwaW86ICAgICAgICAgICAgIE51bWJlciBvZiBHUElPcwo+PiA+PiArICogQHJlZ19kYXRfYmFz ZTogICAgICAoT3B0aW9uYWwpIChpbikgcmVnaXN0ZXIgYmFzZSBhZGRyZXNzCj4+ID4+ICsgKiBA cmVnX3NldF9iYXNlOiAgICAgIChPcHRpb25hbCkgc2V0IHJlZ2lzdGVyIGJhc2UgYWRkcmVzcwo+ PiA+PiArICogQHJlZ19jbHJfYmFzZTogICAgICAoT3B0aW9uYWwpIGNsZWFyIHJlZ2lzdGVyIGJh c2UgYWRkcmVzcwo+PiA+PiArICogQHJlZ19kaXJfaW5fYmFzZTogICAoT3B0aW9uYWwpIG91dCBz ZXR0aW5nIHJlZ2lzdGVyIGJhc2UgYWRkcmVzcwo+PiA+PiArICogQHJlZ19kaXJfb3V0X2Jhc2U6 ICAoT3B0aW9uYWwpIGluIHNldHRpbmcgcmVnaXN0ZXIgYmFzZSBhZGRyZXNzCj4+ID4KPj4gPiBU aGUgdHdvIGFib3ZlIGFyZSBpbnZlcnRlZCBJIHRoaW5rPwo+PiBnb29kIGNhdGNoLgo+PiAKPj4g PiBBbHNvOiB3aHkgdGhlIGxpbWl0YXRpb24gb2Ygb25seSBzdXBwb3J0aW5nIG9uZSBhdCBhIHRp bWU/Cj4+IAo+PiB0aGV5IHNob3VsZCBiZSBleGNsdXNpdmUsIGVpdGhlciB5b3UgaGF2ZSBhIHJl Z2lzdGVyIHdoZXJlIHlvdSBzZXQgdGhlCj4+IG91dHB1dCBiaXRzIHRvIG9uZSwgb3IgdGhlIGlu cHV0IGJpdHMuIE1heWJlIHRoaXMgbmVlZCBhIGJpdCBtb3JlCj4+IGNvbnRleHQKPj4gYWJvdmUu IGluIGdwaW8tbW1pby5jIHlvdSBjYW4gc2V0IGJvdGggYW5kIGJvdGggYXJlIHVzZWQgaW4KPj4g c2V0X2RpcmVjdGlvbigpLCBidXQgb25seSBvbmUgaXMgcmVhZCBpbiBnZXRfZGlyZWN0aW9uKCku Cj4+IAo+PiBUaGF0IGJlaW5nIHNhaWQsIEkgaGF2ZSBubyBzdHJvbmcgb3BpbmlvbiB3ZXRoZXIg dGhleSBzaG91bGQgYmUKPj4gZXhjbHVzaXZlCj4+IG9yIG5vdCwgYmVzaWRlcyB0aGUgc3ltbWV0 cnkgb2Ygc2V0Xy9nZXRfZGlyZWN0aW9uKCkuCj4+IAo+PiAtbWljaGFlbAo+PiAKPiAKPiBTb3Jy eSBmb3IgdGhlIGxhdGUgcmVzcG9uc2UsIHlvdXIgY29tbWVudHMgbWFrZSBzZW5zZSB0byBtZS4g QXJlIHlvdQo+IGdvaW5nIHRvIHN1Ym1pdCBhIHY0IGJlZm9yZSB0aGUgdjUuOCBtZXJnZSB3aW5k b3c/CgpJJ20gY3VycmVudGx5IHN0dWNrIHdpdGggaG93IHRvIGhhbmRsZSB0aGUgTUZEIHBhcnQu IEllLiBSb2IgZG9lc24ndApzZWVtIHRvIGxpa2UgdGhlIGxvZ2ljaWFsIGRldmljZSBudW1iZXJp bmcgLSBvciBhdCBsZWFzdCB0aGVyZSB3YXNuJ3QKYW4gYW5zd2VyIHRvIHRoYXQgb25lIGFueW1v cmUsIHNlZSBwYXRjaCA1LzE2LgoKSWYgeW91IGxpa2UgSSBjb3VsZCBzdWJtaXQgdGhpcyBwYXRj aCBvbiBpdHMgb3duLiBCdXQgdGhlbiB0aGVyZQp3b3VsZG4ndCBiZSBhIHVzZXIgZm9yIGl0LgoK LW1pY2hhZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK