From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 219B8C433EF for ; Fri, 24 Dec 2021 07:07:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4BD6283693; Fri, 24 Dec 2021 08:07:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id B0C878369E; Fri, 24 Dec 2021 08:07:32 +0100 (CET) Received: from lucky1.263xmail.com (lucky1.263xmail.com [211.157.147.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1AEC98361E for ; Fri, 24 Dec 2021 08:07:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=kever.yang@rock-chips.com Received: from localhost (unknown [192.168.167.69]) by lucky1.263xmail.com (Postfix) with ESMTP id 2D939D8247 for ; Fri, 24 Dec 2021 15:07:25 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 0 X-ANTISPAM-LEVEL: 2 Received: from [192.168.60.65] (unknown [103.29.142.67]) by smtp.263.net (postfix) whith ESMTP id P6047T139645797992192S1640329639283257_; Fri, 24 Dec 2021 15:07:23 +0800 (CST) X-IP-DOMAINF: 1 X-RL-SENDER: kever.yang@rock-chips.com X-SENDER: yk@rock-chips.com X-LOGIN-NAME: kever.yang@rock-chips.com X-FST-TO: sjg@chromium.org X-RCPT-COUNT: 5 X-LOCAL-RCPT-COUNT: 0 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 103.29.142.67 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: X-System-Flag: 0 Subject: Re: [PATCH] rockchip: boot_mode: fix fastboot command To: John Keeping , u-boot@lists.denx.de Cc: Philipp Tomsich , Philipp Tomsich , Simon Glass References: <20211125180522.4113337-1-john@metanate.com> From: Kever Yang Message-ID: <951c970a-3d78-50b1-c162-497a83386628@rock-chips.com> Date: Fri, 24 Dec 2021 15:07:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211125180522.4113337-1-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021/11/26 上午2:05, John Keeping wrote: > The USB controller index must be separated from the type argument, > otherwise the preboot command fails with the error: > > Error: Wrong USB controller index format > > Add the missing space to fix fastboot mode here. > > Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever > --- > > arch/arm/mach-rockchip/boot_mode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c > index 2158934159..1a1a887fc2 100644 > --- a/arch/arm/mach-rockchip/boot_mode.c > +++ b/arch/arm/mach-rockchip/boot_mode.c > @@ -95,7 +95,7 @@ int setup_boot_mode(void) > switch (boot_mode) { > case BOOT_FASTBOOT: > debug("%s: enter fastboot!\n", __func__); > - env_set("preboot", "setenv preboot; fastboot usb0"); > + env_set("preboot", "setenv preboot; fastboot usb 0"); > break; > case BOOT_UMS: > debug("%s: enter UMS!\n", __func__);