From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00388C64E8A for ; Mon, 30 Nov 2020 07:10:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEF8D206D8 for ; Mon, 30 Nov 2020 07:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgK3HK4 (ORCPT ); Mon, 30 Nov 2020 02:10:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:39198 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbgK3HK4 (ORCPT ); Mon, 30 Nov 2020 02:10:56 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9CD36AC6A; Mon, 30 Nov 2020 07:10:14 +0000 (UTC) Subject: Re: [PATCH 15/45] block: change the hash used for looking up block devices To: Christoph Hellwig , Jens Axboe Cc: Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20201128161510.347752-1-hch@lst.de> <20201128161510.347752-16-hch@lst.de> From: Hannes Reinecke Message-ID: <9520bc81-43f6-889a-7e39-007f6f5ab9bf@suse.de> Date: Mon, 30 Nov 2020 08:10:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128161510.347752-16-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/28/20 5:14 PM, Christoph Hellwig wrote: > Adding the minor to the major creates tons of pointless conflicts. Just > use the dev_t itself, which is 32-bits and thus is guaranteed to fit > into ino_t. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jan Kara > Acked-by: Tejun Heo > --- > fs/block_dev.c | 26 ++------------------------ > 1 file changed, 2 insertions(+), 24 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index c5755150c6be62..d707ab376da86e 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -863,35 +863,12 @@ void __init bdev_cache_init(void) > blockdev_superblock = bd_mnt->mnt_sb; /* For writeback */ > } > > -/* > - * Most likely _very_ bad one - but then it's hardly critical for small > - * /dev and can be fixed when somebody will need really large one. > - * Keep in mind that it will be fed through icache hash function too. > - */ > -static inline unsigned long hash(dev_t dev) > -{ > - return MAJOR(dev)+MINOR(dev); > -} > - > -static int bdev_test(struct inode *inode, void *data) > -{ > - return BDEV_I(inode)->bdev.bd_dev == *(dev_t *)data; > -} > - > -static int bdev_set(struct inode *inode, void *data) > -{ > - BDEV_I(inode)->bdev.bd_dev = *(dev_t *)data; > - return 0; > -} > - > static struct block_device *bdget(dev_t dev) > { > struct block_device *bdev; > struct inode *inode; > > - inode = iget5_locked(blockdev_superblock, hash(dev), > - bdev_test, bdev_set, &dev); > - > + inode = iget_locked(blockdev_superblock, dev); > if (!inode) > return NULL; > > @@ -903,6 +880,7 @@ static struct block_device *bdget(dev_t dev) > bdev->bd_super = NULL; > bdev->bd_inode = inode; > bdev->bd_part_count = 0; > + bdev->bd_dev = dev; > inode->i_mode = S_IFBLK; > inode->i_rdev = dev; > inode->i_bdev = bdev; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7391FC63777 for ; Mon, 30 Nov 2020 07:10:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3FFD206CA for ; Mon, 30 Nov 2020 07:10:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dky1WS70" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3FFD206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=suNXghP3V+nFX+8iRbPEWtLY7OWvqk/qqnpVAlP5tWc=; b=Dky1WS7040J/MmahfFvL+NHim TjB8YeQmzJcl984BQ5TDtGB9DRO24TcSWyPUur4HoAfyfxMye+RB+AM9uqQ8bZRzsslk8fsbxV3V+ 2re4EVGw4RQYbz+07XRH7UOcjSliWFzVMyzsPTg5BgOucRedlvBUgee9Z18WY4vKtc4gYDeLN2kMI D3fH5Mv0/lvA0qYJs0SqkuvXIDC2Dh4O8e3Z4l8GULfc7qHEsnQSancCwTnKyL/u458sKwy8CQdGB 1GDwiI0AYJM7l+VFyeMUyCtpqCCmvBUWIT4/ISIqqtHcKBK72TETYHNXacJVsP4jmYyjeL8RVSDRy PGcGNtnjg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjdKF-00032z-Et; Mon, 30 Nov 2020 07:10:20 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjdKB-00030h-VD for linux-mtd@lists.infradead.org; Mon, 30 Nov 2020 07:10:17 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9CD36AC6A; Mon, 30 Nov 2020 07:10:14 +0000 (UTC) Subject: Re: [PATCH 15/45] block: change the hash used for looking up block devices To: Christoph Hellwig , Jens Axboe References: <20201128161510.347752-1-hch@lst.de> <20201128161510.347752-16-hch@lst.de> From: Hannes Reinecke Message-ID: <9520bc81-43f6-889a-7e39-007f6f5ab9bf@suse.de> Date: Mon, 30 Nov 2020 08:10:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128161510.347752-16-hch@lst.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_021016_188370_0D1EBC85 X-CRM114-Status: GOOD ( 25.48 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-bcache@vger.kernel.org, Jan Kara , Mike Snitzer , linux-mm@kvack.org, Greg Kroah-Hartman , Jan Kara , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , Tejun Heo Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMTEvMjgvMjAgNToxNCBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gQWRkaW5nIHRo ZSBtaW5vciB0byB0aGUgbWFqb3IgY3JlYXRlcyB0b25zIG9mIHBvaW50bGVzcyBjb25mbGljdHMu IEp1c3QKPiB1c2UgdGhlIGRldl90IGl0c2VsZiwgd2hpY2ggaXMgMzItYml0cyBhbmQgdGh1cyBp cyBndWFyYW50ZWVkIHRvIGZpdAo+IGludG8gaW5vX3QuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hy aXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+Cj4gUmV2aWV3ZWQtYnk6IEdyZWcgS3JvYWgtSGFy dG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gUmV2aWV3ZWQtYnk6IEphbiBLYXJh IDxqYWNrQHN1c2UuY3o+Cj4gQWNrZWQtYnk6IFRlanVuIEhlbyA8dGpAa2VybmVsLm9yZz4KPiAt LS0KPiAgIGZzL2Jsb2NrX2Rldi5jIHwgMjYgKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9mcy9ibG9ja19kZXYuYyBiL2ZzL2Jsb2NrX2Rldi5jCj4gaW5kZXggYzU3NTUx NTBjNmJlNjIuLmQ3MDdhYjM3NmRhODZlIDEwMDY0NAo+IC0tLSBhL2ZzL2Jsb2NrX2Rldi5jCj4g KysrIGIvZnMvYmxvY2tfZGV2LmMKPiBAQCAtODYzLDM1ICs4NjMsMTIgQEAgdm9pZCBfX2luaXQg YmRldl9jYWNoZV9pbml0KHZvaWQpCj4gICAJYmxvY2tkZXZfc3VwZXJibG9jayA9IGJkX21udC0+ bW50X3NiOyAgIC8qIEZvciB3cml0ZWJhY2sgKi8KPiAgIH0KPiAgIAo+IC0vKgo+IC0gKiBNb3N0 IGxpa2VseSBfdmVyeV8gYmFkIG9uZSAtIGJ1dCB0aGVuIGl0J3MgaGFyZGx5IGNyaXRpY2FsIGZv ciBzbWFsbAo+IC0gKiAvZGV2IGFuZCBjYW4gYmUgZml4ZWQgd2hlbiBzb21lYm9keSB3aWxsIG5l ZWQgcmVhbGx5IGxhcmdlIG9uZS4KPiAtICogS2VlcCBpbiBtaW5kIHRoYXQgaXQgd2lsbCBiZSBm ZWQgdGhyb3VnaCBpY2FjaGUgaGFzaCBmdW5jdGlvbiB0b28uCj4gLSAqLwo+IC1zdGF0aWMgaW5s aW5lIHVuc2lnbmVkIGxvbmcgaGFzaChkZXZfdCBkZXYpCj4gLXsKPiAtCXJldHVybiBNQUpPUihk ZXYpK01JTk9SKGRldik7Cj4gLX0KPiAtCj4gLXN0YXRpYyBpbnQgYmRldl90ZXN0KHN0cnVjdCBp bm9kZSAqaW5vZGUsIHZvaWQgKmRhdGEpCj4gLXsKPiAtCXJldHVybiBCREVWX0koaW5vZGUpLT5i ZGV2LmJkX2RldiA9PSAqKGRldl90ICopZGF0YTsKPiAtfQo+IC0KPiAtc3RhdGljIGludCBiZGV2 X3NldChzdHJ1Y3QgaW5vZGUgKmlub2RlLCB2b2lkICpkYXRhKQo+IC17Cj4gLQlCREVWX0koaW5v ZGUpLT5iZGV2LmJkX2RldiA9ICooZGV2X3QgKilkYXRhOwo+IC0JcmV0dXJuIDA7Cj4gLX0KPiAt Cj4gICBzdGF0aWMgc3RydWN0IGJsb2NrX2RldmljZSAqYmRnZXQoZGV2X3QgZGV2KQo+ICAgewo+ ICAgCXN0cnVjdCBibG9ja19kZXZpY2UgKmJkZXY7Cj4gICAJc3RydWN0IGlub2RlICppbm9kZTsK PiAgIAo+IC0JaW5vZGUgPSBpZ2V0NV9sb2NrZWQoYmxvY2tkZXZfc3VwZXJibG9jaywgaGFzaChk ZXYpLAo+IC0JCQliZGV2X3Rlc3QsIGJkZXZfc2V0LCAmZGV2KTsKPiAtCj4gKwlpbm9kZSA9IGln ZXRfbG9ja2VkKGJsb2NrZGV2X3N1cGVyYmxvY2ssIGRldik7Cj4gICAJaWYgKCFpbm9kZSkKPiAg IAkJcmV0dXJuIE5VTEw7Cj4gICAKPiBAQCAtOTAzLDYgKzg4MCw3IEBAIHN0YXRpYyBzdHJ1Y3Qg YmxvY2tfZGV2aWNlICpiZGdldChkZXZfdCBkZXYpCj4gICAJCWJkZXYtPmJkX3N1cGVyID0gTlVM TDsKPiAgIAkJYmRldi0+YmRfaW5vZGUgPSBpbm9kZTsKPiAgIAkJYmRldi0+YmRfcGFydF9jb3Vu dCA9IDA7Cj4gKwkJYmRldi0+YmRfZGV2ID0gZGV2Owo+ICAgCQlpbm9kZS0+aV9tb2RlID0gU19J RkJMSzsKPiAgIAkJaW5vZGUtPmlfcmRldiA9IGRldjsKPiAgIAkJaW5vZGUtPmlfYmRldiA9IGJk ZXY7Cj4gClJldmlld2VkLWJ5OiBIYW5uZXMgUmVpbmVja2UgPGhhcmVAc3VzZS5kZT4KCkNoZWVy cywKCkhhbm5lcwotLSAKRHIuIEhhbm5lcyBSZWluZWNrZSAgICAgICAgICAgICAgICBLZXJuZWwg U3RvcmFnZSBBcmNoaXRlY3QKaGFyZUBzdXNlLmRlICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKzQ5IDkxMSA3NDA1MyA2ODgKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR21iSCwgTWF4ZmVs ZHN0ci4gNSwgOTA0MDkgTsO8cm5iZXJnCkhSQiAzNjgwOSAoQUcgTsO8cm5iZXJnKSwgR2VzY2jD pGZ0c2bDvGhyZXI6IEZlbGl4IEltZW5kw7ZyZmZlcgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxp bmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96532C63777 for ; Mon, 30 Nov 2020 07:10:33 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0222E206CA for ; Mon, 30 Nov 2020 07:10:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0222E206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-ePJwFk9bP96qbEru3DR5dA-1; Mon, 30 Nov 2020 02:10:29 -0500 X-MC-Unique: ePJwFk9bP96qbEru3DR5dA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD2F6802B42; Mon, 30 Nov 2020 07:10:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CB125C1BB; Mon, 30 Nov 2020 07:10:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6BF641809C9F; Mon, 30 Nov 2020 07:10:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AU7ANbC021751 for ; Mon, 30 Nov 2020 02:10:23 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1C358200A4F0; Mon, 30 Nov 2020 07:10:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 178972026D49 for ; Mon, 30 Nov 2020 07:10:20 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BEE89103B807 for ; Mon, 30 Nov 2020 07:10:20 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-uduJrjcOO_alhKwz16w3zQ-1; Mon, 30 Nov 2020 02:10:16 -0500 X-MC-Unique: uduJrjcOO_alhKwz16w3zQ-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9CD36AC6A; Mon, 30 Nov 2020 07:10:14 +0000 (UTC) To: Christoph Hellwig , Jens Axboe References: <20201128161510.347752-1-hch@lst.de> <20201128161510.347752-16-hch@lst.de> From: Hannes Reinecke Message-ID: <9520bc81-43f6-889a-7e39-007f6f5ab9bf@suse.de> Date: Mon, 30 Nov 2020 08:10:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128161510.347752-16-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 0AU7ANbC021751 X-loop: dm-devel@redhat.com Cc: linux-bcache@vger.kernel.org, Jan Kara , Mike Snitzer , linux-mm@kvack.org, Greg Kroah-Hartman , Jan Kara , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , Tejun Heo Subject: Re: [dm-devel] [PATCH 15/45] block: change the hash used for looking up block devices X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" T24gMTEvMjgvMjAgNToxNCBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gQWRkaW5nIHRo ZSBtaW5vciB0byB0aGUgbWFqb3IgY3JlYXRlcyB0b25zIG9mIHBvaW50bGVzcyBjb25mbGljdHMu IEp1c3QKPiB1c2UgdGhlIGRldl90IGl0c2VsZiwgd2hpY2ggaXMgMzItYml0cyBhbmQgdGh1cyBp cyBndWFyYW50ZWVkIHRvIGZpdAo+IGludG8gaW5vX3QuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hy aXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+Cj4gUmV2aWV3ZWQtYnk6IEdyZWcgS3JvYWgtSGFy dG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gUmV2aWV3ZWQtYnk6IEphbiBLYXJh IDxqYWNrQHN1c2UuY3o+Cj4gQWNrZWQtYnk6IFRlanVuIEhlbyA8dGpAa2VybmVsLm9yZz4KPiAt LS0KPiAgIGZzL2Jsb2NrX2Rldi5jIHwgMjYgKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9mcy9ibG9ja19kZXYuYyBiL2ZzL2Jsb2NrX2Rldi5jCj4gaW5kZXggYzU3NTUx NTBjNmJlNjIuLmQ3MDdhYjM3NmRhODZlIDEwMDY0NAo+IC0tLSBhL2ZzL2Jsb2NrX2Rldi5jCj4g KysrIGIvZnMvYmxvY2tfZGV2LmMKPiBAQCAtODYzLDM1ICs4NjMsMTIgQEAgdm9pZCBfX2luaXQg YmRldl9jYWNoZV9pbml0KHZvaWQpCj4gICAJYmxvY2tkZXZfc3VwZXJibG9jayA9IGJkX21udC0+ bW50X3NiOyAgIC8qIEZvciB3cml0ZWJhY2sgKi8KPiAgIH0KPiAgIAo+IC0vKgo+IC0gKiBNb3N0 IGxpa2VseSBfdmVyeV8gYmFkIG9uZSAtIGJ1dCB0aGVuIGl0J3MgaGFyZGx5IGNyaXRpY2FsIGZv ciBzbWFsbAo+IC0gKiAvZGV2IGFuZCBjYW4gYmUgZml4ZWQgd2hlbiBzb21lYm9keSB3aWxsIG5l ZWQgcmVhbGx5IGxhcmdlIG9uZS4KPiAtICogS2VlcCBpbiBtaW5kIHRoYXQgaXQgd2lsbCBiZSBm ZWQgdGhyb3VnaCBpY2FjaGUgaGFzaCBmdW5jdGlvbiB0b28uCj4gLSAqLwo+IC1zdGF0aWMgaW5s aW5lIHVuc2lnbmVkIGxvbmcgaGFzaChkZXZfdCBkZXYpCj4gLXsKPiAtCXJldHVybiBNQUpPUihk ZXYpK01JTk9SKGRldik7Cj4gLX0KPiAtCj4gLXN0YXRpYyBpbnQgYmRldl90ZXN0KHN0cnVjdCBp bm9kZSAqaW5vZGUsIHZvaWQgKmRhdGEpCj4gLXsKPiAtCXJldHVybiBCREVWX0koaW5vZGUpLT5i ZGV2LmJkX2RldiA9PSAqKGRldl90ICopZGF0YTsKPiAtfQo+IC0KPiAtc3RhdGljIGludCBiZGV2 X3NldChzdHJ1Y3QgaW5vZGUgKmlub2RlLCB2b2lkICpkYXRhKQo+IC17Cj4gLQlCREVWX0koaW5v ZGUpLT5iZGV2LmJkX2RldiA9ICooZGV2X3QgKilkYXRhOwo+IC0JcmV0dXJuIDA7Cj4gLX0KPiAt Cj4gICBzdGF0aWMgc3RydWN0IGJsb2NrX2RldmljZSAqYmRnZXQoZGV2X3QgZGV2KQo+ICAgewo+ ICAgCXN0cnVjdCBibG9ja19kZXZpY2UgKmJkZXY7Cj4gICAJc3RydWN0IGlub2RlICppbm9kZTsK PiAgIAo+IC0JaW5vZGUgPSBpZ2V0NV9sb2NrZWQoYmxvY2tkZXZfc3VwZXJibG9jaywgaGFzaChk ZXYpLAo+IC0JCQliZGV2X3Rlc3QsIGJkZXZfc2V0LCAmZGV2KTsKPiAtCj4gKwlpbm9kZSA9IGln ZXRfbG9ja2VkKGJsb2NrZGV2X3N1cGVyYmxvY2ssIGRldik7Cj4gICAJaWYgKCFpbm9kZSkKPiAg IAkJcmV0dXJuIE5VTEw7Cj4gICAKPiBAQCAtOTAzLDYgKzg4MCw3IEBAIHN0YXRpYyBzdHJ1Y3Qg YmxvY2tfZGV2aWNlICpiZGdldChkZXZfdCBkZXYpCj4gICAJCWJkZXYtPmJkX3N1cGVyID0gTlVM TDsKPiAgIAkJYmRldi0+YmRfaW5vZGUgPSBpbm9kZTsKPiAgIAkJYmRldi0+YmRfcGFydF9jb3Vu dCA9IDA7Cj4gKwkJYmRldi0+YmRfZGV2ID0gZGV2Owo+ICAgCQlpbm9kZS0+aV9tb2RlID0gU19J RkJMSzsKPiAgIAkJaW5vZGUtPmlfcmRldiA9IGRldjsKPiAgIAkJaW5vZGUtPmlfYmRldiA9IGJk ZXY7Cj4gClJldmlld2VkLWJ5OiBIYW5uZXMgUmVpbmVja2UgPGhhcmVAc3VzZS5kZT4KCkNoZWVy cywKCkhhbm5lcwotLSAKRHIuIEhhbm5lcyBSZWluZWNrZSAgICAgICAgICAgICAgICBLZXJuZWwg U3RvcmFnZSBBcmNoaXRlY3QKaGFyZUBzdXNlLmRlICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKzQ5IDkxMSA3NDA1MyA2ODgKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR21iSCwgTWF4ZmVs ZHN0ci4gNSwgOTA0MDkgTsO8cm5iZXJnCkhSQiAzNjgwOSAoQUcgTsO8cm5iZXJnKSwgR2VzY2jD pGZ0c2bDvGhyZXI6IEZlbGl4IEltZW5kw7ZyZmZlcgoKCi0tCmRtLWRldmVsIG1haWxpbmcgbGlz dApkbS1kZXZlbEByZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5jb20vbWFpbG1hbi9saXN0 aW5mby9kbS1kZXZlbA==