From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59331C56202 for ; Thu, 26 Nov 2020 07:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F08A20872 for ; Thu, 26 Nov 2020 07:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388255AbgKZHFC (ORCPT ); Thu, 26 Nov 2020 02:05:02 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:7991 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388248AbgKZHFC (ORCPT ); Thu, 26 Nov 2020 02:05:02 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4ChTK73XWYzhhl6; Thu, 26 Nov 2020 15:04:43 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 26 Nov 2020 15:04:56 +0800 Subject: Re: [PATCH 2/9] f2fs: remove f2fs_dir_open() To: Eric Biggers , CC: , , , References: <20201125002336.274045-1-ebiggers@kernel.org> <20201125002336.274045-3-ebiggers@kernel.org> From: Chao Yu Message-ID: <9522461b-b854-76ac-29c7-160f0f078823@huawei.com> Date: Thu, 26 Nov 2020 15:04:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201125002336.274045-3-ebiggers@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On 2020/11/25 8:23, Eric Biggers wrote: > From: Eric Biggers > > Since encrypted directories can be opened without their encryption key > being available, and each readdir tries to set up the key, trying to set readdir -> readdir/lookup? > up the key in ->open() too isn't really useful. > > Just remove it so that directories don't need an ->open() method > anymore, and so that we eliminate a use of fscrypt_get_encryption_info() > (which I'd like to stop exporting to filesystems). > > Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5D2C63777 for ; Thu, 26 Nov 2020 07:05:37 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CCF220872; Thu, 26 Nov 2020 07:05:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="QOMluqkT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="m/DxlAvz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CCF220872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kiBLT-0005U2-Pr; Thu, 26 Nov 2020 07:05:35 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiBLT-0005Tv-By for linux-f2fs-devel@lists.sourceforge.net; Thu, 26 Nov 2020 07:05:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+2uWi4z4Wlf1VXLPSu+J9lzezHiGWHAbNt3wIxtGuTk=; b=QOMluqkTNTtcb8i0cxAwgm4EA7 lT6nFAK6eLxf8fpGXGG1mekR8HnaIsp2th1/fcU6LBN94OHXlFCInqjoSr7lEeMraxuYV/fTKDkd5 dQSQr2ya0c7s5gEGVhnKvaZEBHe9di+4ly/I4qBzFzOyQ7MpB9EQPlG+5XrCfN554ZgE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+2uWi4z4Wlf1VXLPSu+J9lzezHiGWHAbNt3wIxtGuTk=; b=m/DxlAvz7pLxTtR/oPXgijMbg4 5Sd2wvoT9HcYZHbghERXG5t3yotSQNVdQOQJlInSbiX0GOAFyhMx2j7K/PNHA0S0IFkk289GgONDT HD0AaXXbv2QR/jLlYqSm2o9Vt0VaJU6RZ9K9JsOVvKX6D2zzmZFtWnyi+YuJBpZzgW3w=; Received: from szxga06-in.huawei.com ([45.249.212.32]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kiBLI-00Gm2q-T7 for linux-f2fs-devel@lists.sourceforge.net; Thu, 26 Nov 2020 07:05:35 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4ChTK73XWYzhhl6; Thu, 26 Nov 2020 15:04:43 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 26 Nov 2020 15:04:56 +0800 To: Eric Biggers , References: <20201125002336.274045-1-ebiggers@kernel.org> <20201125002336.274045-3-ebiggers@kernel.org> From: Chao Yu Message-ID: <9522461b-b854-76ac-29c7-160f0f078823@huawei.com> Date: Thu, 26 Nov 2020 15:04:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201125002336.274045-3-ebiggers@kernel.org> Content-Language: en-US X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected X-Headers-End: 1kiBLI-00Gm2q-T7 Subject: Re: [f2fs-dev] [PATCH 2/9] f2fs: remove f2fs_dir_open() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mtd@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/11/25 8:23, Eric Biggers wrote: > From: Eric Biggers > > Since encrypted directories can be opened without their encryption key > being available, and each readdir tries to set up the key, trying to set readdir -> readdir/lookup? > up the key in ->open() too isn't really useful. > > Just remove it so that directories don't need an ->open() method > anymore, and so that we eliminate a use of fscrypt_get_encryption_info() > (which I'd like to stop exporting to filesystems). > > Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB5AC56202 for ; Thu, 26 Nov 2020 07:06:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7108F20872 for ; Thu, 26 Nov 2020 07:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBZIJlWf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7108F20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CjILsjkrUzosjh/0kRqYhnaYFn33NCYzA4QG+341me4=; b=PBZIJlWf3lYiiivUZA8Uz5HUj 5oYp0pTCxSyfrktUSKfYeUqveIQjP4o5fsjc1ltH66ZFwjz4KJM/46uDHQayNGqyzOeYBeDzm7muc lKQ5LweHjHHP9WZTX8mihMf+czeeTpv/4/qme/rdhEZ9Xl4li8FLBDYQdb2GVcYepqhtCHrr8o3a+ pThwaSCdtWvSia7YvhilYHszi7NaHI1T4VKYiReiJ+hUlqbqgB9dcs59E7+jsy12Fjb5PTKky1YBa 6CLGodZXRvcrmYhldB54AINVgQlpChchlcw586Ha6lgPrGqwSsCs3fhdjMyUTttlJy6cQI8zNqE78 WXy8yRZ9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiBLH-0001R3-3z; Thu, 26 Nov 2020 07:05:23 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiBLD-0001Pd-6O for linux-mtd@lists.infradead.org; Thu, 26 Nov 2020 07:05:21 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4ChTK73XWYzhhl6; Thu, 26 Nov 2020 15:04:43 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 26 Nov 2020 15:04:56 +0800 Subject: Re: [PATCH 2/9] f2fs: remove f2fs_dir_open() To: Eric Biggers , References: <20201125002336.274045-1-ebiggers@kernel.org> <20201125002336.274045-3-ebiggers@kernel.org> From: Chao Yu Message-ID: <9522461b-b854-76ac-29c7-160f0f078823@huawei.com> Date: Thu, 26 Nov 2020 15:04:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201125002336.274045-3-ebiggers@kernel.org> Content-Language: en-US X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_020519_541466_73EA3370 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mtd@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 2020/11/25 8:23, Eric Biggers wrote: > From: Eric Biggers > > Since encrypted directories can be opened without their encryption key > being available, and each readdir tries to set up the key, trying to set readdir -> readdir/lookup? > up the key in ->open() too isn't really useful. > > Just remove it so that directories don't need an ->open() method > anymore, and so that we eliminate a use of fscrypt_get_encryption_info() > (which I'd like to stop exporting to filesystems). > > Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks, ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/