Re: [docs] [PATCH 1/5] Makefile/set_versions: Allow poky.yaml to be autogenerated

[Quentin Schulz <quentin.schulz@theobroma-systems.com>]

Hi Michael,

On 3/23/22 10:46, Michael Opdenacker via lists.yoctoproject.org wrote:
> Hi Richard,
> 
> On 3/21/22 18:44, Richard Purdie wrote:
>> Use a script to generate the branch/tag information inside poky.yaml.
>>
>> If the branch isn't a known release branch, include git magic to find
>> the closest matching release branch we know about.
>>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>>   documentation/.gitignore                  |   1 +
>>   documentation/Makefile                    |   1 +
>>   documentation/{poky.yaml => poky.yaml.in} |   0
>>   documentation/set_versions.py             | 115 ++++++++++++++++++++++
>>   4 files changed, 117 insertions(+)
>>   rename documentation/{poky.yaml => poky.yaml.in} (100%)
>>   create mode 100755 documentation/set_versions.py
> 
> A minor issue here: "make clean"  doesn't remove "documentation/poky.yaml" .
> 

This is technically not an issue because open("poky.yaml", "w") 
overwrites the file if it already exists.

Though, we should make sure the run-docs-build script in 
yocto-autobuilder-helper repo actually runs git clean -ffdx before 
checking out another branch otherwise there can be a conflict because 
poky.yaml exists locally and would be overridden/overwritten by 
poky.yaml from an earlier release and fail the checkout. IIRC Richard 
had that in his patch so we should be good.

> What do you prefer? I submit a fix later and we can merge the branch, or
> you propose an update, at least for this patch?

I feel like a fixup patch is just fine, does not seem to be a blocker?

Cheers,
Quentin