From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 2/2] nvme: start keep alive timer when enabling the controller
Date: Sun, 15 Apr 2018 13:17:58 +0300 [thread overview]
Message-ID: <9529fb23-ba35-0f41-7eda-2439612e1cd6@grimberg.me> (raw)
In-Reply-To: <fe43038e-001c-7468-be66-3df96d9d95e0@mellanox.com>
> Christoph suggested to add the keep-alive stop to the disable/shutdown
> (I guess we need to add it to both, right ?) and in the target side to
> start expecting also once ctrl is enabled and stop when disabled.
I don't necessarily think we need to. Also, its better to do this sooner
rather than later (stop_ctrl happens before disable/shutdown) and also,
disable/shutdown might not even execute if the transport is not connected.
next prev parent reply other threads:[~2018-04-15 10:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 8:47 [PATCH 1/2] nvmet: reset keep alive timer in controller enable Sagi Grimberg
2018-04-15 8:47 ` [PATCH 2/2] nvme: start keep alive timer when enabling the controller Sagi Grimberg
2018-04-15 9:23 ` Max Gurtovoy
2018-04-15 10:17 ` Sagi Grimberg [this message]
2018-04-17 15:24 ` Christoph Hellwig
2018-04-23 10:08 ` Max Gurtovoy
2018-04-29 12:11 ` [Suspected-Phishing]Re: " Max Gurtovoy
2018-06-17 10:26 ` Max Gurtovoy
2018-06-19 5:42 ` Christoph Hellwig
2018-04-16 16:45 ` James Smart
2018-04-16 16:45 ` [PATCH 1/2] nvmet: reset keep alive timer in controller enable James Smart
2018-04-17 15:24 ` Christoph Hellwig
2018-04-22 14:26 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9529fb23-ba35-0f41-7eda-2439612e1cd6@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.