Re: [PATCH v2 linux dev-5.3 3/4] ARM: dts: aspeed-g6: Add lpc devices

[Brad Bishop <bradleyb@fuzziesquirrel.com>]

at 2:37 AM, Andrew Jeffery <andrew@aj.id.au> wrote:

>
>
> On Fri, 20 Sep 2019, at 00:53, Brad Bishop wrote:
>> Assume everything is the same as G5, except the interrupt is updated.
>>
>> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
>> ---
>>  arch/arm/boot/dts/aspeed-g6.dtsi | 91 ++++++++++++++++++++++++++++++++
>>  1 file changed, 91 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi  
>> b/arch/arm/boot/dts/aspeed-g6.dtsi
>> index 72038c16f541..b4991cbe1f36 100644
>> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
>> @@ -249,6 +249,97 @@
>>  				status = "disabled";
>>  			};
>>
>> +			lpc: lpc@1e789000 {
>> +				compatible = "aspeed,ast2600-lpc", "simple-mfd";
>> +				reg = <0x1e789000 0x1000>;
>> +
>> +				#address-cells = <1>;
>> +				#size-cells = <1>;
>> +				ranges = <0x0 0x1e789000 0x1000>;
>> +
>> +				lpc_bmc: lpc-bmc@0 {
>> +					compatible = "aspeed,ast2600-lpc-bmc", "simple-mfd", "syscon";
>> +					reg = <0x0 0x80>;
>> +					reg-io-width = <4>;
>> +
>> +					#address-cells = <1>;
>> +					#size-cells = <1>;
>> +					ranges = <0x0 0x0 0x80>;
>> +
>> +					kcs1: kcs1@0 {
>> +						compatible = "aspeed,ast2600-kcs-bmc";
>> +						interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> +						kcs_chan = <1>;
>> +						status = "disabled";
>> +					};
>> +					kcs2: kcs2@0 {
>> +						compatible = "aspeed,ast2600-kcs-bmc";
>> +						interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> +						kcs_chan = <2>;
>> +						status = "disabled";
>> +					};
>> +					kcs3: kcs3@0 {
>> +						compatible = "aspeed,ast2600-kcs-bmc";
>> +						interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> +						kcs_chan = <3>;
>> +						status = "disabled";
>> +					};
>> +				};
>> +
>> +				lpc_host: lpc-host@80 {
>> +					compatible = "aspeed,ast2600-lpc-host", "simple-mfd", "syscon";
>> +					reg = <0x80 0x1e0>;
>> +					reg-io-width = <4>;
>> +
>> +					#address-cells = <1>;
>> +					#size-cells = <1>;
>> +					ranges = <0x0 0x80 0x1e0>;
>> +
>> +					kcs4: kcs4@0 {
>> +						compatible = "aspeed,ast2600-kcs-bmc";
>> +						interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> +						kcs_chan = <4>;
>> +						status = "disabled";
>> +					};
>
> I've got some patches floating around that I need to respin that adjust  
> the kcs binding.
> The new dtsi with the existing binding means we're going to increase the  
> amplification
> of dtc warnings :(
>
>> +
>> +					lpc_ctrl: lpc-ctrl@0 {
>> +						compatible = "aspeed,ast2600-lpc-ctrl";
>> +						reg = <0x0 0x80>;
>> +						clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
>> +						status = "disabled";
>> +					};
>> +
>> +					lpc_snoop: lpc-snoop@0 {
>> +						compatible = "aspeed,ast2600-lpc-snoop";
>> +						reg = <0x0 0x80>;
>> +						interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> +						status = "disabled";
>> +					};
>> +
>> +					lhc: lhc@20 {
>> +						compatible = "aspeed,ast2600-lhc";
>> +						reg = <0x20 0x24 0x48 0x8>;
>> +					};
>> +
>> +					lpc_reset: reset-controller@18 {
>> +						compatible = "aspeed,ast2600-lpc-reset";
>> +						reg = <0x18 0x4>;
>> +						#reset-cells = <1>;
>> +					};
>> +
>> +					ibt: ibt@c0 {
>> +						compatible = "aspeed,ast2600-ibt-bmc";
>> +						reg = <0xc0 0x18>;
>> +						interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> +						status = "disabled";
>> +					};
>> +
>> +					sio_regs: regs {
>> +						compatible = "aspeed,bmc-misc";
>> +					};
>
> Can you please split the sio_regs one out to a separate patch?

Split in v3.

> The necessary patches got nak'ed upstream a while back and I haven't  
> circled back around
> to implement something more palatable. Put the patch adding it at the top  
> of
> your series, then you can send the earlier ones upstream.
>
> Andrew