From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Date: Sat, 18 Mar 2017 13:30:51 +0100 Message-ID: <9545c361-61e2-0d93-c5a6-c0b3837e1c8d@grandegger.com> References: <1484680922-25813-1-git-send-email-akshay.bhat@timesys.com> <1484680922-25813-2-git-send-email-akshay.bhat@timesys.com> <234d9e75-0083-b8b4-c781-add653fdb550@grandegger.com> <3dbf8748-9d04-0f21-0e95-448d7a72e7d5@timesys.com> <41439729-42d0-d883-2801-2d3607f2aeab@grandegger.com> <3dba0948-ffcb-8e80-fb32-62bb0aca6627@grandegger.com> <54d9a104-8ed1-4bb3-666e-042d3781dbfb@timesys.com> <006d9e14-47bf-1add-97c3-24098b43267f@grandegger.com> <69173747-cc2e-55f7-acad-4b5ba2a22863@timesys.com> <0362316b-ef76-1733-dbfc-8b644f758db9@timesys.com> <7730cff6-6e85-c98d-0315-bd3888d3aeb1@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Akshay Bhat , Akshay Bhat Cc: mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-can.vger.kernel.org Hello Akshay, Am 17.03.2017 um 19:28 schrieb Akshay Bhat: > Hi Wolfgang, > > On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: >> >> Hm, that's unusual. Cable disconnected and then send a message: >> >> $ grep /proc/interrupts; sleep 10; /proc/interrupts >> >> should make things clear. But maybe it's a clever chip and it does stop >> sending error messages if the error counter does not change any more. >> After bus-off, the chip is quiet, of course. Should have a closer look >> to the CAN standard. >> > > The interrupt count does not increment after device reaches > tx-error-passive (with cable disconnected). > > # while true; do grep -i hi3110 /proc/interrupts; sleep 10; done & > [1] 793 > # > 111: 0 0 gpio-mxc 12 Edge hi3110 > # candump -t d -e any,0:0,#FFFFFFF & > [2] 798 > # cansend can0 123# > # > (000.000000) can0 20000004 [8] 00 08 00 00 00 00 60 00 ERRORFRAME > controller-problem{tx-error-warning} > error-counter-tx-rx{{96}{0}} > (000.002122) can0 20000004 [8] 00 20 00 00 00 00 80 00 ERRORFRAME > controller-problem{tx-error-passive} > error-counter-tx-rx{{128}{0}} > 111: 10 0 gpio-mxc 12 Edge hi3110 > 111: 10 0 gpio-mxc 12 Edge hi3110 > 111: 10 0 gpio-mxc 12 Edge hi3110 OK, then there is no good reason connecting the STAT interrupt pin. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751583AbdCRMbU (ORCPT ); Sat, 18 Mar 2017 08:31:20 -0400 Received: from mailproxy01.manitu.net ([217.11.48.65]:54348 "EHLO mailproxy01.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdCRMbS (ORCPT ); Sat, 18 Mar 2017 08:31:18 -0400 Subject: Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver To: Akshay Bhat , Akshay Bhat References: <1484680922-25813-1-git-send-email-akshay.bhat@timesys.com> <1484680922-25813-2-git-send-email-akshay.bhat@timesys.com> <234d9e75-0083-b8b4-c781-add653fdb550@grandegger.com> <3dbf8748-9d04-0f21-0e95-448d7a72e7d5@timesys.com> <41439729-42d0-d883-2801-2d3607f2aeab@grandegger.com> <3dba0948-ffcb-8e80-fb32-62bb0aca6627@grandegger.com> <54d9a104-8ed1-4bb3-666e-042d3781dbfb@timesys.com> <006d9e14-47bf-1add-97c3-24098b43267f@grandegger.com> <69173747-cc2e-55f7-acad-4b5ba2a22863@timesys.com> <0362316b-ef76-1733-dbfc-8b644f758db9@timesys.com> <7730cff6-6e85-c98d-0315-bd3888d3aeb1@grandegger.com> Cc: mkl@pengutronix.de, linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Wolfgang Grandegger Message-ID: <9545c361-61e2-0d93-c5a6-c0b3837e1c8d@grandegger.com> Date: Sat, 18 Mar 2017 13:30:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Akshay, Am 17.03.2017 um 19:28 schrieb Akshay Bhat: > Hi Wolfgang, > > On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: >> >> Hm, that's unusual. Cable disconnected and then send a message: >> >> $ grep /proc/interrupts; sleep 10; /proc/interrupts >> >> should make things clear. But maybe it's a clever chip and it does stop >> sending error messages if the error counter does not change any more. >> After bus-off, the chip is quiet, of course. Should have a closer look >> to the CAN standard. >> > > The interrupt count does not increment after device reaches > tx-error-passive (with cable disconnected). > > # while true; do grep -i hi3110 /proc/interrupts; sleep 10; done & > [1] 793 > # > 111: 0 0 gpio-mxc 12 Edge hi3110 > # candump -t d -e any,0:0,#FFFFFFF & > [2] 798 > # cansend can0 123# > # > (000.000000) can0 20000004 [8] 00 08 00 00 00 00 60 00 ERRORFRAME > controller-problem{tx-error-warning} > error-counter-tx-rx{{96}{0}} > (000.002122) can0 20000004 [8] 00 20 00 00 00 00 80 00 ERRORFRAME > controller-problem{tx-error-passive} > error-counter-tx-rx{{128}{0}} > 111: 10 0 gpio-mxc 12 Edge hi3110 > 111: 10 0 gpio-mxc 12 Edge hi3110 > 111: 10 0 gpio-mxc 12 Edge hi3110 OK, then there is no good reason connecting the STAT interrupt pin. Wolfgang.