From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Juergen Gross <jgross@suse.com>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.11] x86/spec_ctrl: Updates to retpoline-safety decision making
Date: Tue, 24 Apr 2018 00:09:29 +0100 [thread overview]
Message-ID: <95469f1e-39c8-02c5-1b31-605814841e74@citrix.com> (raw)
In-Reply-To: <20180423211637.GA17724@char.us.oracle.com>
On 23/04/2018 22:16, Konrad Rzeszutek Wilk wrote:
>> diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
>> index 5b5ec90..aff06f0 100644
>> --- a/xen/arch/x86/spec_ctrl.c
>> +++ b/xen/arch/x86/spec_ctrl.c
>> @@ -113,12 +113,13 @@ static void __init print_details(enum ind_thunk thunk)
>> printk(XENLOG_DEBUG "Speculative mitigation facilities:\n");
>>
>> /* Hardware features which pertain to speculative mitigations. */
>> - printk(XENLOG_DEBUG " Hardware features:%s%s%s%s%s\n",
>> + printk(XENLOG_DEBUG " Hardware features:%s%s%s%s%s%s\n",
>> (_7d0 & cpufeat_mask(X86_FEATURE_IBRSB)) ? " IBRS/IBPB" : "",
>> (_7d0 & cpufeat_mask(X86_FEATURE_STIBP)) ? " STIBP" : "",
>> (e8b & cpufeat_mask(X86_FEATURE_IBPB)) ? " IBPB" : "",
>> (caps & ARCH_CAPABILITIES_IBRS_ALL) ? " IBRS_ALL" : "",
>> - (caps & ARCH_CAPABILITIES_RDCL_NO) ? " RDCL_NO" : "");
>> + (caps & ARCH_CAPABILITIES_RDCL_NO) ? " RDCL_NO" : "",
>> + (caps & ARCH_CAPS_RSBA) ? " RBSA" : "");
> You have RSBA on the left and RBSA on the right. Which one is it?
Bah - these are impossible acronyms to type. It is RSB-Alternative, so
the LHS is correct and I'll submit a correction for the RHS.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-04-23 23:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 18:13 [PATCH for-4.11] x86/spec_ctrl: Updates to retpoline-safety decision making Andrew Cooper
2018-04-19 9:00 ` Jan Beulich
2018-04-19 10:26 ` Andrew Cooper
2018-04-19 12:04 ` Jan Beulich
2018-04-19 14:25 ` [PATCH v2 " Andrew Cooper
2018-04-19 15:02 ` Jan Beulich
2018-04-19 15:15 ` Juergen Gross
2018-04-23 21:16 ` [PATCH " Konrad Rzeszutek Wilk
2018-04-23 23:09 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95469f1e-39c8-02c5-1b31-605814841e74@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.