From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932617AbcJ3RFx (ORCPT ); Sun, 30 Oct 2016 13:05:53 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:43033 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcJ3RFv (ORCPT ); Sun, 30 Oct 2016 13:05:51 -0400 Subject: Re: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address To: Lee Jones , Mugunthan V N References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> <20161026121730.GS8574@dell> Cc: linux-iio@vger.kernel.org, Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Vignesh R , "Andrew F . Davis" , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sekhar Nori , Peter Ujfalusi From: Jonathan Cameron Message-ID: <954adfa7-94d9-f785-aeab-6f20c8f4c3b9@kernel.org> Date: Sun, 30 Oct 2016 17:05:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161026121730.GS8574@dell> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/16 13:17, Lee Jones wrote: > On Fri, 30 Sep 2016, Mugunthan V N wrote: > >> On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote: >>> On Wed, 21 Sep 2016, Mugunthan V N wrote: >>> >>>> store the physical address of the device in its priv to use it >>>> for DMA addressing in the client drivers. >>>> >>>> Signed-off-by: Mugunthan V N >>>> --- >>>> drivers/mfd/ti_am335x_tscadc.c | 1 + >>>> include/linux/mfd/ti_am335x_tscadc.h | 1 + >>>> 2 files changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c >>>> index c8f027b..0f3fab4 100644 >>>> --- a/drivers/mfd/ti_am335x_tscadc.c >>>> +++ b/drivers/mfd/ti_am335x_tscadc.c >>>> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) >>>> tscadc->irq = err; >>>> >>>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>> + tscadc->tscadc_phys_base = res->start; >>> >>> This is unusual. Can't you use a virt_to_phys() variant instead? >>> >> >> I tried using virt_to_phys(), but its not working for me. >> Also saw many drivers uses like this to get physical address >> ("git grep -n " res->start;" drivers/*"). > > Very well: > > For my own reference: > Acked-for-MFD-by: Lee Jones > > Let me know how you wish this set to be handled. I'm happy to pick up the whole series. There are some more mfd header changes in patch 2 but as they only add defines, I don't mind that much if I don't an Ack from you on those (btw this got to V3 but as patch 1 didn't change I'll carry your ack forwards). Do you want an immutable branch? Seems unlikely to cause much trouble even if there is a merge issue on all 10ish lines of mfd code in the next merge window. Jonathan > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jic23@kernel.org (Jonathan Cameron) Date: Sun, 30 Oct 2016 17:05:47 +0000 Subject: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address In-Reply-To: <20161026121730.GS8574@dell> References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> <20161026121730.GS8574@dell> Message-ID: <954adfa7-94d9-f785-aeab-6f20c8f4c3b9@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26/10/16 13:17, Lee Jones wrote: > On Fri, 30 Sep 2016, Mugunthan V N wrote: > >> On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote: >>> On Wed, 21 Sep 2016, Mugunthan V N wrote: >>> >>>> store the physical address of the device in its priv to use it >>>> for DMA addressing in the client drivers. >>>> >>>> Signed-off-by: Mugunthan V N >>>> --- >>>> drivers/mfd/ti_am335x_tscadc.c | 1 + >>>> include/linux/mfd/ti_am335x_tscadc.h | 1 + >>>> 2 files changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c >>>> index c8f027b..0f3fab4 100644 >>>> --- a/drivers/mfd/ti_am335x_tscadc.c >>>> +++ b/drivers/mfd/ti_am335x_tscadc.c >>>> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) >>>> tscadc->irq = err; >>>> >>>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>> + tscadc->tscadc_phys_base = res->start; >>> >>> This is unusual. Can't you use a virt_to_phys() variant instead? >>> >> >> I tried using virt_to_phys(), but its not working for me. >> Also saw many drivers uses like this to get physical address >> ("git grep -n " res->start;" drivers/*"). > > Very well: > > For my own reference: > Acked-for-MFD-by: Lee Jones > > Let me know how you wish this set to be handled. I'm happy to pick up the whole series. There are some more mfd header changes in patch 2 but as they only add defines, I don't mind that much if I don't an Ack from you on those (btw this got to V3 but as patch 1 didn't change I'll carry your ack forwards). Do you want an immutable branch? Seems unlikely to cause much trouble even if there is a merge issue on all 10ish lines of mfd code in the next merge window. Jonathan >