From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397C3C43603 for ; Wed, 18 Dec 2019 11:53:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CC56227BF for ; Wed, 18 Dec 2019 11:53:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="o5GmkbjD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CC56227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 57D1D89AE6; Wed, 18 Dec 2019 11:53:11 +0000 (UTC) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3966389AE6 for ; Wed, 18 Dec 2019 11:53:10 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id xBIBr357070965; Wed, 18 Dec 2019 05:53:03 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1576669983; bh=HEdSJGGg0KnIi7ge4cvsyxF2BSgKrNfFfD+Cion41Wk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=o5GmkbjDcrkQgiyfDHMFDRuJzPDMqKDoGx1kXlTc7xKoCddsNk7DPvHJN66g9X6fn C1MMRLmPAVCkOEuFPXPtKBO6y7FCNvK+P8qX7Ym0pfDFyfKBfdhOa5dACxtymLJVSF pZX4wlvT51npTy44TZcViYAYgqFVlYfFTsITqSEU= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id xBIBr3ca003553; Wed, 18 Dec 2019 05:53:03 -0600 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 18 Dec 2019 05:53:02 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 18 Dec 2019 05:53:02 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id xBIBr0jF092090; Wed, 18 Dec 2019 05:53:01 -0600 Subject: Re: [PATCH v3 34/50] drm/omap: venc: Register a drm_bridge To: Laurent Pinchart , References: <20191210225750.15709-1-laurent.pinchart@ideasonboard.com> <20191210225750.15709-35-laurent.pinchart@ideasonboard.com> From: Tomi Valkeinen Message-ID: <954c3492-66fc-c6a2-39b9-42a80052504f@ti.com> Date: Wed, 18 Dec 2019 13:53:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191210225750.15709-35-laurent.pinchart@ideasonboard.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , Sean Paul , Sebastian Reichel , Boris Brezillon Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/12/2019 00:57, Laurent Pinchart wrote: > In order to integrate with a chain of drm_bridge, the internal VENC > encoder has to expose the mode valid, fixup and set, the enable and > disable and the get modes operations through the drm_bridge API. > Register a bridge at initialisation time to do so. > > Most of those operations are removed from the omap_dss_device as they > are now called through the drm_bridge API by the DRM atomic helpers. The > only exception is the .get_modes() operation that is still invoked > through the omap_dss_device-based pipeline. > > For the time being make the next bridge in the chain optional as the > VENC output is still based on omap_dss_device. The create_connector > argument to the bridge attach function is also ignored for the same > reason. This will be changed later when removing the related > omapdrm-specific display drivers. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Unregister bridge if output initialisation fails > --- > drivers/gpu/drm/omapdrm/dss/venc.c | 247 +++++++++++++++++++---------- > 1 file changed, 163 insertions(+), 84 deletions(-) Reviewed-by: Tomi Valkeinen Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel