All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: KONRAD Frederic <frederic.konrad@adacore.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, sagark@eecs.berkeley.edu,
	palmer@sifive.com, mjc@sifive.com
Subject: Re: [Qemu-devel] [PATCH] riscv: requires libfdt
Date: Thu, 19 Apr 2018 13:57:55 +0200	[thread overview]
Message-ID: <9551faef-173a-b232-5dfb-ca70bb8ef3fe@mail.uni-paderborn.de> (raw)
In-Reply-To: <1524135103-30477-1-git-send-email-frederic.konrad@adacore.com>

On 04/19/2018 12:51 PM, KONRAD Frederic wrote:
> When compiling on a machine without libfdt installed the configure script
> should try to get libfdt from the git or should die because otherwise
> CONFIG_LIBFDT is not set and the build process end in an error in the link
> phase.. eg:
> 
> hw/riscv/virt.o: In function `riscv_virt_board_init':
> qemu/src/hw/riscv/virt.c:317: undefined reference to `qemu_fdt_setprop_cell'
> qemu/src/hw/riscv/virt.c:319: undefined reference to `qemu_fdt_setprop_cell'
> qemu/src/hw/riscv/virt.c:345: undefined reference to `qemu_fdt_dumpdtb'
> collect2: error: ld returned 1 exit status
> make[1]: *** [qemu-system-riscv64] Error 1
> make: *** [subdir-riscv64-softmmu] Error 2
> 
> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
> ---

Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian

  reply	other threads:[~2018-04-19 11:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 10:51 [Qemu-devel] [PATCH] riscv: requires libfdt KONRAD Frederic
2018-04-19 11:57 ` Bastian Koppelmann [this message]
2018-04-19 12:00 ` Paolo Bonzini
2018-04-19 12:03   ` KONRAD Frederic
2018-04-19 12:11   ` Peter Maydell
2018-04-19 14:29 ` KONRAD Frederic
2018-04-19 16:56   ` Philippe Mathieu-Daudé
2018-04-19 23:37     ` Michael Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9551faef-173a-b232-5dfb-ca70bb8ef3fe@mail.uni-paderborn.de \
    --to=kbastian@mail.uni-paderborn.de \
    --cc=frederic.konrad@adacore.com \
    --cc=mjc@sifive.com \
    --cc=palmer@sifive.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.