From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/6] block/block-copy: allocate buffer in block_copy_with_bounce_buffer
Date: Mon, 7 Oct 2019 15:30:44 +0200 [thread overview]
Message-ID: <955ce5a9-bc0f-256f-05b4-affead9963f2@redhat.com> (raw)
In-Reply-To: <20191003171539.12327-2-vsementsov@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> Move bounce_buffer allocation block_copy_with_bounce_buffer. This
> commit simplifies further work on implementing copying by larger chunks
> (of different size) and further asynchronous handling of block_copy
> iterations (with help of block/aio_task API).
>
> Allocation works fast, a lot faster than disk io, so it's not a problem
> that we now allocate/free bounce_buffer more times. And we anyway will
> have to allocate several bounce_buffers for parallel execution of loop
> iterations in future.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/block-copy.c | 21 ++++++++-------------
> 1 file changed, 8 insertions(+), 13 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-07 13:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 17:15 [PATCH 0/6] block-copy: memory limit Vladimir Sementsov-Ogievskiy
2019-10-03 17:15 ` [PATCH 1/6] block/block-copy: allocate buffer in block_copy_with_bounce_buffer Vladimir Sementsov-Ogievskiy
2019-10-07 13:30 ` Max Reitz [this message]
2019-10-03 17:15 ` [PATCH 2/6] block/block-copy: limit copy_range_size to 16 MiB Vladimir Sementsov-Ogievskiy
2019-10-07 13:40 ` Max Reitz
2019-10-03 17:15 ` [PATCH 3/6] block/block-copy: refactor copying Vladimir Sementsov-Ogievskiy
2019-10-07 14:17 ` Max Reitz
2019-10-07 16:29 ` Vladimir Sementsov-Ogievskiy
2019-10-03 17:15 ` [PATCH 4/6] util: introduce co-shared-amount Vladimir Sementsov-Ogievskiy
2019-10-07 15:22 ` Max Reitz
2019-10-07 16:49 ` Vladimir Sementsov-Ogievskiy
2019-10-03 17:15 ` [PATCH 5/6] block/block-copy: add memory limit Vladimir Sementsov-Ogievskiy
2019-10-07 15:27 ` Max Reitz
2019-10-07 17:10 ` Vladimir Sementsov-Ogievskiy
2019-10-08 9:03 ` Max Reitz
2019-10-08 9:15 ` Vladimir Sementsov-Ogievskiy
2019-10-08 9:20 ` Vladimir Sementsov-Ogievskiy
2019-10-08 9:57 ` Max Reitz
2019-10-08 9:56 ` Max Reitz
2019-10-03 17:15 ` [PATCH 6/6] block/block-copy: increase buffered copy request Vladimir Sementsov-Ogievskiy
2019-10-07 15:47 ` Max Reitz
2019-10-07 15:48 ` Max Reitz
2019-10-07 16:22 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=955ce5a9-bc0f-256f-05b4-affead9963f2@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.