All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] syscalls/move_pages12: Two fixes.
Date: Thu, 4 May 2017 14:57:59 -0400 (EDT)	[thread overview]
Message-ID: <959115821.7379621.1493924279254.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170503124233.18585-1-chrubis@suse.cz>



----- Original Message -----
> * Do not multiply free ram with 1024
> 
>   - Since we get overflow even on fairly modest
>     machine with a few GB of RAM and the test
>     will always report "Not enough RAM".

This is obviously ok.

> 
> * Drop caches before the test
> 
>   - Otherwise the move_pages() syscalls may
>     fail with ENOMEM.
> 

How about we try to allocate/touch couple MB worth of pages
on node, we are going to move to (alloc_pages_on_node())?
If we can't allocate, exit with TCONF.

Otherwise we free those pages just before move_pages().
Wouldn't that give us better guarantee, there are some
free pages on target node?

Regards,
Jan

  reply	other threads:[~2017-05-04 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 12:42 [LTP] [RFC] [PATCH] syscalls/move_pages12: Two fixes Cyril Hrubis
2017-05-04 18:57 ` Jan Stancek [this message]
2017-05-05 12:55   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=959115821.7379621.1493924279254.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.