From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 920FE219392FD for ; Tue, 4 Apr 2017 03:46:14 -0700 (PDT) Received: by mail-wr0-f193.google.com with SMTP id u18so41062527wrc.0 for ; Tue, 04 Apr 2017 03:46:14 -0700 (PDT) Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> From: Sagi Grimberg Message-ID: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Date: Tue, 4 Apr 2017 13:46:09 +0300 MIME-Version: 1.0 In-Reply-To: <1490911959-5146-5-git-send-email-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe Cc: linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org List-ID: > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > + if (!p2pmem_debugfs_root) > + pr_info("could not create debugfs entry, continuing\n"); > + Why continue? I think it'd be better to just fail it. Besides, this can be safely squashed into patch 1. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file Date: Tue, 4 Apr 2017 13:46:09 +0300 Message-ID: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1490911959-5146-5-git-send-email-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Logan Gunthorpe , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rdma@vger.kernel.org > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > + if (!p2pmem_debugfs_root) > + pr_info("could not create debugfs entry, continuing\n"); > + Why continue? I think it'd be better to just fail it. Besides, this can be safely squashed into patch 1. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753883AbdDDKq4 (ORCPT ); Tue, 4 Apr 2017 06:46:56 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34692 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753448AbdDDKqO (ORCPT ); Tue, 4 Apr 2017 06:46:14 -0400 Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file To: Logan Gunthorpe , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> Cc: linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org From: Sagi Grimberg Message-ID: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Date: Tue, 4 Apr 2017 13:46:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490911959-5146-5-git-send-email-logang@deltatee.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > + if (!p2pmem_debugfs_root) > + pr_info("could not create debugfs entry, continuing\n"); > + Why continue? I think it'd be better to just fail it. Besides, this can be safely squashed into patch 1. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file To: Logan Gunthorpe , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> Cc: linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org From: Sagi Grimberg Message-ID: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Date: Tue, 4 Apr 2017 13:46:09 +0300 MIME-Version: 1.0 In-Reply-To: <1490911959-5146-5-git-send-email-logang@deltatee.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > + if (!p2pmem_debugfs_root) > + pr_info("could not create debugfs entry, continuing\n"); > + Why continue? I think it'd be better to just fail it. Besides, this can be safely squashed into patch 1. From mboxrd@z Thu Jan 1 00:00:00 1970 From: sagi@grimberg.me (Sagi Grimberg) Date: Tue, 4 Apr 2017 13:46:09 +0300 Subject: [RFC 4/8] p2pmem: Add debugfs "stats" file In-Reply-To: <1490911959-5146-5-git-send-email-logang@deltatee.com> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> Message-ID: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > + if (!p2pmem_debugfs_root) > + pr_info("could not create debugfs entry, continuing\n"); > + Why continue? I think it'd be better to just fail it. Besides, this can be safely squashed into patch 1.