All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Dongli Zhang <dongli.zhang@oracle.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: elena.ufimtseva@oracle.com, mjt@tls.msk.ru, jag.raman@oracle.com,
	john.g.johnson@oracle.com
Subject: Re: [PATCH RESEND 1/1] multi-process: fix usage information
Date: Thu, 23 Sep 2021 17:16:27 +0200	[thread overview]
Message-ID: <95965a78-318e-9c29-982d-02e8d9e21714@vivier.eu> (raw)
In-Reply-To: <20210713004718.20381-1-dongli.zhang@oracle.com>

Le 13/07/2021 à 02:47, Dongli Zhang a écrit :
> From source code, the 'devid' of x-remote-object should be one of devices
> in remote QEMU process.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
> ---
> Resend to be applied as trivial patch.
> 
> I have verified by reading the code and playing with below orchestrator.
> https://github.com/finallyjustice/sample/blob/master/kvm/multiprocess/orchestrator.py
> 
>  docs/system/multi-process.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/system/multi-process.rst b/docs/system/multi-process.rst
> index 46bb0cafc2..210531ee17 100644
> --- a/docs/system/multi-process.rst
> +++ b/docs/system/multi-process.rst
> @@ -45,7 +45,7 @@ Following is a description of command-line used to launch mpqemu.
>        -device lsi53c895a,id=lsi0                                         \
>        -drive id=drive_image2,file=/build/ol7-nvme-test-1.qcow2           \
>        -device scsi-hd,id=drive2,drive=drive_image2,bus=lsi0.0,scsi-id=0  \
> -      -object x-remote-object,id=robj1,devid=lsi1,fd=4,
> +      -object x-remote-object,id=robj1,devid=lsi0,fd=4,
>  
>  * QEMU:
>  
> 


Applied to my trivial-patches branch.

Thanks,
Laurent


      parent reply	other threads:[~2021-09-23 15:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  0:47 [PATCH RESEND 1/1] multi-process: fix usage information Dongli Zhang
2021-09-16 10:06 ` Laurent Vivier
2021-09-23 15:16 ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95965a78-318e-9c29-982d-02e8d9e21714@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=dongli.zhang@oracle.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=jag.raman@oracle.com \
    --cc=john.g.johnson@oracle.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.