From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CE6C433FE for ; Wed, 2 Feb 2022 12:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344210AbiBBMst (ORCPT ); Wed, 2 Feb 2022 07:48:49 -0500 Received: from mo4-p03-ob.smtp.rzone.de ([85.215.255.103]:39227 "EHLO mo4-p03-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231931AbiBBMss (ORCPT ); Wed, 2 Feb 2022 07:48:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1643806114; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=axTZFKF8TefXIuTKgaMQDq9eLMnd6hqVWe8w9mCHEw4=; b=HJ1JC6xsz6xJNkL7mlsE8tOvBw41CZSVWLBQOllvxhw3NAsOYa2kwfdYtR9XWhJ3zg S3DoJ7igzNuHoVJEqtzey1R7O3lYnkF9omTfEDF+0Qq1kyMpIFArcpbMzGipaENVU1dr 26nOEgjOhNJ4fywbDreoF+2mvi3bYpZEJEN4FAXVRxAaaWr0/Tjpw/cP11tG4lHImQaP t6Lko1RRrASPBZ/dqxX4Y2bgwL4KGGEzNQiajBnc/uOJnEzX8rwuS0bcpRXM6kQktm3z 3WOljUkHIMlGU0ZCocIBZd5yW4om56uEY36Tz89wIrGXeYVrlBMT9gZIjK1o7ud0BhsX ChzQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NIGH/jrwDCocQ==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.39.0 DYNA|AUTH) with ESMTPSA id L29417y12CmXAYT (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 2 Feb 2022 13:48:33 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 2 Feb 2022 13:48:32 +0100 Cc: Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Neil Armstrong , Robert Foss , Laurent Pinchart , Jernej Skrabec , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , Liam Girdwood , Mark Brown , Paul Boddie , Andrzej Hajda , Kieran Bingham , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Jonas Karlman , dri-devel@lists.freedesktop.org, Ezequiel Garcia Content-Transfer-Encoding: quoted-printable Message-Id: <95D4194F-86F0-470C-ACA3-3E83ED0EDC59@goldelico.com> References: <6a7b188769a7ad477bf8cb71e1b9bc086b92388d.1643632014.git.hns@goldelico.com> <1F27171F-DFCA-4707-8F50-D1A343F6D78E@goldelico.com> <37CB6D86-4295-4281-BF3E-3E4B40E74196@goldelico.com> <5ZFO6R.M6Z7S3EBA1YC1@crapouillou.net> <78F51BD7-112A-458D-8FCE-6A67572A182B@goldelico.com> To: Paul Cercueil X-Mailer: Apple Mail (2.3445.104.21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 02.02.2022 um 13:41 schrieb Paul Cercueil : >=20 >=20 >=20 > Le mer., f=C3=A9vr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller = a =C3=A9crit : >>> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : >>> Le mer., f=C3=A9vr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller = a =C3=A9crit : >>>> Hi Paul, >>>>> Am 02.02.2022 um 13:06 schrieb Paul Cercueil = : >>>>> Hi Nikolaus, >>>>>>>> @@ -446,6 +454,9 @@ static int = ingenic_drm_plane_atomic_check(struct drm_plane *plane, >>>>>>>> if (!crtc) >>>>>>>> return 0; >>>>>>>> + if (plane =3D=3D &priv->f0) >>>>>>>> + return -EINVAL; >>>>>>> This will break JZ4725B -> JZ4770 SoCs, the f0 plane is = perfectly usable there. >>>>>> Hm. I think it was your request/proposal to add this [1]? >>>>> Because otherwise with your current patchset the f0 plane does not = work *on JZ4780*. >>>> Not that I am eager to fix that, but... >>>> maybe it could be better to fix than having the check and -EINVAL = depend on SoC compatible string >>>> (or some new flag in soc_info. plane_f0_not_working)? >>> Totally agree! A proper fix would be much better. A = "plane_f0_not_working" in the meantime is OK with me. >> Ok, then I'll prepare a v13 with plane_f0_not_working. >>> Note that there are other things not working with your current = implementation, for instance you cannot set the X/Y start position of = the f1 plane, which means it's only really usable for fullscreen = desktop/windows. >> Is setting x/y possible for the other SoC? >=20 > Yes. They support different x/y positions, sizes, and pixel format for = both f0, f1 and IPU planes. Hm. What I don't get is why the jz4780 doesn't support that equally well = with existing code? To me it looks mainly like an extended jz4740. But I have to admit that = I did not study this deeply. I am happy with a working desktop HDMI setup... BR, Nikolaus= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD1A5C433EF for ; Wed, 2 Feb 2022 12:48:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 069D410E5DC; Wed, 2 Feb 2022 12:48:43 +0000 (UTC) Received: from mo4-p03-ob.smtp.rzone.de (mo4-p03-ob.smtp.rzone.de [81.169.146.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id C10FA10E5DC for ; Wed, 2 Feb 2022 12:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1643806114; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=axTZFKF8TefXIuTKgaMQDq9eLMnd6hqVWe8w9mCHEw4=; b=HJ1JC6xsz6xJNkL7mlsE8tOvBw41CZSVWLBQOllvxhw3NAsOYa2kwfdYtR9XWhJ3zg S3DoJ7igzNuHoVJEqtzey1R7O3lYnkF9omTfEDF+0Qq1kyMpIFArcpbMzGipaENVU1dr 26nOEgjOhNJ4fywbDreoF+2mvi3bYpZEJEN4FAXVRxAaaWr0/Tjpw/cP11tG4lHImQaP t6Lko1RRrASPBZ/dqxX4Y2bgwL4KGGEzNQiajBnc/uOJnEzX8rwuS0bcpRXM6kQktm3z 3WOljUkHIMlGU0ZCocIBZd5yW4om56uEY36Tz89wIrGXeYVrlBMT9gZIjK1o7ud0BhsX ChzQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NIGH/jrwDCocQ==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.39.0 DYNA|AUTH) with ESMTPSA id L29417y12CmXAYT (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 2 Feb 2022 13:48:33 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 2 Feb 2022 13:48:32 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <95D4194F-86F0-470C-ACA3-3E83ED0EDC59@goldelico.com> References: <6a7b188769a7ad477bf8cb71e1b9bc086b92388d.1643632014.git.hns@goldelico.com> <1F27171F-DFCA-4707-8F50-D1A343F6D78E@goldelico.com> <37CB6D86-4295-4281-BF3E-3E4B40E74196@goldelico.com> <5ZFO6R.M6Z7S3EBA1YC1@crapouillou.net> <78F51BD7-112A-458D-8FCE-6A67572A182B@goldelico.com> To: Paul Cercueil X-Mailer: Apple Mail (2.3445.104.21) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Paul Boddie , Geert Uytterhoeven , Neil Armstrong , David Airlie , Rob Herring , linux-mips@vger.kernel.org, Laurent Pinchart , Andrzej Hajda , Miquel Raynal , Sam Ravnborg , Jernej Skrabec , devicetree@vger.kernel.org, Kees Cook , Jonas Karlman , Mark Brown , Maxime Ripard , letux-kernel@openphoenux.org, Ezequiel Garcia , Thomas Bogendoerfer , dri-devel@lists.freedesktop.org, Liam Girdwood , Robert Foss , linux-kernel@vger.kernel.org, Kieran Bingham , "Eric W. Biederman" , Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Am 02.02.2022 um 13:41 schrieb Paul Cercueil : >=20 >=20 >=20 > Le mer., f=C3=A9vr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller = a =C3=A9crit : >>> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : >>> Le mer., f=C3=A9vr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller = a =C3=A9crit : >>>> Hi Paul, >>>>> Am 02.02.2022 um 13:06 schrieb Paul Cercueil = : >>>>> Hi Nikolaus, >>>>>>>> @@ -446,6 +454,9 @@ static int = ingenic_drm_plane_atomic_check(struct drm_plane *plane, >>>>>>>> if (!crtc) >>>>>>>> return 0; >>>>>>>> + if (plane =3D=3D &priv->f0) >>>>>>>> + return -EINVAL; >>>>>>> This will break JZ4725B -> JZ4770 SoCs, the f0 plane is = perfectly usable there. >>>>>> Hm. I think it was your request/proposal to add this [1]? >>>>> Because otherwise with your current patchset the f0 plane does not = work *on JZ4780*. >>>> Not that I am eager to fix that, but... >>>> maybe it could be better to fix than having the check and -EINVAL = depend on SoC compatible string >>>> (or some new flag in soc_info. plane_f0_not_working)? >>> Totally agree! A proper fix would be much better. A = "plane_f0_not_working" in the meantime is OK with me. >> Ok, then I'll prepare a v13 with plane_f0_not_working. >>> Note that there are other things not working with your current = implementation, for instance you cannot set the X/Y start position of = the f1 plane, which means it's only really usable for fullscreen = desktop/windows. >> Is setting x/y possible for the other SoC? >=20 > Yes. They support different x/y positions, sizes, and pixel format for = both f0, f1 and IPU planes. Hm. What I don't get is why the jz4780 doesn't support that equally well = with existing code? To me it looks mainly like an extended jz4740. But I have to admit that = I did not study this deeply. I am happy with a working desktop HDMI setup... BR, Nikolaus=