From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A373C433EF for ; Tue, 23 Nov 2021 06:18:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 27D2383679; Tue, 23 Nov 2021 07:18:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 0D77B83691; Tue, 23 Nov 2021 07:18:49 +0100 (CET) Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 07FC18365E for ; Tue, 23 Nov 2021 07:18:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=ms@dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1mpP8f-0007WZ-Iu; Tue, 23 Nov 2021 07:18:45 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpP8e-0006Ab-P5; Tue, 23 Nov 2021 07:18:44 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 13AFC240041; Tue, 23 Nov 2021 07:18:44 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id B4786240040; Tue, 23 Nov 2021 07:18:43 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 4509A207A4; Tue, 23 Nov 2021 07:18:43 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 23 Nov 2021 07:18:43 +0100 From: Martin Schiller To: "Camelia Alexandra Groza (OSS)" Cc: u-boot@lists.denx.de, Priyanka Jain Subject: Re: [PATCH] board: ls1046ardb: force PCI device enumeration Organization: TDT AG In-Reply-To: References: <20211117115920.27097-1-ms@dev.tdt.de> Message-ID: <95a1a5abb4bd059363a2a89fd52db993@dev.tdt.de> X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.16 X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1637648325-00002D2E-2B448677/0/0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021-11-22 17:30, Camelia Alexandra Groza (OSS) wrote: >> -----Original Message----- >> From: U-Boot On Behalf Of Martin >> Schiller >> Sent: Wednesday, November 17, 2021 13:59 >> To: u-boot@lists.denx.de >> Cc: Martin Schiller ; Priyanka Jain >> >> Subject: [PATCH] board: ls1046ardb: force PCI device enumeration >> >> Commit 045ecf899252 ("configs: enable DM_ETH support for LS1046ARDB") >> resulted in the PCI bus no longer being implicitly enumerated. >> >> However, this is necessary for the fdt pcie fixups to work. >> >> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb: >> transition to DM_ETH"), pci_init() is now called in the board_init() >> routine when CONFIG_DM_ETH is active. >> >> Signed-off-by: Martin Schiller >> CC: Priyanka Jain >> --- >> board/freescale/ls1046ardb/ls1046ardb.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/board/freescale/ls1046ardb/ls1046ardb.c >> b/board/freescale/ls1046ardb/ls1046ardb.c >> index 93ef903f29..d0abfe8869 100644 >> --- a/board/freescale/ls1046ardb/ls1046ardb.c >> +++ b/board/freescale/ls1046ardb/ls1046ardb.c >> @@ -93,6 +93,10 @@ int board_init(void) >> ppa_init(); >> #endif >> >> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH) >> + pci_init(); >> +#endif >> + >> /* invert AQR105 IRQ pins polarity */ >> out_be32(&scfg->intpcr, AQR105_IRQ_MASK); >> > > Hi > > Thank you for the patch. A very similar fix is needed for the > ls1043ardb board. > Are you interested to send a patch for that as well? > Hi Yes, I can do that. But I can't test it due to lack of hardware. > Acked-by: Camelia Groza