From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Schmelzer Date: Tue, 26 Mar 2019 10:15:40 +0100 Subject: [U-Boot] [REGRESSION: PATCH 34/34] drivers/net/fec: phy_init: remove redundant logic In-Reply-To: <120740997b8dab076d17f91625de73b40ae54b48.camel@toradex.com> References: <20190313082845.70B83C21FAB@lists.denx.de> <120740997b8dab076d17f91625de73b40ae54b48.camel@toradex.com> Message-ID: <95b059d1-9de4-bd3e-d1dd-e7909bd4892f@schmelzer.or.at> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 3/25/19 5:07 PM, Marcel Ziswiler wrote: > Hi Stefano > > On Wed, 2019-03-13 at 08:28 +0000, sbabic at denx.de wrote: >>> The phy_connect_dev(...) function from phy.c does all the handling >>> (inclusive catching fixed-link). >>> So we drop here the single steps and call just >>> phy_connect_dev(...). >>> Signed-off-by: Hannes Schmelzer >> Acked-by: Joe Hershberger >> Applied to u-boot-imx, master, thanks ! >> >> Best regards, >> Stefano Babic > Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing > my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device > tree enablement and driver model conversion") I noticed that Ethernet > no longer works giving the following error messages: > > Net: Could not get PHY for FEC0: addr -19 > eth-1: fec at 400d1000 > Colibri VFxx # dhcp > Could not get PHY for FEC0: addr -19 > Could not get PHY for FEC0: addr -19 > Could not get PHY for FEC0: addr -19 > Could not get PHY for FEC0: addr -19 > No ethernet found. > Could not get PHY for FEC0: addr -19 > Colibri VFxx # > > Bisecting points to this commit and reverting it indeed makes it work > again. > > Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)? > > Cheers > > Marcel > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot Hi Marcel, does this board use DM ? which defconfig uses the board? cheers, Hannes