All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Tom Rini <trini@konsulko.com>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: lukma@denx.de, sjg@chromium.org, u-boot@lists.denx.de,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults
Date: Thu, 28 Oct 2021 22:43:01 -0400	[thread overview]
Message-ID: <95b0da95-99cd-5aa9-2368-aac02509ed2c@gmail.com> (raw)
In-Reply-To: <20211029021041.GQ8284@bill-the-cat>


On 10/28/21 10:10 PM, Tom Rini wrote:
> On Fri, Oct 29, 2021 at 09:28:01AM +0800, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Current code has a force clk_set_defaults in multiple stages,
>> U-Boot reuse the same device tree and Linux Kernel device tree,
>> but we not register all the clks as Linux Kernel, so clk_set_defaults
>> will fail and cause the clk provider registeration fail.
>>
>> So introduce a new property to ignore the default settings which could
>> be used by any node that wanna ignore default settings.
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>
>> V2:
>>   Add R-b tag
>>   Tom, Simon
>>     After a thought, I think still put it as a u-boot thing. assigned-clock-x is
>>     actually Linux specific, however I could not add the new property to Linux,
>>     because we are supporting SystemReady-IR, we need the assigned-clock-x property
>>     in linux working and ignore it in U-Boot.
> 
> OK, right, so... it should be a generic property to say what, early
> firmware should ignore this clock unless otherwise required and use the
> preconfigured value?
> 

The issue is that for platforms sharing devicetrees between U-Boot and
Linux, Linux may add assigned-clocks which are not implemented in
U-Boot. Although assigning a specific frequency or parent to a clock may
not be necessary to use the device, it will fail to probe because the
clock cannot be found. I believe this property is intended for these
cases.

--Sean

  reply	other threads:[~2021-10-29  2:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29  1:28 [PATCH V2] clk: introduce u-boot,ignore-clk-defaults Peng Fan (OSS)
2021-10-29  0:57 ` Sean Anderson
2021-10-29  2:10 ` Tom Rini
2021-10-29  2:43   ` Sean Anderson [this message]
2021-10-29  2:47     ` Tom Rini
2021-11-20 12:10 ` Peng Fan (OSS)
2021-11-20 12:57   ` Tom Rini
2021-11-20 15:06     ` Sean Anderson
2021-11-20 15:13       ` Tom Rini
2021-11-20 15:21       ` Mark Kettenis
2021-11-20 15:25         ` Tom Rini
2021-11-22  3:34       ` Peng Fan (OSS)
2021-11-22  3:33     ` Peng Fan (OSS)
2021-11-22  3:51       ` Simon Glass
2021-11-22 13:22       ` Tom Rini
2021-11-23  3:02         ` Peng Fan (OSS)
2021-11-23 15:38           ` Tom Rini
2021-11-24  2:16           ` Sean Anderson
2021-11-24 14:10             ` Tom Rini
2021-11-26 18:17               ` Sean Anderson
2021-11-26 18:54                 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95b0da95-99cd-5aa9-2368-aac02509ed2c@gmail.com \
    --to=seanga2@gmail.com \
    --cc=lukma@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.