All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	Mel Gorman <mgorman@techsingularity.net>,
	Michal Hocko <mhocko@kernel.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Oscar Salvador <osalvador@suse.de>,
	Mike Rapoport <rppt@kernel.org>,
	Scott Cheloha <cheloha@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH RFC 3/4] mm/page_alloc: always move pages to the tail of the freelist in unset_migratetype_isolate()
Date: Fri, 18 Sep 2020 09:30:54 +0200	[thread overview]
Message-ID: <95b60466-bd83-e2bb-dafa-33ba0360259d@redhat.com> (raw)
In-Reply-To: <20200918022902.GD54754@L-31X9LVDL-1304.local>

On 18.09.20 04:29, Wei Yang wrote:
> On Wed, Sep 16, 2020 at 08:34:10PM +0200, David Hildenbrand wrote:
>> Page isolation doesn't actually touch the pages, it simply isolates
>> pageblocks and moves all free pages to the MIGRATE_ISOLATE freelist.
>>
>> We already place pages to the tail of the freelists when undoing
>> isolation via __putback_isolated_page(), let's do it in any case
>> (e.g., if order == pageblock_order) and document the behavior.
>>
>> This change results in all pages getting onlined via online_pages() to
>> be placed to the tail of the freelist.
> 
> I am sorry to not follow again. unset_migratetype_isolate() is used in
> __offline_pages if my understanding is correct. How does it contribute on
> online_pages? 

See -next / -mm, that should make it clearer.

-- 
Thanks,

David / dhildenb


  reply	other threads:[~2020-09-18  7:32 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 18:34 [PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation David Hildenbrand
2020-09-16 18:34 ` [PATCH RFC 1/4] mm/page_alloc: convert "report" flag of __free_one_page() to a proper flag David Hildenbrand
2020-09-16 21:44   ` Alexander Duyck
2020-09-16 21:44     ` Alexander Duyck
2020-09-16 21:44     ` Alexander Duyck
2020-09-18  1:53   ` Wei Yang
2020-09-18  7:23     ` David Hildenbrand
2020-09-24 10:19   ` Vlastimil Babka
2020-09-25 10:34   ` Oscar Salvador
2020-09-16 18:34 ` [PATCH RFC 2/4] mm/page_alloc: place pages to tail in __putback_isolated_page() David Hildenbrand
2020-09-16 21:50   ` Alexander Duyck
2020-09-16 21:50     ` Alexander Duyck
2020-09-18  2:07   ` Wei Yang
2020-09-18  7:27     ` David Hildenbrand
2020-09-21  1:57       ` Wei Yang
2020-09-18  2:16   ` Wei Yang
2020-09-18  7:29     ` David Hildenbrand
2020-09-24 10:37   ` Vlastimil Babka
2020-09-25  8:10     ` David Hildenbrand
2020-09-25 13:19   ` Oscar Salvador
2020-09-25 13:30     ` David Hildenbrand
2020-09-16 18:34 ` [PATCH RFC 3/4] mm/page_alloc: always move pages to the tail of the freelist in unset_migratetype_isolate() David Hildenbrand
2020-09-18  2:29   ` Wei Yang
2020-09-18  7:30     ` David Hildenbrand [this message]
2020-09-24 11:13   ` Vlastimil Babka
2020-09-25  2:45     ` Wei Yang
2020-09-25  8:05       ` David Hildenbrand
2020-09-25  8:39         ` Vlastimil Babka
2020-09-25 13:13     ` David Hildenbrand
2020-09-25 13:57   ` Oscar Salvador
2020-09-16 18:34 ` [PATCH RFC 4/4] mm/page_alloc: place pages to tail in __free_pages_core() David Hildenbrand
2020-09-24 13:44   ` Vlastimil Babka
2020-09-28  7:58   ` Oscar Salvador
2020-09-28  8:36     ` David Hildenbrand
2020-09-28 12:53       ` Oscar Salvador
2020-09-16 18:50 ` [PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation osalvador
2020-09-16 19:31   ` David Hildenbrand
2020-09-18  2:30     ` Wei Yang
2020-09-18  7:32       ` David Hildenbrand
2020-09-23 14:31     ` Vlastimil Babka
2020-09-23 15:26       ` David Hildenbrand
2020-09-24  9:40         ` Mel Gorman
2020-09-24  9:54           ` David Hildenbrand
2020-09-24 13:59         ` Vlastimil Babka
2020-09-24 14:29           ` David Hildenbrand
2020-09-24  1:57       ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95b60466-bd83-e2bb-dafa-33ba0360259d@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=cheloha@linux.ibm.com \
    --cc=dave.hansen@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=osalvador@suse.de \
    --cc=richard.weiyang@linux.alibaba.com \
    --cc=rppt@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.