From: Jan Beulich <jbeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
Rahul Singh <rahul.singh@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.
Date: Wed, 28 Oct 2020 08:18:14 +0100 [thread overview]
Message-ID: <95b72e09-246b-dcbe-6254-86b3e25081c6@suse.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2010271621480.12247@sstabellini-ThinkPad-T480s>
On 28.10.2020 00:32, Stefano Stabellini wrote:
> On Mon, 26 Oct 2020, Rahul Singh wrote:
>> --- a/xen/drivers/char/Kconfig
>> +++ b/xen/drivers/char/Kconfig
>> @@ -4,6 +4,13 @@ config HAS_NS16550
>> help
>> This selects the 16550-series UART support. For most systems, say Y.
>>
>> +config HAS_NS16550_PCI
>> + bool "NS16550 UART PCI support" if X86
>> + default y
>> + depends on X86 && HAS_NS16550 && HAS_PCI
>> + help
>> + This selects the 16550-series UART PCI support. For most systems, say Y.
>
> I think that this should be a silent option:
> if HAS_NS16550 && HAS_PCI && X86 -> automatically enable
> otherwise -> automatically disable
>
> No need to show it to the user.
I agree in principle, but I don't see why an X86 dependency gets
added here. HAS_PCI really should be all that's needed.
Jan
next prev parent reply other threads:[~2020-10-28 7:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 17:17 [PATCH v1 0/4] xen/arm: Make PCI passthrough code non-x86 specific Rahul Singh
2020-10-26 17:17 ` [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled Rahul Singh
2020-10-27 23:32 ` Stefano Stabellini
2020-10-28 7:18 ` Jan Beulich [this message]
2020-10-28 10:41 ` Rahul Singh
2020-10-28 11:32 ` Julien Grall
2020-10-28 15:47 ` Rahul Singh
2020-10-28 15:49 ` Jan Beulich
2020-10-28 10:38 ` Rahul Singh
2020-10-26 17:17 ` [PATCH v1 2/4] xen/pci: Introduce new CONFIG_HAS_PCI_ATS flag for PCI ATS functionality Rahul Singh
2020-10-27 23:55 ` Stefano Stabellini
2020-10-28 7:22 ` Jan Beulich
2020-10-28 7:25 ` Jan Beulich
2020-10-26 17:17 ` [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory Rahul Singh
2020-10-28 0:15 ` Stefano Stabellini
2020-10-28 11:51 ` Jan Beulich
2020-10-28 11:58 ` Julien Grall
2020-10-28 15:20 ` Rahul Singh
2020-10-28 15:37 ` Jan Beulich
2020-10-26 17:17 ` [PATCH v1 4/4] xen/pci: solve compilation error when memory paging is not enabled Rahul Singh
2020-10-28 11:56 ` Jan Beulich
2020-10-28 15:13 ` Rahul Singh
2020-10-29 16:58 ` Rahul Singh
2020-10-29 17:16 ` Jan Beulich
2020-10-30 13:59 ` Rahul Singh
2020-10-28 0:04 ` [PATCH v1 0/4] xen/arm: Make PCI passthrough code non-x86 specific Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95b72e09-246b-dcbe-6254-86b3e25081c6@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=rahul.singh@arm.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.