From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 955CEC4708D for ; Fri, 6 Jan 2023 12:42:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F753854CB; Fri, 6 Jan 2023 13:42:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="oQLJO7WB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AE0D7854DD; Fri, 6 Jan 2023 13:42:21 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2065.outbound.protection.outlook.com [40.107.95.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9CBAE854CA for ; Fri, 6 Jan 2023 13:42:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k9P9pNjTFRTGgBc4B/N1VJo2sjuNnKbK/bKEeH7gMwOURE3Dhh+ILGMtG7qdQgZegTrHY9e8TxzMRiBmtG+8ui1Hg09v9Crlj/8ahoR2edh9QOoNa34LZvpnYsHUw1lWbK4E5+R0b2ocq7MvV10U1EAtceXzmQf0FHNCFmno9WeCw16/O8XXjht5vyzjSkh46X1x5QYt4ogzZkfAbYZ5aSBQXFtN3bFQssb6YnBFm6mUX+79vyTaFL4eTg0IW6eIVle4R3BuXPaQmtkWv3VfHC8fHdgJDSYFDi1JLyp9WgrrqZEIS4YuLlmac6i4denUWw17K59rkbpql3b6JchczQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/sX8NNN8G8RbJFpVZpSs8uwXr8yc5qKQaDgDch50cUA=; b=FV+JURzJ8HSkjfFplpBqSxjhJY6zw31k+LTiGPfT2i66f8UYVVxPH/9MQfLzfNg2fdH2frMDBT4MupueRRw203Z1JmfkIQhpp0qO6XELvXHYc2Kt/1qidrRnhYYYWri3XKWd6Shsz/DjjCMVXWzM8FgL8dabDKwos0R2+cWXAniolw5qJwKw3p7nkMMThQww7C3wseDqLAE0W+NdwQz84HtfFFep/GsWFRRgaMxTU5kIbWeb4Z/H7hB6rscQHb7IDDDC+gjbJdmaOais56i9/1iYcThWopoQJwku7CPMzieeoC1hPot6Y7E1Aq4m9bqM8gl3UWQjMWlW4USdnt6J+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/sX8NNN8G8RbJFpVZpSs8uwXr8yc5qKQaDgDch50cUA=; b=oQLJO7WB7t34WGiK2L29VRUWfHFzoU2VX7MWZx/uygRCM9DgFtmEPTZpAexSKE82M1t7fVhKMhHt1iVjOGBrSfoyD2UNLJgB6RA2cBPl1EMZ+pZ5S6Lw28WJOGjoqsIv5j9Gt/msnSbxviwXL7YLylbLpm/5jNfSvmhRDkm8Kno= Received: from DM6PR07CA0082.namprd07.prod.outlook.com (2603:10b6:5:337::15) by DM4PR12MB5327.namprd12.prod.outlook.com (2603:10b6:5:39e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 12:42:16 +0000 Received: from DM6NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:5:337:cafe::c9) by DM6PR07CA0082.outlook.office365.com (2603:10b6:5:337::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 12:42:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT055.mail.protection.outlook.com (10.13.173.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5966.17 via Frontend Transport; Fri, 6 Jan 2023 12:42:15 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 6 Jan 2023 06:42:13 -0600 Message-ID: <95c3e8d3-b4e5-c6e5-dc28-18bf711d0cd5@amd.com> Date: Fri, 6 Jan 2023 13:42:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/4] gpio: zynqmp: Remove unused variable ret Content-Language: en-US To: Ashok Reddy Soma , CC: , , Algapally Santosh Sagar References: <20230106120035.2183-1-ashok.reddy.soma@amd.com> <20230106120035.2183-3-ashok.reddy.soma@amd.com> From: Michal Simek In-Reply-To: <20230106120035.2183-3-ashok.reddy.soma@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT055:EE_|DM4PR12MB5327:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a937fcb-b12b-4cdb-76a2-08daefe37113 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LD1vlLopYwLm3olM2jyd+KrIQvGqloQFZj8YyNcncXLBrxprafMc4A9I+EbtjmvExzQhEd2S1D8FdVxbLwok3L7uI97oVucl4fAXAfmNTPxCJ0VekUvcNiMmOCx9fR3JUm/El74oybL8sLLgSVFaUw03iqb3NNRgOLxsP+OMRBT/cd0BaoNtQqCn27hlAaADjKIb1+ukK7u2Hvv4SKTa1uT4W5xBtnr6P21h7bxe203CFYCde242s74mUgJfP69UM7IJpgEJOLnytfNrl2V3Truk/zjmequSJrEweh4BHa6RzwwHAvaME9sbTdibBpP+vu8F8o67KJipzpu0mNGJsYaqp1CDmEdvuycLRuAuOnzRA5e2caQpDKjr7aYbY6CZLysFFFsW5Jq8dqyCl9jJU8pyrJ6LXNdIRl/y7AzCWOo7766KTROyXFLl6Fxd2JXRN1qJGs+NcIiD6xeQELpQ7wGOGAE6xAL9P09Y6tjkSWUwxc9N0pU3zcFvyKM6LQhy8YZJE1HYe1NRU4A+oX1t4vy1JQtGg0LaaBln3YIjXQQrm5nJaKnkzqOELQ6o3L3mshI4ll3ZJo67qswCYLfws2tg24KIsqMUCsRjeLao++ljCxTMyBFx/meHIGMYX5W8vHljXAisf/89RAvpfDmwV3aig4YwF9/stPmA5pleWPKr8ZrPndsyCVZe6n0NH9yis01bn8tlfUblz24yELFToYKmWOO7ZxjNySbT742OeX7mSI9cYO0LpthYMr0qySALHOqj+w9q1J8BrxEta2bAEw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(478600001)(40480700001)(36756003)(40460700003)(356005)(86362001)(31696002)(81166007)(82310400005)(336012)(54906003)(316002)(8936002)(16576012)(2906002)(31686004)(2616005)(70206006)(44832011)(110136005)(41300700001)(5660300002)(53546011)(26005)(4326008)(8676002)(36860700001)(47076005)(70586007)(83380400001)(16526019)(186003)(426003)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 12:42:15.9280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a937fcb-b12b-4cdb-76a2-08daefe37113 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5327 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/6/23 13:00, Ashok Reddy Soma wrote: > From: Algapally Santosh Sagar > > There is a unused variable ret, due to which we are getting sparse warning > as below. > warning: variable 'ret' set but not used [-Wunused-but-set-variable]. > > Remove variable ret. > > Signed-off-by: Algapally Santosh Sagar > Signed-off-by: Ashok Reddy Soma > --- > > drivers/gpio/zynqmp_gpio_modepin.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpio/zynqmp_gpio_modepin.c b/drivers/gpio/zynqmp_gpio_modepin.c > index 078fd83395..52eda9ceb4 100644 > --- a/drivers/gpio/zynqmp_gpio_modepin.c > +++ b/drivers/gpio/zynqmp_gpio_modepin.c > @@ -45,9 +45,8 @@ static int modepin_gpio_set_value(struct udevice *dev, unsigned int offset, > { > u32 ret_payload[PAYLOAD_ARG_CNT]; > u32 out_val = 0; > - int ret; > > - ret = get_gpio_modepin(ret_payload); > + get_gpio_modepin(ret_payload); :-) what about return error if get_gpio_modepin fails? M > if (value) > out_val = OUTVAL(offset) | ret_payload[1]; > else