From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 22 Mar 2017 08:50:00 +0100 Subject: [U-Boot] [PATCH v1 36/41] net: mvpp2: Add Group-of-Ports and Net-Compex configuration for PPv2.2 In-Reply-To: References: <20170321142802.24276-1-sr@denx.de> <20170321142802.24276-37-sr@denx.de> Message-ID: <95caa6ea-9040-5230-8a8e-d15ddcc644d1@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 21.03.2017 19:03, Joe Hershberger wrote: > On Tue, Mar 21, 2017 at 9:27 AM, Stefan Roese wrote: >> This patch adds the GoP (Group of Ports) and NetC (Net Complex) setup to >> the Marvell mvpp2 ethernet driver. This code is mostly copied from the >> Marvell U-Boot version and was written by Stefan Chulski. >> >> Currently only MAC2 (SGMII) and MAC3 (RGMII) are tested on the >> Armada-7040 DB. Testing of the other MACs on other boards in all possible >> PHY interface modes still needs to be done. >> >> Signed-off-by: Stefan Roese >> Cc: Stefan Chulski >> Cc: Kostya Porotchkin >> Cc: Nadav Haklai >> --- >> >> drivers/net/mvpp2.c | 1212 +++++++++++++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 1174 insertions(+), 38 deletions(-) > > Please break this into more digestible pieces. Okay, I'll try to split this patch into smaller parts. > Maybe also remove unused / untested code. I will think about this as well. Currently I'm trying to get other interfaces and boards tested. Thanks, Stefan