All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhangshaokun@hisilicon.com (Zhangshaokun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: Drop the unused cpu parameter
Date: Tue, 9 Oct 2018 21:53:44 +0800	[thread overview]
Message-ID: <95d1728d-2e48-0b05-e25f-fc9b03e9c31c@hisilicon.com> (raw)
In-Reply-To: <20181009115704.GC6248@arm.com>

Hi Will,

On 2018/10/9 19:57, Will Deacon wrote:
> On Sat, Oct 06, 2018 at 04:49:04PM +0800, Shaokun Zhang wrote:
>> Cpu parameter is never used in flush_context, remove it.
>>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>>  arch/arm64/mm/context.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Acked-by: Will Deacon <will.deacon@arm.com>
> 
> Curious, but does this actually result in better code generation, or does
> GCC already figure out that the parameter is unused?
> 

No hint from GCC compiler, the unused parameter is found when debug one
context switch issue and analyze the code. It is redundant and harmless
to remove it, a trivial patch.

Thanks,
Shaokun

> Will
> 
> .
> 

      reply	other threads:[~2018-10-09 13:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-06  8:49 [PATCH] arm64: mm: Drop the unused cpu parameter Shaokun Zhang
2018-10-09 11:57 ` Will Deacon
2018-10-09 13:53   ` Zhangshaokun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95d1728d-2e48-0b05-e25f-fc9b03e9c31c@hisilicon.com \
    --to=zhangshaokun@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.