All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Maxim Mikityanskiy <maximmi@mellanox.com>,
	Magnus Karlsson <magnus.karlsson@intel.com>
Cc: xdp-newbies@vger.kernel.org, rgoodfel@isi.edu,
	bjorn.topel@intel.com, tariqt@mellanox.com, saeedm@mellanox.com,
	moshe@mellanox.com
Subject: Re: [PATCH bpf] xsk: publish global consumer pointers when NAPI is finsihed
Date: Fri, 7 Feb 2020 22:40:59 +0100	[thread overview]
Message-ID: <95de5e86-8930-5655-62b9-ec60b9952440@iogearbox.net> (raw)
In-Reply-To: <c5d6fd11-8696-e898-6f05-5fcc087c0065@mellanox.com>

On 2/7/20 1:34 PM, Maxim Mikityanskiy wrote:
> On 2020-02-07 11:37, Magnus Karlsson wrote:
>> The commit 4b638f13bab4 ("xsk: Eliminate the RX batch size")
>> introduced a much more lazy way of updating the global consumer
>> pointers from the kernel side, by only doing so when running out of
>> entries in the fill or Tx rings (the rings consumed by the
>> kernel). This can result in a deadlock with the user application if
>> the kernel requires more than one entry to proceed and the application
>> cannot put these entries in the fill ring because the kernel has not
>> updated the global consumer pointer since the ring is not empty.
[...]
> 
> Acked-by: Maxim Mikityanskiy <maximmi@mellanox.com>
> 
> Is it intentional that you didn't send it to bpf and netdev mailing lists?

Yep, please resend with Maxim's ACK to bpf + netdev in Cc. Thanks!

  reply	other threads:[~2020-02-07 21:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  9:37 [PATCH bpf] xsk: publish global consumer pointers when NAPI is finsihed Magnus Karlsson
2020-02-07 12:34 ` Maxim Mikityanskiy
2020-02-07 21:40   ` Daniel Borkmann [this message]
2020-02-09  9:58     ` Magnus Karlsson
2020-02-10 13:43       ` Maxim Mikityanskiy
2020-02-10 14:02         ` Magnus Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95de5e86-8930-5655-62b9-ec60b9952440@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=bjorn.topel@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=maximmi@mellanox.com \
    --cc=moshe@mellanox.com \
    --cc=rgoodfel@isi.edu \
    --cc=saeedm@mellanox.com \
    --cc=tariqt@mellanox.com \
    --cc=xdp-newbies@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.