From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30AD4CCA480 for ; Thu, 30 Jun 2022 14:29:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2898A1125F3; Thu, 30 Jun 2022 14:29:54 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E584A1125C9; Thu, 30 Jun 2022 14:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656599392; x=1688135392; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wQpzAJXTo7Bhnhsk3imUJSwSv9/OyCu1er02rRF6zKA=; b=OOdEHLEFZ5SJXDev514ghXyhkZpYLlHGYz24gYfPWtUVC4pINjPvVI3K 49jPUiiM+B3cQnvSiFlUGyJqBguYztEDhTdaAU7/ahzuiT0YJh8x5sD6Y vs7wvxZ77oCCWKXEUpai0eRiDBQmKhgBFKQxexU/wbbm/CkUG+7MpDqyW ZqvZKtWgQpJ9NTJmJkvFM1tFXOdxNT2eOaDOHGC3+jfx+XIb+xkUdKOxX X4sQJfHqiQtsbzbd8gxpXR2T8iDczy1HqpIIomXQtpics7445R6JGAbBf oDq++A9lv/U8S9Y8PKk/0UFpA947vDUJfffwkGyHVZSv3XtYWtwKDPSdz g==; X-IronPort-AV: E=McAfee;i="6400,9594,10393"; a="282396356" X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="282396356" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 07:29:52 -0700 X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="647912693" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.25.211]) ([10.213.25.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 07:29:44 -0700 Message-ID: <95e834e2-bd6f-efd9-28d2-9e983f9de7ae@intel.com> Date: Thu, 30 Jun 2022 16:29:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.10.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain() Content-Language: en-US To: Rob Clark , dri-devel@lists.freedesktop.org References: <20220628233512.439555-1-robdclark@gmail.com> From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20220628233512.439555-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , David Airlie , intel-gfx@lists.freedesktop.org, open list , Sumit Semwal , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Matthew Auld , Rodrigo Vivi , =?UTF-8?Q?Christian_K=c3=b6nig?= , "open list:DMA BUFFER SHARING FRAMEWORK" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 29.06.2022 01:35, Rob Clark wrote: > From: Rob Clark > > drive-by cleanup > > Signed-off-by: Rob Clark Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > index 319936f91ac5..667841780514 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, > rcu_read_unlock(); > } > > -static inline bool __dma_fence_is_chain(const struct dma_fence *fence) > -{ > - return fence->ops == &dma_fence_chain_ops; > -} > - > void i915_gem_fence_wait_priority(struct dma_fence *fence, > const struct i915_sched_attr *attr) > { > @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence, > > for (i = 0; i < array->num_fences; i++) > fence_set_priority(array->fences[i], attr); > - } else if (__dma_fence_is_chain(fence)) { > + } else if (dma_fence_is_chain(fence)) { > struct dma_fence *iter; > > /* The chain is ordered; if we boost the last, we boost all */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D7BCCA47B for ; Thu, 30 Jun 2022 14:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237099AbiF3Og5 (ORCPT ); Thu, 30 Jun 2022 10:36:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237151AbiF3Ogl (ORCPT ); Thu, 30 Jun 2022 10:36:41 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AFCD58FC1; Thu, 30 Jun 2022 07:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656599392; x=1688135392; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wQpzAJXTo7Bhnhsk3imUJSwSv9/OyCu1er02rRF6zKA=; b=OOdEHLEFZ5SJXDev514ghXyhkZpYLlHGYz24gYfPWtUVC4pINjPvVI3K 49jPUiiM+B3cQnvSiFlUGyJqBguYztEDhTdaAU7/ahzuiT0YJh8x5sD6Y vs7wvxZ77oCCWKXEUpai0eRiDBQmKhgBFKQxexU/wbbm/CkUG+7MpDqyW ZqvZKtWgQpJ9NTJmJkvFM1tFXOdxNT2eOaDOHGC3+jfx+XIb+xkUdKOxX X4sQJfHqiQtsbzbd8gxpXR2T8iDczy1HqpIIomXQtpics7445R6JGAbBf oDq++A9lv/U8S9Y8PKk/0UFpA947vDUJfffwkGyHVZSv3XtYWtwKDPSdz g==; X-IronPort-AV: E=McAfee;i="6400,9594,10393"; a="281127819" X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="281127819" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 07:29:52 -0700 X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="647912693" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.25.211]) ([10.213.25.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 07:29:44 -0700 Message-ID: <95e834e2-bd6f-efd9-28d2-9e983f9de7ae@intel.com> Date: Thu, 30 Jun 2022 16:29:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.10.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain() Content-Language: en-US To: Rob Clark , dri-devel@lists.freedesktop.org Cc: Rob Clark , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , David Airlie , intel-gfx@lists.freedesktop.org, open list , =?UTF-8?Q?Christian_K=c3=b6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Matthew Auld , Rodrigo Vivi , Sumit Semwal , "open list:DMA BUFFER SHARING FRAMEWORK" References: <20220628233512.439555-1-robdclark@gmail.com> From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20220628233512.439555-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.06.2022 01:35, Rob Clark wrote: > From: Rob Clark > > drive-by cleanup > > Signed-off-by: Rob Clark Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > index 319936f91ac5..667841780514 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, > rcu_read_unlock(); > } > > -static inline bool __dma_fence_is_chain(const struct dma_fence *fence) > -{ > - return fence->ops == &dma_fence_chain_ops; > -} > - > void i915_gem_fence_wait_priority(struct dma_fence *fence, > const struct i915_sched_attr *attr) > { > @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence, > > for (i = 0; i < array->num_fences; i++) > fence_set_priority(array->fences[i], attr); > - } else if (__dma_fence_is_chain(fence)) { > + } else if (dma_fence_is_chain(fence)) { > struct dma_fence *iter; > > /* The chain is ordered; if we boost the last, we boost all */