All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: [PATCH 07/10] ti: Remove extern from function prototypes
Date: Tue, 24 Sep 2013 14:10:01 -0700	[thread overview]
Message-ID: <95f7f1519d5b1ad7c51b3ac561a0903462202d36.1380056108.git.joe@perches.com> (raw)
In-Reply-To: <cover.1380056108.git.joe@perches.com>

There are a mix of function prototypes with and without extern
in the kernel sources.  Standardize on not using extern for
function prototypes.

Function prototypes don't need to be written with extern.
extern is assumed by the compiler.  Its use is as unnecessary as
using auto to declare automatic/local variables in a block.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/ethernet/ti/cpts.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/ti/cpts.h b/drivers/net/ethernet/ti/cpts.h
index fe993cd..1a581ef 100644
--- a/drivers/net/ethernet/ti/cpts.h
+++ b/drivers/net/ethernet/ti/cpts.h
@@ -127,8 +127,8 @@ struct cpts {
 };
 
 #ifdef CONFIG_TI_CPTS
-extern void cpts_rx_timestamp(struct cpts *cpts, struct sk_buff *skb);
-extern void cpts_tx_timestamp(struct cpts *cpts, struct sk_buff *skb);
+void cpts_rx_timestamp(struct cpts *cpts, struct sk_buff *skb);
+void cpts_tx_timestamp(struct cpts *cpts, struct sk_buff *skb);
 #else
 static inline void cpts_rx_timestamp(struct cpts *cpts, struct sk_buff *skb)
 {
@@ -138,8 +138,7 @@ static inline void cpts_tx_timestamp(struct cpts *cpts, struct sk_buff *skb)
 }
 #endif
 
-extern int cpts_register(struct device *dev, struct cpts *cpts,
-			 u32 mult, u32 shift);
-extern void cpts_unregister(struct cpts *cpts);
+int cpts_register(struct device *dev, struct cpts *cpts, u32 mult, u32 shift);
+void cpts_unregister(struct cpts *cpts);
 
 #endif
-- 
1.8.1.2.459.gbcd45b4.dirty


  parent reply	other threads:[~2013-09-24 21:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-24 21:09 [PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes Joe Perches
2013-09-24 21:09 ` Joe Perches
2013-09-24 21:09 ` [PATCH 01/10] ibm/emac: " Joe Perches
2013-09-24 21:09 ` [PATCH 02/10] intel: " Joe Perches
2013-09-24 22:07   ` Jeff Kirsher
2013-09-24 22:07     ` Jeff Kirsher
2013-09-24 22:16     ` Ben Hutchings
2013-09-25  1:34       ` David Miller
2013-09-24 22:22     ` Joe Perches
2013-09-24 22:22       ` Joe Perches
2013-09-24 21:09 ` [PATCH 03/10] oki-semi: " Joe Perches
2013-09-24 21:09 ` [PATCH 04/10] qlogic: " Joe Perches
2013-09-24 21:09 ` [PATCH 05/10] sfc: " Joe Perches
2013-09-24 21:10 ` [PATCH 06/10] stmicro: " Joe Perches
2013-09-24 21:10 ` Joe Perches [this message]
2013-09-24 21:10 ` [PATCH 08/10] toshiba: " Joe Perches
2013-09-24 21:26   ` Geoff Levand
2013-09-24 21:10 ` [PATCH 09/10] fddi/skfp: " Joe Perches
2013-09-24 21:10 ` [PATCH 10/10] irda: " Joe Perches
     [not found] ` <OF686C5618.58B3CEF3-ONC1257BF0.0074538C-C1257BF0.00745392@de.ibm.com>
2013-09-24 21:21   ` [RFC patch] Update Jens Osterkamp email address Joe Perches
2013-09-24 21:45     ` Joe Perches
2013-09-25 19:04 ` [PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95f7f1519d5b1ad7c51b3ac561a0903462202d36.1380056108.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.