From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] iotests: Bind qemu-nbd to localhost in 147
Date: Mon, 21 Jan 2019 14:56:13 -0600 [thread overview]
Message-ID: <95f91d74-f165-542f-678f-a79f9253a3c5@redhat.com> (raw)
In-Reply-To: <20181221234750.23577-3-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]
On 12/21/18 5:47 PM, Max Reitz wrote:
> By default, qemu-nbd binds to 0.0.0.0. However, we then proceed to
> connect to "localhost". Usually, this works out fine; but if this test
> is run concurrently, some other test function may have bound a different
> server to ::1 (on the same port -- you can bind different serves to the
s/serves/servers/
> same port, as long as one is on IPv4 and the other on IPv6).
>
> So running qemu-nbd works, it can bind to 0.0.0.0:NBD_PORT. But
> potentially a concurrent test has successfully taken [::1]:NBD_PORT. In
> this case, trying to connect to "localhost" will lead us to the IPv6
> instance, where we do not want to end up.
>
> Fix this by just binding to "localhost". This will make qemu-nbd error
> out immediately and not give us cryptic errors later.
>
> (Also, it will allow us to just try a different port as of a future
> patch.)
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/147 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-21 20:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 23:47 [Qemu-devel] [PATCH 0/3] iotests: Allow 147 to be run concurrently Max Reitz
2018-12-21 23:47 ` [Qemu-devel] [PATCH 1/3] iotests.py: Add qemu_nbd_pipe() Max Reitz
2019-01-21 20:55 ` Eric Blake
2019-01-23 13:06 ` Max Reitz
2019-01-23 14:27 ` Eric Blake
2018-12-21 23:47 ` [Qemu-devel] [PATCH 2/3] iotests: Bind qemu-nbd to localhost in 147 Max Reitz
2019-01-21 20:56 ` Eric Blake [this message]
2018-12-21 23:47 ` [Qemu-devel] [PATCH 3/3] iotests: Allow 147 to be run concurrently Max Reitz
2019-01-21 20:50 ` [Qemu-devel] [Qemu-block] " John Snow
2019-01-23 13:05 ` Max Reitz
2019-01-23 17:34 ` Max Reitz
2019-01-23 17:47 ` John Snow
2019-01-25 15:01 ` Max Reitz
2019-01-21 21:02 ` [Qemu-devel] " Eric Blake
2019-01-23 13:12 ` Max Reitz
2019-01-23 14:33 ` Eric Blake
2019-01-23 14:37 ` Max Reitz
2019-01-23 14:43 ` Daniel P. Berrangé
2019-01-31 1:01 ` [Qemu-devel] [PATCH 0/3] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95f91d74-f165-542f-678f-a79f9253a3c5@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.