From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjzB-0008Kp-9B for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:22:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFjz9-0003Q0-8t for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:22:36 -0400 References: <1464928382-9650-1-git-send-email-famz@redhat.com> <1464928382-9650-3-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <95fb448f-1848-23c0-93f0-208a1b07c237@redhat.com> Date: Wed, 22 Jun 2016 17:22:24 +0200 MIME-Version: 1.0 In-Reply-To: <1464928382-9650-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MeHmwgxlAPrrgD4sOIDIomQTL6SAs6V5A" Subject: Re: [Qemu-devel] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MeHmwgxlAPrrgD4sOIDIomQTL6SAs6V5A From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, qemu-block@nongnu.org Message-ID: <95fb448f-1848-23c0-93f0-208a1b07c237@redhat.com> Subject: Re: [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes References: <1464928382-9650-1-git-send-email-famz@redhat.com> <1464928382-9650-3-git-send-email-famz@redhat.com> In-Reply-To: <1464928382-9650-3-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 03.06.2016 06:32, Fam Zheng wrote: > Upon each bit toggle, the corresponding bit in the meta bitmap will be > set. >=20 > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block/dirty-bitmap.c | 2 +- > include/qemu/hbitmap.h | 17 +++++++++++++ > util/hbitmap.c | 69 +++++++++++++++++++++++++++++++++++++++---= -------- > 3 files changed, 72 insertions(+), 16 deletions(-) >=20 > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index ec073ee..628b77c 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -231,7 +231,7 @@ static void bdrv_do_release_matching_dirty_bitmap(B= lockDriverState *bs, > BdrvDirtyBitmap *bm, *next; > QLIST_FOREACH_SAFE(bm, &bs->dirty_bitmaps, list, next) { > if ((!bitmap || bm =3D=3D bitmap) && (!only_named || bm->name)= ) { > - assert(!bitmap->active_iterators); > + assert(!bm->active_iterators); Same comment as for v4, this should be squashed into the previous patch. Max --MeHmwgxlAPrrgD4sOIDIomQTL6SAs6V5A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXaq0wAAoJEDuxQgLoOKytkl4H/3L7zzLTeZ1Xf2QIdQ6qGlMr DGTIvvbNkQAE47IXQaLR2fMavZdE0CtFKzTUHvMtRU37Jt4UBzP1oqASWWhYlmtz rJzojoO/LOaOnsRyDRHNu8LPUiEtNPrZ6prgMkAZEUFl6DbQM4GmMmEUBpwFOkD7 7hOn4RI2jLLs3aMZrGwsmq2dT18pm/Hmby0oKbMMBxsB4zcFgrJbPwGRwehHFcdn kjRQ78YBEYiFaQk9Xx9A1OfRdm5tpzVzK2QoTIRRwXEYAaFnngF/DBSb6CnE5HYM HWHA7NVAytcVSiye5hf+NipSUGaX38Wdcc2hBc9YZ7G8y3jtVmMz2oliQBI/6YU= =iD2k -----END PGP SIGNATURE----- --MeHmwgxlAPrrgD4sOIDIomQTL6SAs6V5A--