From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900F3C433DF for ; Sun, 5 Jul 2020 06:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 750A420747 for ; Sun, 5 Jul 2020 06:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgGEGEe (ORCPT ); Sun, 5 Jul 2020 02:04:34 -0400 Received: from mga03.intel.com ([134.134.136.65]:53525 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbgGEGEe (ORCPT ); Sun, 5 Jul 2020 02:04:34 -0400 IronPort-SDR: pHnVBsnIxSx5WKl1RlaRCjXrBR5HrZUnQ9z4I8Ty1cV8AXChURgWwbzJjdlA4BNDJYgri+i7nc +huKGr37dUTw== X-IronPort-AV: E=McAfee;i="6000,8403,9672"; a="147301297" X-IronPort-AV: E=Sophos;i="5.75,314,1589266800"; d="scan'208";a="147301297" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2020 23:04:33 -0700 IronPort-SDR: RTZKJhnrLEZugPly4VtR2NDpLYKGxq/qbqDz6diM18IhrJLYpFDA0aIulzr5x/OJiPJ0R6pdFP RzzxPLYsn14A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,314,1589266800"; d="scan'208";a="282715546" Received: from yangblan-mobl2.ccr.corp.intel.com ([10.255.29.148]) by orsmga006.jf.intel.com with ESMTP; 04 Jul 2020 23:04:22 -0700 Message-ID: <9627f15fb2145525b40d6c1aed6752e13df876e9.camel@intel.com> Subject: Re: [PATCH 0/3] Fixes for stop monitoring disabled devices series From: Zhang Rui To: Daniel Lezcano , Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Allison Randal , Enrico Weigelt , Gayatri Kammela , Thomas Gleixner , Bartlomiej Zolnierkiewicz , kernel@collabora.com Date: Sun, 05 Jul 2020 14:04:21 +0800 In-Reply-To: <79ae59af-d3b9-852c-d5f3-5b80d9c6ea8c@linaro.org> References: <20200703104354.19657-1-andrzej.p@collabora.com> <91db4c89-0615-4a69-9695-ed5d3c42e1b7@collabora.com> <79ae59af-d3b9-852c-d5f3-5b80d9c6ea8c@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2020-07-03 at 14:05 +0200, Daniel Lezcano wrote: > On 03/07/2020 13:57, Andrzej Pietrasiewicz wrote: > > Hi, > > > > W dniu 03.07.2020 o 13:06, Daniel Lezcano pisze: > > > On 03/07/2020 12:43, Andrzej Pietrasiewicz wrote: > > > > This short series contains fixes for "Stop monitoring disabled > > > > devices" > > > > series https://www.spinics.net/lists/arm-kernel/msg817861.html > > > > > > > > Invocation of thermal_zone_device_is_enabled() in acpi/thermal > > > > is now > > > > redundant, because thermal_zone_device_update() now is capable > > > > of > > > > handling disabled devices. > > > > > > > > In imx's ->get_temp() the lock must not be taken, otherwise a > > > > deadlock > > > > happens. The decision whether explicitly running a measurement > > > > cycle > > > > is needed is taken based on driver's local irq_enabled > > > > variable. > > > > > > > > Finally, thermal_zone_device_is_enabled() is made available to > > > > the > > > > core only, as there are no driver users of it. > > > > > > > > Andrzej Pietrasiewicz (3): > > > > acpi: thermal: Don't call thermal_zone_device_is_enabled() > > > > thermal: imx: Use driver's local data to decide whether to > > > > run a > > > > measurement > > > > thermal: Make thermal_zone_device_is_enabled() available to > > > > core only > > > > > > > > drivers/acpi/thermal.c | 3 --- > > > > drivers/thermal/imx_thermal.c | 7 ++++--- > > > > drivers/thermal/thermal_core.c | 1 - > > > > drivers/thermal/thermal_core.h | 2 ++ > > > > include/linux/thermal.h | 5 ----- > > > > 5 files changed, 6 insertions(+), 12 deletions(-) > > > > > > Is this series easily merge-able with the other series? > > > > > > > So-so. > > > > Some simple conflicts needed to be resolved. > > > > I have created a branch for you to look at and decide > > how far off it is from the original and whether the > > original Acked-by/Reviewed-by can be retained. > > > > Note that I might have lost some portions of code > > during conflict resolution. It seems to me I haven't > > but you know. > > > > The branch: > > > > https://gitlab.collabora.com/andrzej.p/kernel-tests/-/tree/thermal-dont-poll-disabled-for-daniel > > Ok, I propose to keep the these three patches on top of V7. > > Rui are you fine with that ? Yes, that works for me. thanks, rui > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: Re: [PATCH 0/3] Fixes for stop monitoring disabled devices series Date: Sun, 05 Jul 2020 14:04:21 +0800 Message-ID: <9627f15fb2145525b40d6c1aed6752e13df876e9.camel@intel.com> References: <20200703104354.19657-1-andrzej.p@collabora.com> <91db4c89-0615-4a69-9695-ed5d3c42e1b7@collabora.com> <79ae59af-d3b9-852c-d5f3-5b80d9c6ea8c@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <79ae59af-d3b9-852c-d5f3-5b80d9c6ea8c@linaro.org> Sender: linux-acpi-owner@vger.kernel.org To: Daniel Lezcano , Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo List-Id: platform-driver-x86.vger.kernel.org On Fri, 2020-07-03 at 14:05 +0200, Daniel Lezcano wrote: > On 03/07/2020 13:57, Andrzej Pietrasiewicz wrote: > > Hi, > > > > W dniu 03.07.2020 o 13:06, Daniel Lezcano pisze: > > > On 03/07/2020 12:43, Andrzej Pietrasiewicz wrote: > > > > This short series contains fixes for "Stop monitoring disabled > > > > devices" > > > > series https://www.spinics.net/lists/arm-kernel/msg817861.html > > > > > > > > Invocation of thermal_zone_device_is_enabled() in acpi/thermal > > > > is now > > > > redundant, because thermal_zone_device_update() now is capable > > > > of > > > > handling disabled devices. > > > > > > > > In imx's ->get_temp() the lock must not be taken, otherwise a > > > > deadlock > > > > happens. The decision whether explicitly running a measurement > > > > cycle > > > > is needed is taken based on driver's local irq_enabled > > > > variable. > > > > > > > > Finally, thermal_zone_device_is_enabled() is made available to > > > > the > > > > core only, as there are no driver users of it. > > > > > > > > Andrzej Pietrasiewicz (3): > > > > acpi: thermal: Don't call thermal_zone_device_is_enabled() > > > > thermal: imx: Use driver's local data to decide whether to > > > > run a > > > > measurement > > > > thermal: Make thermal_zone_device_is_enabled() available to > > > > core only > > > > > > > > drivers/acpi/thermal.c | 3 --- > > > > drivers/thermal/imx_thermal.c | 7 ++++--- > > > > drivers/thermal/thermal_core.c | 1 - > > > > drivers/thermal/thermal_core.h | 2 ++ > > > > include/linux/thermal.h | 5 ----- > > > > 5 files changed, 6 insertions(+), 12 deletions(-) > > > > > > Is this series easily merge-able with the other series? > > > > > > > So-so. > > > > Some simple conflicts needed to be resolved. > > > > I have created a branch for you to look at and decide > > how far off it is from the original and whether the > > original Acked-by/Reviewed-by can be retained. > > > > Note that I might have lost some portions of code > > during conflict resolution. It seems to me I haven't > > but you know. > > > > The branch: > > > > https://gitlab.collabora.com/andrzej.p/kernel-tests/-/tree/thermal-dont-poll-disabled-for-daniel > > Ok, I propose to keep the these three patches on top of V7. > > Rui are you fine with that ? Yes, that works for me. thanks, rui > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6687C433DF for ; Sun, 5 Jul 2020 06:06:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97DC120771 for ; Sun, 5 Jul 2020 06:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U5sZ5N7O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97DC120771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=65KkVe31qWI5UrQ6YAQhWGCm2BrmhFGiMu+7qKhHAnY=; b=U5sZ5N7OOitjGBjbwj4aiBONS AucWZio5kEMTrz0fIUDPv2fSjQUDVoAjwYElODJ5wRZ3+Zs3JA+k+d7KQAoOh/RpPZJ00BjdcgE6l NTthx9x5m35P/EN1sj5ePDYfqaECugstHiX7WqOYK8NSMYxTe7YGN/TQtdvSL2dhPitKGwkczYLSL c0FunVZQdcNX2i1zdZOMs5/XhSOTSMqJsGZKopJ8njUuMgeytzxdoGXTBu6YWgdpGcVD2ujxrPnYl jmpcJwHNsUVqHey9A0D7RYTQAn7+hmbnRzWXmmIMXkJKL2wU2bNhNmJljnkiB82/HNHgd3fynBTIH DMNxDiiJQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrxlc-0004Ia-5d; Sun, 05 Jul 2020 06:04:44 +0000 Received: from mga02.intel.com ([134.134.136.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrxlZ-0004Hh-FH; Sun, 05 Jul 2020 06:04:42 +0000 IronPort-SDR: NfZjYGQFy8P8TH6xC0v/5bmlbGiRGObZxySMwjaQFthFi06ElMau3wL2rG/Z5J4SLG2LXKK3rX T5tsZ+x8s9Fg== X-IronPort-AV: E=McAfee;i="6000,8403,9672"; a="135553945" X-IronPort-AV: E=Sophos;i="5.75,314,1589266800"; d="scan'208";a="135553945" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2020 23:04:33 -0700 IronPort-SDR: RTZKJhnrLEZugPly4VtR2NDpLYKGxq/qbqDz6diM18IhrJLYpFDA0aIulzr5x/OJiPJ0R6pdFP RzzxPLYsn14A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,314,1589266800"; d="scan'208";a="282715546" Received: from yangblan-mobl2.ccr.corp.intel.com ([10.255.29.148]) by orsmga006.jf.intel.com with ESMTP; 04 Jul 2020 23:04:22 -0700 Message-ID: <9627f15fb2145525b40d6c1aed6752e13df876e9.camel@intel.com> Subject: Re: [PATCH 0/3] Fixes for stop monitoring disabled devices series From: Zhang Rui To: Daniel Lezcano , Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Date: Sun, 05 Jul 2020 14:04:21 +0800 In-Reply-To: <79ae59af-d3b9-852c-d5f3-5b80d9c6ea8c@linaro.org> References: <20200703104354.19657-1-andrzej.p@collabora.com> <91db4c89-0615-4a69-9695-ed5d3c42e1b7@collabora.com> <79ae59af-d3b9-852c-d5f3-5b80d9c6ea8c@linaro.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200705_020441_691315_F6975D90 X-CRM114-Status: GOOD ( 30.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emmanuel Grumbach , Heiko Stuebner , "Rafael J . Wysocki" , Vishal Kulkarni , Luca Coelho , Miquel Raynal , kernel@collabora.com, Fabio Estevam , Amit Kucheria , Chunyan Zhang , Bartlomiej Zolnierkiewicz , Allison Randal , NXP Linux Team , Darren Hart , Gayatri Kammela , Len Brown , Johannes Berg , Intel Linux Wireless , Sascha Hauer , Ido Schimmel , Baolin Wang , Jiri Pirko , Orson Zhai , Thomas Gleixner , Kalle Valo , Support Opensource , Enrico Weigelt , Peter Kaestle , Sebastian Reichel , Pengutronix Kernel Team , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Shawn Guo , "David S . Miller" , Andy Shevchenko Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-07-03 at 14:05 +0200, Daniel Lezcano wrote: > On 03/07/2020 13:57, Andrzej Pietrasiewicz wrote: > > Hi, > > > > W dniu 03.07.2020 o 13:06, Daniel Lezcano pisze: > > > On 03/07/2020 12:43, Andrzej Pietrasiewicz wrote: > > > > This short series contains fixes for "Stop monitoring disabled > > > > devices" > > > > series https://www.spinics.net/lists/arm-kernel/msg817861.html > > > > > > > > Invocation of thermal_zone_device_is_enabled() in acpi/thermal > > > > is now > > > > redundant, because thermal_zone_device_update() now is capable > > > > of > > > > handling disabled devices. > > > > > > > > In imx's ->get_temp() the lock must not be taken, otherwise a > > > > deadlock > > > > happens. The decision whether explicitly running a measurement > > > > cycle > > > > is needed is taken based on driver's local irq_enabled > > > > variable. > > > > > > > > Finally, thermal_zone_device_is_enabled() is made available to > > > > the > > > > core only, as there are no driver users of it. > > > > > > > > Andrzej Pietrasiewicz (3): > > > > acpi: thermal: Don't call thermal_zone_device_is_enabled() > > > > thermal: imx: Use driver's local data to decide whether to > > > > run a > > > > measurement > > > > thermal: Make thermal_zone_device_is_enabled() available to > > > > core only > > > > > > > > drivers/acpi/thermal.c | 3 --- > > > > drivers/thermal/imx_thermal.c | 7 ++++--- > > > > drivers/thermal/thermal_core.c | 1 - > > > > drivers/thermal/thermal_core.h | 2 ++ > > > > include/linux/thermal.h | 5 ----- > > > > 5 files changed, 6 insertions(+), 12 deletions(-) > > > > > > Is this series easily merge-able with the other series? > > > > > > > So-so. > > > > Some simple conflicts needed to be resolved. > > > > I have created a branch for you to look at and decide > > how far off it is from the original and whether the > > original Acked-by/Reviewed-by can be retained. > > > > Note that I might have lost some portions of code > > during conflict resolution. It seems to me I haven't > > but you know. > > > > The branch: > > > > https://gitlab.collabora.com/andrzej.p/kernel-tests/-/tree/thermal-dont-poll-disabled-for-daniel > > Ok, I propose to keep the these three patches on top of V7. > > Rui are you fine with that ? Yes, that works for me. thanks, rui > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel