From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A34AC48260 for ; Fri, 16 Feb 2024 17:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pzvilarmPI9+kkH82s8iVvCWne1ujhb7aKeq9alPkyM=; b=r4MdBg1Dk71q5s pfH9oPYZcBkz42p94nHSVg++xrjWNKiwUhBoQ7HScwuKjgbRgq2Ajm2NBUVaf/l1VcHi4VIE28kpF EBjYC3LKuryDnr9SWKjWoPeFCd5pZzQXzVSy34EnUqiUK5HXJTz3Erk+hkdN+WkXsVL2QO7N6tz6Z NBNF65nVD6jWCRjgFeE/JODZsCImAvyP4rCYWY15SmWi5zVQmn0yOvZc3oXPlCD+N1mMCVuzMGaSP 61jvQD8MB+MDrOxDbM39VFhiit1D0j4gcVmy7Yc07vTOmA6oQZFkFSr1+HTayCgIc4J+hUnbkoli6 ucaPk530uiOzRQQ6eumA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb1pY-00000003AF5-45jq; Fri, 16 Feb 2024 17:16:56 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb1pT-00000003AB4-3nGN for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 17:16:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=l9mYR212SPf+R9mwmI8TrJIzfSG5c5mRs1Qtd2wu1Xk=; b=4LoqQsbW0LUQvAGL26r5DYs7C2 N6jZG5oN0YVkqrD4JZ0CSnYCKKVwGtrc0DcawUGSO88B8jpSh7Un3PuVuROheCX/nDDBI8sRrZ6RV RmMWNkhMQLn6JT1XnZx/JLj4Cw67ryxo7c6vCWV0s2ye1u3dw0cfpC3cgoZtLHjxC+7Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rb1pT-00805C-TI; Fri, 16 Feb 2024 18:16:51 +0100 Date: Fri, 16 Feb 2024 18:16:51 +0100 From: Andrew Lunn To: Kathiravan Thirumoorthy Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Message-ID: <9638a213-76a5-4a72-b6b2-018ae50305be@lunn.ch> References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> <11fda059-3d8d-4030-922a-8fef16349a65@quicinc.com> <17e2400e-6881-4e9e-90c2-9c4f77a0d41d@lunn.ch> <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_091652_006096_D7518143 X-CRM114-Status: GOOD ( 10.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > You can get the source at https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016/-/tree/NHSS.QSDK.12.2?ref_type=heads Cool, thanks. But is it really u-boot from 2016? > Yeah agree with your comments. > > QSDK's u-boot enables the network support, so the required NSSCC clocks are > turned ON and left it in ON state. CCF tries to disables the unused NSSCC > clocks but system goes for reboot. > > Reason being, to access the NSSCC clocks, these GCC clocks > (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) > should be turned ON. But CCF disables these clocks as well due to the lack > of consumer. So there is your solution, make NSSCC a consumer of the clocks it actually consumes. If it needs these clocks, it should get and enable them. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50D9C1E53F; Fri, 16 Feb 2024 17:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103810; cv=none; b=syUhZlItkmtED7m4c58JqHP0/4uBsvMD2AKRnka0Eoy92JiL/wJl+ZFuqI/1uevlKXus4rI+OoRyZqxe+EJCqmW97fQVkPBaNUHJR8eWJ7JAsN/ghnfIzqVzFoFLLvEnV0oRrfu8IytiiFPEXMqUorNF8v0inRBQgrPbeQl/WAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708103810; c=relaxed/simple; bh=3pfy3uw6X4A5yd7ITUWZQtrvTmTq4SidsDEt+RRdoz0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rc4OOiOKr4p04QAZumePrFcGtytfk9aUPO+4HfC4wSa/sTCjKnCUf4peIpsgb9+Cr1aiir5DBTwR974AaFj0XcY7OoOdffLYbp8HR71+ujOz/aP2T1hq7QpYqpMkebOKr7wyIr2CLiqpR82Gy4mab1yiFu7brmmZLiqsKmqaJFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=4LoqQsbW; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4LoqQsbW" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=l9mYR212SPf+R9mwmI8TrJIzfSG5c5mRs1Qtd2wu1Xk=; b=4LoqQsbW0LUQvAGL26r5DYs7C2 N6jZG5oN0YVkqrD4JZ0CSnYCKKVwGtrc0DcawUGSO88B8jpSh7Un3PuVuROheCX/nDDBI8sRrZ6RV RmMWNkhMQLn6JT1XnZx/JLj4Cw67ryxo7c6vCWV0s2ye1u3dw0cfpC3cgoZtLHjxC+7Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rb1pT-00805C-TI; Fri, 16 Feb 2024 18:16:51 +0100 Date: Fri, 16 Feb 2024 18:16:51 +0100 From: Andrew Lunn To: Kathiravan Thirumoorthy Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Message-ID: <9638a213-76a5-4a72-b6b2-018ae50305be@lunn.ch> References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> <11fda059-3d8d-4030-922a-8fef16349a65@quicinc.com> <17e2400e-6881-4e9e-90c2-9c4f77a0d41d@lunn.ch> <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c9ee34c-a97b-4acf-a093-9ac2afc28d0e@quicinc.com> > You can get the source at https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016/-/tree/NHSS.QSDK.12.2?ref_type=heads Cool, thanks. But is it really u-boot from 2016? > Yeah agree with your comments. > > QSDK's u-boot enables the network support, so the required NSSCC clocks are > turned ON and left it in ON state. CCF tries to disables the unused NSSCC > clocks but system goes for reboot. > > Reason being, to access the NSSCC clocks, these GCC clocks > (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk) > should be turned ON. But CCF disables these clocks as well due to the lack > of consumer. So there is your solution, make NSSCC a consumer of the clocks it actually consumes. If it needs these clocks, it should get and enable them. Andrew