* Re: [PATCH v2 1/2] xen: Silence compiler warnings
@ 2014-07-28 21:38 Daniel Kiper
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Kiper @ 2014-07-28 21:38 UTC (permalink / raw)
To: david.vrabel
Cc: boris.ostrovsky, konrad.wilk, stefano.stabellini, matt.fleming,
xen-devel, ian.campbell, tglx, andrew.cooper3, jeremy, hpa,
jbeulich, mingo, x86, linux-kernel
David,
> On 12/07/14 22:09, Daniel Kiper wrote:
> > Add inline keyword to silence the following compiler
> > warnings if xen_efi_probe() is not used:
>
> The title and should be:
>
> xen: make stub xen_efi_probe() static inline
>
> Empty stub functions in headers should be inline or the compiler
> will warn that it is unused.
>
> Do you want this to go via the Xen tree or the EFI one?
Thanks for your comment but as I can see it was
taken by Matt and now it is a part of tip.
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] xen: Silence compiler warnings
@ 2014-07-28 21:38 Daniel Kiper
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Kiper @ 2014-07-28 21:38 UTC (permalink / raw)
To: david.vrabel
Cc: jeremy, matt.fleming, ian.campbell, stefano.stabellini,
andrew.cooper3, x86, linux-kernel, mingo, jbeulich, hpa,
xen-devel, boris.ostrovsky, tglx
David,
> On 12/07/14 22:09, Daniel Kiper wrote:
> > Add inline keyword to silence the following compiler
> > warnings if xen_efi_probe() is not used:
>
> The title and should be:
>
> xen: make stub xen_efi_probe() static inline
>
> Empty stub functions in headers should be inline or the compiler
> will warn that it is unused.
>
> Do you want this to go via the Xen tree or the EFI one?
Thanks for your comment but as I can see it was
taken by Matt and now it is a part of tip.
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] xen: Silence compiler warnings
2014-07-12 21:09 ` [PATCH v2 1/2] " Daniel Kiper
@ 2014-07-28 13:11 ` David Vrabel
2014-07-13 9:59 ` Konrad Rzeszutek Wilk
2014-07-28 13:11 ` David Vrabel
2 siblings, 0 replies; 8+ messages in thread
From: David Vrabel @ 2014-07-28 13:11 UTC (permalink / raw)
To: Daniel Kiper, linux-kernel, x86, xen-devel
Cc: andrew.cooper3, boris.ostrovsky, hpa, ian.campbell, jbeulich,
jeremy, konrad.wilk, matt.fleming, mingo, stefano.stabellini,
tglx
On 12/07/14 22:09, Daniel Kiper wrote:
> Add inline keyword to silence the following compiler
> warnings if xen_efi_probe() is not used:
The title and should be:
xen: make stub xen_efi_probe() static inline
Empty stub functions in headers should be inline or the compiler
will warn that it is unused.
Do you want this to go via the Xen tree or the EFI one?
David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] xen: Silence compiler warnings
@ 2014-07-28 13:11 ` David Vrabel
0 siblings, 0 replies; 8+ messages in thread
From: David Vrabel @ 2014-07-28 13:11 UTC (permalink / raw)
To: Daniel Kiper, linux-kernel, x86, xen-devel
Cc: jeremy, matt.fleming, ian.campbell, andrew.cooper3,
stefano.stabellini, mingo, jbeulich, hpa, boris.ostrovsky, tglx
On 12/07/14 22:09, Daniel Kiper wrote:
> Add inline keyword to silence the following compiler
> warnings if xen_efi_probe() is not used:
The title and should be:
xen: make stub xen_efi_probe() static inline
Empty stub functions in headers should be inline or the compiler
will warn that it is unused.
Do you want this to go via the Xen tree or the EFI one?
David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] xen: Silence compiler warnings
2014-07-12 21:09 ` [PATCH v2 1/2] " Daniel Kiper
@ 2014-07-13 9:59 ` Konrad Rzeszutek Wilk
2014-07-13 9:59 ` Konrad Rzeszutek Wilk
2014-07-28 13:11 ` David Vrabel
2 siblings, 0 replies; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-07-13 9:59 UTC (permalink / raw)
To: Daniel Kiper, linux-kernel, x86, xen-devel
Cc: andrew.cooper3, boris.ostrovsky, david.vrabel, hpa, ian.campbell,
jbeulich, jeremy, matt.fleming, mingo, stefano.stabellini, tglx
On July 12, 2014 5:09:47 PM EDT, Daniel Kiper <daniel.kiper@oracle.com> wrote:
>Add inline keyword to silence the following compiler
>warnings if xen_efi_probe() is not used:
>
> CC arch/x86/xen/setup.o
>In file included from arch/x86/xen/xen-ops.h:7:0,
> from arch/x86/xen/setup.c:31:
>include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not
>used [-Wunused-function]
>
>Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
>---
> include/xen/xen-ops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>index 771bbba..7491ee5 100644
>--- a/include/xen/xen-ops.h
>+++ b/include/xen/xen-ops.h
>@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int
>major, unsigned int minor);
> #ifdef CONFIG_XEN_EFI
> extern efi_system_table_t *xen_efi_probe(void);
> #else
>-static efi_system_table_t __init *xen_efi_probe(void)
>+static inline efi_system_table_t __init *xen_efi_probe(void)
> {
> return NULL;
> }
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] xen: Silence compiler warnings
2014-07-12 21:09 ` [PATCH v2 1/2] " Daniel Kiper
2014-07-13 9:59 ` Konrad Rzeszutek Wilk
@ 2014-07-13 9:59 ` Konrad Rzeszutek Wilk
2014-07-28 13:11 ` David Vrabel
2 siblings, 0 replies; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-07-13 9:59 UTC (permalink / raw)
To: Daniel Kiper, linux-kernel, x86, xen-devel
Cc: jeremy, matt.fleming, ian.campbell, stefano.stabellini,
andrew.cooper3, mingo, david.vrabel, jbeulich, hpa,
boris.ostrovsky, tglx
On July 12, 2014 5:09:47 PM EDT, Daniel Kiper <daniel.kiper@oracle.com> wrote:
>Add inline keyword to silence the following compiler
>warnings if xen_efi_probe() is not used:
>
> CC arch/x86/xen/setup.o
>In file included from arch/x86/xen/xen-ops.h:7:0,
> from arch/x86/xen/setup.c:31:
>include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not
>used [-Wunused-function]
>
>Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
>---
> include/xen/xen-ops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>index 771bbba..7491ee5 100644
>--- a/include/xen/xen-ops.h
>+++ b/include/xen/xen-ops.h
>@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int
>major, unsigned int minor);
> #ifdef CONFIG_XEN_EFI
> extern efi_system_table_t *xen_efi_probe(void);
> #else
>-static efi_system_table_t __init *xen_efi_probe(void)
>+static inline efi_system_table_t __init *xen_efi_probe(void)
> {
> return NULL;
> }
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] xen: Silence compiler warnings
2014-07-12 21:09 [PATCH v2 0/2] " Daniel Kiper
@ 2014-07-12 21:09 ` Daniel Kiper
2014-07-13 9:59 ` Konrad Rzeszutek Wilk
` (2 more replies)
2014-07-12 21:09 ` Daniel Kiper
1 sibling, 3 replies; 8+ messages in thread
From: Daniel Kiper @ 2014-07-12 21:09 UTC (permalink / raw)
To: linux-kernel, x86, xen-devel
Cc: andrew.cooper3, boris.ostrovsky, david.vrabel, hpa, ian.campbell,
jbeulich, jeremy, konrad.wilk, matt.fleming, mingo,
stefano.stabellini, tglx
Add inline keyword to silence the following compiler
warnings if xen_efi_probe() is not used:
CC arch/x86/xen/setup.o
In file included from arch/x86/xen/xen-ops.h:7:0,
from arch/x86/xen/setup.c:31:
include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not used [-Wunused-function]
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
include/xen/xen-ops.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 771bbba..7491ee5 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int major, unsigned int minor);
#ifdef CONFIG_XEN_EFI
extern efi_system_table_t *xen_efi_probe(void);
#else
-static efi_system_table_t __init *xen_efi_probe(void)
+static inline efi_system_table_t __init *xen_efi_probe(void)
{
return NULL;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] xen: Silence compiler warnings
2014-07-12 21:09 [PATCH v2 0/2] " Daniel Kiper
2014-07-12 21:09 ` [PATCH v2 1/2] " Daniel Kiper
@ 2014-07-12 21:09 ` Daniel Kiper
1 sibling, 0 replies; 8+ messages in thread
From: Daniel Kiper @ 2014-07-12 21:09 UTC (permalink / raw)
To: linux-kernel, x86, xen-devel
Cc: jeremy, matt.fleming, ian.campbell, andrew.cooper3,
stefano.stabellini, mingo, david.vrabel, jbeulich, hpa,
boris.ostrovsky, tglx
Add inline keyword to silence the following compiler
warnings if xen_efi_probe() is not used:
CC arch/x86/xen/setup.o
In file included from arch/x86/xen/xen-ops.h:7:0,
from arch/x86/xen/setup.c:31:
include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not used [-Wunused-function]
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
include/xen/xen-ops.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 771bbba..7491ee5 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int major, unsigned int minor);
#ifdef CONFIG_XEN_EFI
extern efi_system_table_t *xen_efi_probe(void);
#else
-static efi_system_table_t __init *xen_efi_probe(void)
+static inline efi_system_table_t __init *xen_efi_probe(void)
{
return NULL;
}
--
1.7.10.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-07-28 21:38 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-28 21:38 [PATCH v2 1/2] xen: Silence compiler warnings Daniel Kiper
-- strict thread matches above, loose matches on Subject: below --
2014-07-28 21:38 Daniel Kiper
2014-07-12 21:09 [PATCH v2 0/2] " Daniel Kiper
2014-07-12 21:09 ` [PATCH v2 1/2] " Daniel Kiper
2014-07-13 9:59 ` Konrad Rzeszutek Wilk
2014-07-13 9:59 ` Konrad Rzeszutek Wilk
2014-07-28 13:11 ` David Vrabel
2014-07-28 13:11 ` David Vrabel
2014-07-12 21:09 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.