From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71666C43334 for ; Wed, 29 Jun 2022 13:46:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbiF2Nqf (ORCPT ); Wed, 29 Jun 2022 09:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbiF2Nqe (ORCPT ); Wed, 29 Jun 2022 09:46:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E475113E8A for ; Wed, 29 Jun 2022 06:46:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A30C61E67 for ; Wed, 29 Jun 2022 13:46:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98D8AC34114; Wed, 29 Jun 2022 13:46:29 +0000 (UTC) Message-ID: <965196fe-4655-f051-5c61-cc478d126e69@xs4all.nl> Date: Wed, 29 Jun 2022 15:46:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/7] media: v4l: Add packed YUV 4:4:4 YUVA and YUVX pixel formats Content-Language: en-US To: Laurent Pinchart , linux-media@vger.kernel.org Cc: Sakari Ailus , Jacopo Mondi , Xavier Roumegue , linux-imx@nxp.com, kernel@pengutronix.de References: <20220616183656.19089-1-laurent.pinchart@ideasonboard.com> <20220616183656.19089-2-laurent.pinchart@ideasonboard.com> From: Hans Verkuil In-Reply-To: <20220616183656.19089-2-laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 16/06/2022 20:36, Laurent Pinchart wrote: > The new YUVA and YUVX are permutations of the existing AYUV and XYUV > formats. They are use by the NXP i.MX8 ISI hardware. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Nicolas Dufresne > Reviewed-by: Jacopo Mondi Reviewed-by: Hans Verkuil Regards, Hans > --- > .../media/v4l/pixfmt-packed-yuv.rst | 20 +++++++++++++++++++ > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > include/uapi/linux/videodev2.h | 2 ++ > 3 files changed, 24 insertions(+) > > diff --git a/Documentation/userspace-api/media/v4l/pixfmt-packed-yuv.rst b/Documentation/userspace-api/media/v4l/pixfmt-packed-yuv.rst > index 65520c3af7cf..bf283a1b5581 100644 > --- a/Documentation/userspace-api/media/v4l/pixfmt-packed-yuv.rst > +++ b/Documentation/userspace-api/media/v4l/pixfmt-packed-yuv.rst > @@ -220,6 +220,26 @@ the second byte and Y'\ :sub:`7-0` in the third byte. > - Y'\ :sub:`7-0` > - X\ :sub:`7-0` > > + * .. _V4L2-PIX-FMT-YUVA32: > + > + - ``V4L2_PIX_FMT_YUVA32`` > + - 'YUVA' > + > + - Y'\ :sub:`7-0` > + - Cb\ :sub:`7-0` > + - Cr\ :sub:`7-0` > + - A\ :sub:`7-0` > + > + * .. _V4L2-PIX-FMT-YUVX32: > + > + - ``V4L2_PIX_FMT_YUVX32`` > + - 'YUVX' > + > + - Y'\ :sub:`7-0` > + - Cb\ :sub:`7-0` > + - Cr\ :sub:`7-0` > + - X\ :sub:`7-0` > + > * .. _V4L2-PIX-FMT-YUV24: > > - ``V4L2_PIX_FMT_YUV24`` > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index f42f7ffcc247..18ed2227255a 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1297,6 +1297,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_PIX_FMT_XYUV32: descr = "32-bit XYUV 8-8-8-8"; break; > case V4L2_PIX_FMT_VUYA32: descr = "32-bit VUYA 8-8-8-8"; break; > case V4L2_PIX_FMT_VUYX32: descr = "32-bit VUYX 8-8-8-8"; break; > + case V4L2_PIX_FMT_YUVA32: descr = "32-bit YUVA 8-8-8-8"; break; > + case V4L2_PIX_FMT_YUVX32: descr = "32-bit YUVX 8-8-8-8"; break; > case V4L2_PIX_FMT_YUV410: descr = "Planar YUV 4:1:0"; break; > case V4L2_PIX_FMT_YUV420: descr = "Planar YUV 4:2:0"; break; > case V4L2_PIX_FMT_HI240: descr = "8-bit Dithered RGB (BTTV)"; break; > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 343b95107fce..f6f9a690971e 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -593,6 +593,8 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_XYUV32 v4l2_fourcc('X', 'Y', 'U', 'V') /* 32 XYUV-8-8-8-8 */ > #define V4L2_PIX_FMT_VUYA32 v4l2_fourcc('V', 'U', 'Y', 'A') /* 32 VUYA-8-8-8-8 */ > #define V4L2_PIX_FMT_VUYX32 v4l2_fourcc('V', 'U', 'Y', 'X') /* 32 VUYX-8-8-8-8 */ > +#define V4L2_PIX_FMT_YUVA32 v4l2_fourcc('Y', 'U', 'V', 'A') /* 32 YUVA-8-8-8-8 */ > +#define V4L2_PIX_FMT_YUVX32 v4l2_fourcc('Y', 'U', 'V', 'X') /* 32 YUVX-8-8-8-8 */ > #define V4L2_PIX_FMT_M420 v4l2_fourcc('M', '4', '2', '0') /* 12 YUV 4:2:0 2 lines y, 1 line uv interleaved */ > > /* two planes -- one Y, one Cr + Cb interleaved */