From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E20C433EF for ; Tue, 16 Nov 2021 02:25:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C6A460EFE for ; Tue, 16 Nov 2021 02:25:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C6A460EFE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11DFB6E174; Tue, 16 Nov 2021 02:25:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB5476E174 for ; Tue, 16 Nov 2021 02:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=wMEYwRnfQ2uN4NJH/LcIFcvyTglWJNpL//1mKWSrSgU=; b=RhqpbimsYD1BWAnU3z1ctqHHKC TuPNkjJmJaOoArc+a98Y8HBDZK13pLds2cBvSnGuuWzoYNu6OZRbLbu8npdYNvp7dDpVeQAtvl+y5 nVc567zTVAD5z9pMQz3hZT8uHmtzweseckZsDPqOKCh24jGTJd2GRwapDqKPkYUBjkN+3aaaFuxYk l54fTdgEQuhnrQGPIACYm0vTX8KEu7oEEB2jRwJYh/qKQoN1Ieel2lY5K/FFAhdyDhlUAzUioh+Ii 8079FpsoOfO76pDBAC/qSovlWqOvQW0VUJg39lj2DGARc0IS6i0D898aa64Kcr5/N3IVp+bLHbzfJ 63p/9i9Q==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmo9k-000400-QM; Tue, 16 Nov 2021 02:25:08 +0000 Subject: Re: [PATCH] backlight: ili922x: fix kernel-doc warnings & notation To: Daniel Thompson References: <20211115033925.22024-1-rdunlap@infradead.org> <20211115113832.rsdx3ziuujrobwxx@maple.lan> From: Randy Dunlap Message-ID: <9671cd29-aa9c-c93b-4bcd-43d4300a2e7c@infradead.org> Date: Mon, 15 Nov 2021 18:25:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211115113832.rsdx3ziuujrobwxx@maple.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Anatolij Gustschin , Lee Jones , Stefano Babic Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/15/21 3:38 AM, Daniel Thompson wrote: > > Thanks for the fixes. Just a could of quibbles about full > stops/periods. > > >> --- >> drivers/video/backlight/ili922x.c | 29 ++++++++++++++++++---------- >> 1 file changed, 19 insertions(+), 10 deletions(-) >> >> --- linux-next-20211102.orig/drivers/video/backlight/ili922x.c >> +++ linux-next-20211102/drivers/video/backlight/ili922x.c >> /** >> - * CHECK_FREQ_REG(spi_device s, spi_transfer x) - Check the frequency >> - * for the SPI transfer. According to the datasheet, the controller >> - * accept higher frequency for the GRAM transfer, but it requires >> + * CHECK_FREQ_REG() - Check the frequency for the SPI transfer >> + * According to the datasheet, the controller >> + * accepts higher frequency for the GRAM transfer, but it requires > > Also missing the full stop/period in the first sentence of the summary. > > Note that here the missing full stop does not benefit from a new line to > conceal it and we will generate bad text as a result. > > Check the frequency for the SPI transfer According to the data > sheet, the controller accepts... Got it. I'll send a v2. Thanks. -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9CCC433F5 for ; Tue, 16 Nov 2021 05:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F141461BF9 for ; Tue, 16 Nov 2021 05:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232963AbhKPFVb (ORCPT ); Tue, 16 Nov 2021 00:21:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232615AbhKPFVT (ORCPT ); Tue, 16 Nov 2021 00:21:19 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 298F2C2D7650 for ; Mon, 15 Nov 2021 18:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=wMEYwRnfQ2uN4NJH/LcIFcvyTglWJNpL//1mKWSrSgU=; b=RhqpbimsYD1BWAnU3z1ctqHHKC TuPNkjJmJaOoArc+a98Y8HBDZK13pLds2cBvSnGuuWzoYNu6OZRbLbu8npdYNvp7dDpVeQAtvl+y5 nVc567zTVAD5z9pMQz3hZT8uHmtzweseckZsDPqOKCh24jGTJd2GRwapDqKPkYUBjkN+3aaaFuxYk l54fTdgEQuhnrQGPIACYm0vTX8KEu7oEEB2jRwJYh/qKQoN1Ieel2lY5K/FFAhdyDhlUAzUioh+Ii 8079FpsoOfO76pDBAC/qSovlWqOvQW0VUJg39lj2DGARc0IS6i0D898aa64Kcr5/N3IVp+bLHbzfJ 63p/9i9Q==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmo9k-000400-QM; Tue, 16 Nov 2021 02:25:08 +0000 Subject: Re: [PATCH] backlight: ili922x: fix kernel-doc warnings & notation To: Daniel Thompson Cc: linux-kernel@vger.kernel.org, kernel test robot , Lee Jones , Jingoo Han , dri-devel@lists.freedesktop.org, Stefano Babic , Anatolij Gustschin References: <20211115033925.22024-1-rdunlap@infradead.org> <20211115113832.rsdx3ziuujrobwxx@maple.lan> From: Randy Dunlap Message-ID: <9671cd29-aa9c-c93b-4bcd-43d4300a2e7c@infradead.org> Date: Mon, 15 Nov 2021 18:25:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211115113832.rsdx3ziuujrobwxx@maple.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/21 3:38 AM, Daniel Thompson wrote: > > Thanks for the fixes. Just a could of quibbles about full > stops/periods. > > >> --- >> drivers/video/backlight/ili922x.c | 29 ++++++++++++++++++---------- >> 1 file changed, 19 insertions(+), 10 deletions(-) >> >> --- linux-next-20211102.orig/drivers/video/backlight/ili922x.c >> +++ linux-next-20211102/drivers/video/backlight/ili922x.c >> /** >> - * CHECK_FREQ_REG(spi_device s, spi_transfer x) - Check the frequency >> - * for the SPI transfer. According to the datasheet, the controller >> - * accept higher frequency for the GRAM transfer, but it requires >> + * CHECK_FREQ_REG() - Check the frequency for the SPI transfer >> + * According to the datasheet, the controller >> + * accepts higher frequency for the GRAM transfer, but it requires > > Also missing the full stop/period in the first sentence of the summary. > > Note that here the missing full stop does not benefit from a new line to > conceal it and we will generate bad text as a result. > > Check the frequency for the SPI transfer According to the data > sheet, the controller accepts... Got it. I'll send a v2. Thanks. -- ~Randy