From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF6AC4361B for ; Fri, 4 Dec 2020 16:25:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E1F2229C4 for ; Fri, 4 Dec 2020 16:25:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E1F2229C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.44943.80387 (Exim 4.92) (envelope-from ) id 1klDtY-0005ID-E8; Fri, 04 Dec 2020 16:25:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 44943.80387; Fri, 04 Dec 2020 16:25:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1klDtY-0005I6-Ac; Fri, 04 Dec 2020 16:25:20 +0000 Received: by outflank-mailman (input) for mailman id 44943; Fri, 04 Dec 2020 16:25:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1klDtX-0005I1-42 for xen-devel@lists.xenproject.org; Fri, 04 Dec 2020 16:25:19 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0d7b34b8-e71c-46b7-b9b8-76d04880ed6a; Fri, 04 Dec 2020 16:25:18 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 69512AC9A; Fri, 4 Dec 2020 16:25:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d7b34b8-e71c-46b7-b9b8-76d04880ed6a X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607099117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wCzY4tbIDpH0VVSO04WM5bndyi7WKIj6iiHn8DqcabU=; b=tOgvqskCaj3dWuLFXRr/D9VhuuzltZTHsNskMEoPPZKrOM13thR+ng45ha2wkM/1pRUBpi W6l9pepcYHAgg2312Y/csXigj1onHSVD4qJbRmhswbE+4BRtQ/IC4iyHQVY1Stm8J9iRBW CCD+5fqt3NymCfcgzYA0aeXssnT8aLE= Message-ID: <967454f248c521e51b0a1be27b7d38fe243ce54e.camel@suse.com> Subject: Re: [PATCH v2 05/17] xen/cpupool: switch cpupool list to normal list interface From: Dario Faggioli To: =?ISO-8859-1?Q?J=FCrgen_Gro=DF?= , Jan Beulich Cc: George Dunlap , xen-devel@lists.xenproject.org Date: Fri, 04 Dec 2020 17:25:16 +0100 In-Reply-To: <76e7d00f-b049-97fc-f9e2-ade76b10a93e@suse.com> References: <20201201082128.15239-1-jgross@suse.com> <20201201082128.15239-6-jgross@suse.com> <54301d8c-2d69-3206-6c42-d2638b7e7aa3@suse.com> <76e7d00f-b049-97fc-f9e2-ade76b10a93e@suse.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-tkkM7bhpV4NNs/gEUX5h" User-Agent: Evolution 3.38.2 (by Flathub.org) MIME-Version: 1.0 --=-tkkM7bhpV4NNs/gEUX5h Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2020-12-04 at 17:16 +0100, J=C3=BCrgen Gro=C3=9F wrote: > On 04.12.20 17:13, Dario Faggioli wrote: > >=20 > >=20 > > What I'd do is: > > =C2=A0 - add a comment here, explaining quickly exactly this fact, i.e.= , > > =C2=A0=C2=A0=C2=A0 that it's not that we've forgotten to deal with this= and it's > > all > > =C2=A0=C2=A0=C2=A0 on=C2=A0purpose. Actually, it can be either a commen= t here or it can > > be > > =C2=A0=C2=A0=C2=A0 mentioned in the changelog. I'm fine either way > > =C2=A0 - if we're concerned about someone doing: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for i=3D1...N { xl cpupool-create foo ba= r } > > =C2=A0=C2=A0=C2=A0 with N ending up being some giant number, e.g., by m= istake, I > > don't > > =C2=A0=C2=A0=C2=A0 think it's unreasonable to come up with an high enou= gh (but > > =C2=A0=C2=A0=C2=A0 certainly not in the billions!) MAX_CPUPOOLS, and st= op creating > > new > > =C2=A0=C2=A0=C2=A0 ones when we reach that level. >=20 > Do you agree that this could be another patch? >=20 Ah, yes, sorry, got carried away and forgot to mention that! Of course it should be in another patch... But indeed I should have stated that clearly. So, trying to do better this time round: - the comment can/should be added as part of this patch. But I'm now much more=C2=A0convinced=C2=A0that a quick mention in the changelog (still of this patch) is=C2=A0actually better; - any "solution" (Jan's or MAX_CPUPOOLS) should go in its own patch. > I'm not introducing that (theoretical) problem here. >=20 Indeed. Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-tkkM7bhpV4NNs/gEUX5h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl/KYuwACgkQFkJ4iaW4 c+61yhAAiFAyIW7eZ3o7XapgC2t8iDJzOpKwvbOIfnpPXHqeIR6tOpJVxtPSL36E 6RVNZ7DiilBizjF3aJ2WBKRsDpldfePBciUnDqcMkFLUDhqtDC/GBh2flSzB8twl PcfQB15sKhYAKkDN1UNad05CfVDT7jmuDZfB0iTOf78bHKS5YMPcOFUJweeCYUCe R47D8aIKqb+jdLg2rluKAt3gt+nmXesBUyGrV7DUMRoEd2ZuaCX8c++AXut0f7sd E4z+X1EOaqnzY8dQYRJeIXvl6ZJsDTFVR2hkIfBJnXfpo9nJ1i7xnWIn5tPvJDxp W6ihe8MUeRCcUN7CkxnH6exKQhoAjsKNOiynLPDbiY5IicvPgAUjHrY8srbgxZJ6 BAElKkdZot4oGfi7+++vKhAQ9HWX6JU8fHw30PdJCZzr6vQ5B1SHEbCo5eD4cviF FgiHMjd6yTmEQgkE9uPIB/1P+LfEzvzjC065RnqDHD33PX7Oyjz92zUPYuTD72eu nA5NZr8k/daCDjkKGX/tvu2t4+Plt1g/+Hv2JiCBDgxdrXJXi9FbzCv1Zhnu+ibr PuoFSMUpnHOuDrMJiFCxcv3ohk0iNBW+Pp2YIvNZ0HL3xlcSHxVGsBSofR7Oz1lH DNafHI0kTp8zYCBumlj9MDYzcrpJao438fbTHzsmevRMG1uQ8bI= =hDDv -----END PGP SIGNATURE----- --=-tkkM7bhpV4NNs/gEUX5h--