From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCJvu-00069Y-AJ for qemu-devel@nongnu.org; Tue, 16 Oct 2018 03:38:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCJvq-0003jS-83 for qemu-devel@nongnu.org; Tue, 16 Oct 2018 03:38:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45148) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gCJvk-0003aL-FH for qemu-devel@nongnu.org; Tue, 16 Oct 2018 03:38:20 -0400 Message-ID: <967af677f4d0b60bfb201f639ade0b0712e09fc8.camel@redhat.com> From: Andrea Bolognani Date: Tue, 16 Oct 2018 09:38:08 +0200 In-Reply-To: References: <5dd21056229d12a1af8d65e9208f4de43ba4a2ae.camel@redhat.com> <892d54c5-2851-74ec-bdf2-286c1665c44f@gmail.com> <7d54ec114745b00b82601875416ccfe6a5f9fe6f.camel@redhat.com> <23d9891ec01bec45b16f89ba1412238be39addf9.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/5] Connect a PCIe host and graphics support to RISC-V List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Alistair Francis , "qemu-devel@nongnu.org Developers" , Michael Clark , Palmer Dabbelt , stephen@eideticom.com, "Richard W.M. Jones" On Mon, 2018-10-15 at 09:59 -0700, Alistair Francis wrote: > On Mon, Oct 15, 2018 at 7:39 AM Andrea Bolognani wrote: > > One more thing that I forgot to bring up earlier: at the same time > > as PCIe support is added, we should also make sure that the > > pcie-root-port device is built into the qemu-system-riscv* binaries > > by default, as that device being missing will cause PCI-enabled > > libvirt guests to fail to start. > > We are dong that aren't we? Doesn't look that way: $ riscv64-softmmu/qemu-system-riscv64 -device help 2>&1 | head -5 Controller/Bridge/Hub devices: name "pci-bridge", bus PCI, desc "Standard PCI Bridge" name "pci-bridge-seat", bus PCI, desc "Standard PCI Bridge (multiseat)" name "vfio-pci-igd-lpc-bridge", bus PCI, desc "VFIO dummy ISA/LPC bridge for IGD assignment" $ Looking at the output of '-device help' in its entirety, I think there's a lot of stuff in there that doesn't quite belong with a RISC-V guest and that it would probably make sense to compile out. -- Andrea Bolognani / Red Hat / Virtualization