From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbdJRPyo (ORCPT ); Wed, 18 Oct 2017 11:54:44 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:52200 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbdJRPyn (ORCPT ); Wed, 18 Oct 2017 11:54:43 -0400 X-Google-Smtp-Source: ABhQp+QLczrcCQ8OVOgf36GfEiveVj7kIx8FO1T/LWcIdkKd1jK4TEzSsknL8UQGDPTjT0i3Rv7kvw== Subject: Re: [PATCH] thermal/drivers/hisi: disable multi alarm support for hi3660 SoC To: Tao Wang , edubezval@gmail.com Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, sunzhaosheng@hisilicon.com, gengyanping@hisilicon.com, Kevin Wangtao References: <20171017043941.GE7954@localhost.localdomain> <1508318150-108444-1-git-send-email-kevin.wangtao@hisilicon.com> From: Daniel Lezcano Message-ID: <9685721b-4593-029b-b8e8-d721526b7119@linaro.org> Date: Wed, 18 Oct 2017 17:54:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508318150-108444-1-git-send-email-kevin.wangtao@hisilicon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/2017 11:15, Tao Wang wrote: > From: Kevin Wangtao > > multi alarm interrupt forced a re-trigger of power_allocator_throttle > which changes the PID's actual sampling rate, this isn't optimal for > IPA, it is best to disable multi alarm support now and sort out this > issue later. > > Signed-off-by: Kevin Wangtao Did you test the series with this change? > --- > drivers/thermal/hisi_thermal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c > index 133238a..3b74c12 100644 > --- a/drivers/thermal/hisi_thermal.c > +++ b/drivers/thermal/hisi_thermal.c > @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data) > > /* set interrupt threshold */ > value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]); > - value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10; > hi3660_thermal_alarm_set(data->regs, sensor->id, value); > > /* enable interrupt */ > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog