From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C09C2BA18 for ; Mon, 6 Apr 2020 08:00:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77847206C3 for ; Mon, 6 Apr 2020 08:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbgDFIAw (ORCPT ); Mon, 6 Apr 2020 04:00:52 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12680 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726475AbgDFIAw (ORCPT ); Mon, 6 Apr 2020 04:00:52 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 79FAB66759F3822586F4; Mon, 6 Apr 2020 16:00:44 +0800 (CST) Received: from [127.0.0.1] (10.133.217.205) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Mon, 6 Apr 2020 16:00:35 +0800 Subject: Re: [PATCH] sched/arm64: store cpu topology before notify_cpu_starting To: Valentin Schneider CC: , , , , , , , , , , , , , , , , , , , , , , , , , , Sudeep Holla , "chengjian (D)" References: <855831b59e1b3774b11c3e33050eac4cc4639f06.1583332765.git.vpillai@digitalocean.com> <20200401114215.36640-1-cj.chengjian@huawei.com> From: "chengjian (D)" Message-ID: <9686e37d-5698-334d-5e23-70a1e2d804ec@huawei.com> Date: Mon, 6 Apr 2020 16:00:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.133.217.205] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/1 21:23, Valentin Schneider wrote: > (+LAKML, +Sudeep) > > On Wed, Apr 01 2020, Cheng Jian wrote: >> when SCHED_CORE enabled, sched_cpu_starting() uses thread_sibling as >> SMT_MASK to initialize rq->core, but only after store_cpu_topology(), >> the thread_sibling is ready for use. >> >> notify_cpu_starting() >> -> sched_cpu_starting() # use thread_sibling >> >> store_cpu_topology(cpu) >> -> update_siblings_masks # set thread_sibling >> >> Fix this by doing notify_cpu_starting later, just like x86 do. >> > I haven't been following the sched core stuff closely; can't this > rq->core assignment be done in sched_cpu_activate() instead? We already > look at the cpu_smt_mask() in there, and it is valid (we go through the > entirety of secondary_start_kernel() before getting anywhere near > CPUHP_AP_ACTIVE). > > I don't think this breaks anything, but without this dependency in > sched_cpu_starting() then there isn't really a reason for this move. Yes, it is correct to put the rq-> core assignment in sched_cpu_active(). The cpu_smt_mask is already valid here. I have made such an attempt on my own branch and passed the test. Thank you.     -- Cheng Jian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10EC5C2BA18 for ; Mon, 6 Apr 2020 08:01:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8B00206C3 for ; Mon, 6 Apr 2020 08:01:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A3erUnuO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8B00206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/hm21ai+P5LaPpYfmwExCfE8hsXsOqVS1+nO0q5hsWE=; b=A3erUnuOXTi8ptwdjFl1R0Si1 ED6oVYpNlwJg01KepGj/GdofLEKEEpV/XY3s28NSifgwelJzB9UefTzkHj1xZJtxK+crvxovEhlw3 q/6XLpLnYNQmatytfeW+GqZmB3skoYp4GTHrHrxBHWZOrsAHE8OaAG5Yx9AbIizeDRNFMFVrrmKEv 2+7JziJB9SMWjDLDaliTpo3R+xhXvG5ThEbP7fiiKPjMMjcOKAahx90eif6/6ee0uekLcVW2nrGQI U+FOjACmyTKaaI8Y63vYmgh5ntqCu+ZVPP8L4TcP+InL7SxTwbOSU0LuemyWwtLJxzAOlARn0PkTF aIYudEjvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLMgo-0002YX-7e; Mon, 06 Apr 2020 08:01:02 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLMgk-0002X2-ML for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 08:01:00 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 79FAB66759F3822586F4; Mon, 6 Apr 2020 16:00:44 +0800 (CST) Received: from [127.0.0.1] (10.133.217.205) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Mon, 6 Apr 2020 16:00:35 +0800 Subject: Re: [PATCH] sched/arm64: store cpu topology before notify_cpu_starting To: Valentin Schneider References: <855831b59e1b3774b11c3e33050eac4cc4639f06.1583332765.git.vpillai@digitalocean.com> <20200401114215.36640-1-cj.chengjian@huawei.com> From: "chengjian (D)" Message-ID: <9686e37d-5698-334d-5e23-70a1e2d804ec@huawei.com> Date: Mon, 6 Apr 2020 16:00:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.133.217.205] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_010058_920468_0BC7698B X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: joelaf@google.com, "chengjian \(D\)" , peterz@infradead.org, fweisbec@gmail.com, huawei.libin@huawei.com, joel@joelfernandes.org, mingo@kernel.org, aubrey.li@linux.intel.com, naravamudan@digitalocean.com, aaron.lwe@gmail.com, jdesfossez@digitalocean.com, w.f@huawei.com, pawan.kumar.gupta@linux.intel.com, pjt@google.com, kerrnel@google.com, keescook@chromium.org, xiexiuqi@huawei.com, vpillai@digitalocean.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, pauld@redhat.com, mgorman@techsingularity.net, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, aubrey.intel@gmail.com, Sudeep Holla , pbonzini@redhat.com, tim.c.chen@linux.intel.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjAvNC8xIDIxOjIzLCBWYWxlbnRpbiBTY2huZWlkZXIgd3JvdGU6Cj4gKCtMQUtNTCwg K1N1ZGVlcCkKPgo+IE9uIFdlZCwgQXByIDAxIDIwMjAsIENoZW5nIEppYW4gd3JvdGU6Cj4+IHdo ZW4gU0NIRURfQ09SRSBlbmFibGVkLCBzY2hlZF9jcHVfc3RhcnRpbmcoKSB1c2VzIHRocmVhZF9z aWJsaW5nIGFzCj4+IFNNVF9NQVNLIHRvIGluaXRpYWxpemUgcnEtPmNvcmUsIGJ1dCBvbmx5IGFm dGVyIHN0b3JlX2NwdV90b3BvbG9neSgpLAo+PiB0aGUgdGhyZWFkX3NpYmxpbmcgaXMgcmVhZHkg Zm9yIHVzZS4KPj4KPj4gICAgICAgIG5vdGlmeV9jcHVfc3RhcnRpbmcoKQo+PiAgICAgICAgICAg IC0+IHNjaGVkX2NwdV9zdGFydGluZygpCSMgdXNlIHRocmVhZF9zaWJsaW5nCj4+Cj4+ICAgICAg ICBzdG9yZV9jcHVfdG9wb2xvZ3koY3B1KQo+PiAgICAgICAgICAgIC0+IHVwZGF0ZV9zaWJsaW5n c19tYXNrcwkjIHNldCB0aHJlYWRfc2libGluZwo+Pgo+PiBGaXggdGhpcyBieSBkb2luZyBub3Rp ZnlfY3B1X3N0YXJ0aW5nIGxhdGVyLCBqdXN0IGxpa2UgeDg2IGRvLgo+Pgo+IEkgaGF2ZW4ndCBi ZWVuIGZvbGxvd2luZyB0aGUgc2NoZWQgY29yZSBzdHVmZiBjbG9zZWx5OyBjYW4ndCB0aGlzCj4g cnEtPmNvcmUgYXNzaWdubWVudCBiZSBkb25lIGluIHNjaGVkX2NwdV9hY3RpdmF0ZSgpIGluc3Rl YWQ/IFdlIGFscmVhZHkKPiBsb29rIGF0IHRoZSBjcHVfc210X21hc2soKSBpbiB0aGVyZSwgYW5k IGl0IGlzIHZhbGlkICh3ZSBnbyB0aHJvdWdoIHRoZQo+IGVudGlyZXR5IG9mIHNlY29uZGFyeV9z dGFydF9rZXJuZWwoKSBiZWZvcmUgZ2V0dGluZyBhbnl3aGVyZSBuZWFyCj4gQ1BVSFBfQVBfQUNU SVZFKS4KPgo+IEkgZG9uJ3QgdGhpbmsgdGhpcyBicmVha3MgYW55dGhpbmcsIGJ1dCB3aXRob3V0 IHRoaXMgZGVwZW5kZW5jeSBpbgo+IHNjaGVkX2NwdV9zdGFydGluZygpIHRoZW4gdGhlcmUgaXNu J3QgcmVhbGx5IGEgcmVhc29uIGZvciB0aGlzIG1vdmUuCgpZZXMsIGl0IGlzIGNvcnJlY3QgdG8g cHV0IHRoZSBycS0+IGNvcmUgYXNzaWdubWVudCBpbiBzY2hlZF9jcHVfYWN0aXZlKCkuCgpUaGUg Y3B1X3NtdF9tYXNrIGlzIGFscmVhZHkgdmFsaWQgaGVyZS4KCgpJIGhhdmUgbWFkZSBzdWNoIGFu IGF0dGVtcHQgb24gbXkgb3duIGJyYW5jaCBhbmQgcGFzc2VkIHRoZSB0ZXN0LgoKClRoYW5rIHlv dS4KCgogwqDCoMKgIC0tIENoZW5nIEppYW4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=